From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add fdm
Date: Mon, 18 Jan 2016 23:51:36 +0100
Message-ID: <87bn8i7b7r.fsf@gnu.org>
References: <87twma65vq.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aLIeF-0005Pl-5x
	for guix-devel@gnu.org; Mon, 18 Jan 2016 17:51:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aLIeC-0005Ne-0E
	for guix-devel@gnu.org; Mon, 18 Jan 2016 17:51:43 -0500
In-Reply-To: <87twma65vq.fsf@dustycloud.org> (Christopher Allan Webber's
	message of "Mon, 18 Jan 2016 11:30:29 -0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> From c0d0fde9785680a3642e2cd54f46c3b447cfbb1b Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Mon, 18 Jan 2016 11:25:16 -0800
> Subject: [PATCH] gnu: Add fdm.
>
> * gnu/packages/mail.scm (fdm): New variable.

[...]

> +    (license
> +     ;; Why point to Debian's copy?  Well, all the individual files have=
 a
> +     ;; copy of this license in their headers, but there's no seprate fi=
le
> +     ;; with that information.  Debian already provided us with a nice U=
RI
> +     ;; to point to...
> +     (non-copyleft
> +      (string-append
> +       "http://metadata.ftp-master.debian.org/"
> +       "changelogs/main/f/fdm/fdm_1.7+cvs20140912-1_copyright")))))

I would rather use <https://github.com/nicm/fdm/blob/master/command.c>,
which is likely more stable, and keep the comment about the lack of a
separate license file.

Otherwise LGTM, thanks!

Ludo=E2=80=99.