[PATCH] gnu: emacs-popup (new variable)

[PATCH] gnu: emacs-popup (new variable)

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 30 bytes --]

This patch adds emacs-popup.


[-- Attachment #2: 0001-gnu-add-emacs-popup.patch --]
[-- Type: text/x-patch, Size: 1971 bytes --]

From 66abaf9cfcb566e2027acf145b06963c6e52a99c Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 15 Feb 2016 19:06:16 +0100
Subject: [PATCH] gnu: add emacs-popup

* gnu/packages/emacs.scm (emacs-popup): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 48417e6..78a6af0 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2014, 2015, 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1452,3 +1453,29 @@ supports editing Lisp source files, @{slime-mode} adds support for
 interacting with a running Common Lisp process for compilation,
 debugging, documentation lookup, and so on.")
     (license license:gpl2+)))
+
+(define-public emacs-popup
+  (package
+    (name "emacs-popup")
+    (version "0.5.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/auto-complete/popup-el/archive/v"
+             version
+             ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1yrgfj8y69xmcb6kwgplhq68ndm9410qwh7sd2knnd1gchpphdc0"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs" ,emacs-no-x)))
+    (home-page "https://github.com/auto-complete/popup-el")
+    (synopsis "Visual Popup User Interface for Emacs")
+    (description
+     "Popup.el is a visual popup user interface library for Emacs.
+  This provides a basic API and common UI widgets such as popup
+tooltips and popup menus.")
+    (license license:gpl3+)))
-- 
2.6.3


[-- Attachment #3: Type: text/plain, Size: 16 bytes --]


thanks,
-- 
ng

Re: [PATCH] gnu: emacs-popup (new variable)

[Alex Kost]

Nils Gillmann (2016-02-15 21:13 +0300) wrote:

> This patch adds emacs-popup.

Hi, only nitpicks from my side, so I'm going to commit this patch (no
need to resend an updated version) in several days, if there will be no
other comments.

> From 66abaf9cfcb566e2027acf145b06963c6e52a99c Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 15 Feb 2016 19:06:16 +0100
> Subject: [PATCH] gnu: add emacs-popup
                        Add emacs-popup.
typos:                  ↑              ↑

> * gnu/packages/emacs.scm (emacs-popup): New variable.
> ---
>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 48417e6..78a6af0 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright © 2014, 2015, 2016 Alex Kost <alezost@gmail.com>
>  ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
> +;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1452,3 +1453,29 @@ supports editing Lisp source files, @{slime-mode} adds support for
>  interacting with a running Common Lisp process for compilation,
>  debugging, documentation lookup, and so on.")
>      (license license:gpl2+)))
> +
> +(define-public emacs-popup
> +  (package
> +    (name "emacs-popup")
> +    (version "0.5.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/auto-complete/popup-el/archive/v"
> +             version
> +             ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1yrgfj8y69xmcb6kwgplhq68ndm9410qwh7sd2knnd1gchpphdc0"))))
> +    (build-system emacs-build-system)
> +    (native-inputs
> +     `(("emacs" ,emacs-no-x)))
> +    (home-page "https://github.com/auto-complete/popup-el")
> +    (synopsis "Visual Popup User Interface for Emacs")
> +    (description
> +     "Popup.el is a visual popup user interface library for Emacs.
> +  This provides a basic API and common UI widgets such as popup
   ↑↑
Redundant spaces.

> +tooltips and popup menus.")
> +    (license license:gpl3+)))

-- 
Alex

Re: [PATCH] gnu: emacs-popup (new variable)

[Nils Gillmann]

Alex Kost <alezost@gmail.com> writes:

> Nils Gillmann (2016-02-15 21:13 +0300) wrote:
>
>> This patch adds emacs-popup.
>
> Hi, only nitpicks from my side, so I'm going to commit this patch (no
> need to resend an updated version) in several days, if there will be no
> other comments.
>
>> From 66abaf9cfcb566e2027acf145b06963c6e52a99c Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 15 Feb 2016 19:06:16 +0100
>> Subject: [PATCH] gnu: add emacs-popup
>                         Add emacs-popup.
> typos:                  ↑              ↑
>
>> * gnu/packages/emacs.scm (emacs-popup): New variable.
>> ---
>>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 48417e6..78a6af0 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -5,6 +5,7 @@
>>  ;;; Copyright © 2014, 2015, 2016 Alex Kost <alezost@gmail.com>
>>  ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
>>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>> +;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -1452,3 +1453,29 @@ supports editing Lisp source files, @{slime-mode} adds support for
>>  interacting with a running Common Lisp process for compilation,
>>  debugging, documentation lookup, and so on.")
>>      (license license:gpl2+)))
>> +
>> +(define-public emacs-popup
>> +  (package
>> +    (name "emacs-popup")
>> +    (version "0.5.3")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/auto-complete/popup-el/archive/v"
>> +             version
>> +             ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "1yrgfj8y69xmcb6kwgplhq68ndm9410qwh7sd2knnd1gchpphdc0"))))
>> +    (build-system emacs-build-system)
>> +    (native-inputs
>> +     `(("emacs" ,emacs-no-x)))
>> +    (home-page "https://github.com/auto-complete/popup-el")
>> +    (synopsis "Visual Popup User Interface for Emacs")
>> +    (description
>> +     "Popup.el is a visual popup user interface library for Emacs.
>> +  This provides a basic API and common UI widgets such as popup
>    ↑↑
> Redundant spaces.

Sentences should be separated by two whitespaces. So this does
not apply when the end of one sentence and the beginning of
another is separated by a linebreak? Should I read the guile
coding style document to get more input on this?

>
>> +tooltips and popup menus.")
>> +    (license license:gpl3+)))

-- 
ng

Re: [PATCH] gnu: emacs-popup (new variable)

[Alex Kost]

Nils Gillmann (2016-02-16 03:03 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>> Nils Gillmann (2016-02-15 21:13 +0300) wrote:
[...]
>>> +    (description
>>> +     "Popup.el is a visual popup user interface library for Emacs.
>>> +  This provides a basic API and common UI widgets such as popup
>>    ↑↑
>> Redundant spaces.
>
> Sentences should be separated by two whitespaces. So this does
> not apply when the end of one sentence and the beginning of
> another is separated by a linebreak?

Well I always thought it's a natural way.  If it appears to be that we
should add spaces in the beginning of a line, I couldn't sleep anymore!!

> Should I read the guile
> coding style document to get more input on this?

I have no idea where it could be documented.

-- 
Alex

Re: [PATCH] gnu: emacs-popup (new variable)

[Alex Kost]

Nils Gillmann (2016-02-15 21:13 +0300) wrote:

> This patch adds emacs-popup.
>
>
> From 66abaf9cfcb566e2027acf145b06963c6e52a99c Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 15 Feb 2016 19:06:16 +0100
> Subject: [PATCH] gnu: add emacs-popup

Pushed, thanks!

[...]
> +    (description
> +     "Popup.el is a visual popup user interface library for Emacs.
> +  This provides a basic API and common UI widgets such as popup
   ↑↑
I removed these spaces after all :-)

-- 
Alex