Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

[Alex Kost <alezost@gmail.com>]

Ludovic Courtès (2016-03-03 19:55 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Sorry if it was discussed but why 'package-full-name' from (guix
>> packages) wasn't changed?
>
> I think I was afraid that existing uses in unexpected place would break,
> such as when using the full name as anchor names in HTML.
>
> But then I also remember a version of ‘package-full-name’ that took an
> optional separator that defaulted to ‘@’.  I forgot the details!  :-)
> I don’t think it’s crucial though.  WDYT?

I don't have an opinion on changing 'package-full-name' as I have no
idea what may be broken after this change.  As there are no visible
breaks now, it can be left unchanged I believe.

>> Also I have a question regarding hydra.  Will hydra jobs still have
>> such names as "git-2.6.3" or will they also be changed to "git@2.6.3"?
>
> I would leave them unchanged.

Great, that's what I thought, thanks!

>> From 2dbfe087905cc08715bba0f4d4dd0093fd93372b Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Thu, 3 Mar 2016 12:53:03 +0300
>> Subject: [PATCH 1/2] emacs: Use '@' to separate package names and version
>>  numbers.
>>
>> This is a followup to commit 1b846da8c372bee78851439fd9e72b2499115e5a.
>>
>> * emacs/guix-base.el (guix-package-name-specification): Use "@" instead
>> of "-".
>> * emacs/guix-main.scm (name+version->full-name): Likewise.
>> (package-inputs-names): Use 'make-package-specification' instead of
>> 'package-full-name'.
>> (full-name->name+version): Update the docstring.
>> * emacs/guix-ui-package.el (guix-packages-by-name): Likewise.
>
> Looks good.  I forgot about these places where the “full name” matters,
> sorry about that.

It's not your fault, I didn't remember about this place either :-)

>> From c6825b189f7b5d908c5fbe36d933fbe187cbc4bd Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Thu, 3 Mar 2016 12:55:21 +0300
>> Subject: [PATCH 2/2] emacs: hydra: Use '-' to separate job names and version
>>  numbers.
>>
>> * emacs/guix-hydra.el (guix-hydra-job-name-specification): New procedure.
>> * emacs/guix-ui-package.el (guix-package-info-insert-systems)
>> (guix-package-list-latest-builds): Use it.
>
> OK!

Thanks!  I have committed both patches.

-- 
Alex