[PATCH] gnu: Add nlopt.

[PATCH] gnu: Add nlopt.

[Roel Janssen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-nlopt.patch --]
[-- Type: text/x-patch, Size: 1540 bytes --]

From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 7 Apr 2016 13:22:35 +0200
Subject: [PATCH] gnu: Add nlopt.

* gnu/packages/maths.scm (nlopt): New variable.
---
 gnu/packages/maths.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index adebf09..6b9d79d 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -911,7 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
     (inputs
      (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
 
+(define-public nlopt
+  (package
+    (name "nlopt")
+    (version "2.4.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
+    (home-page "http://ab-initio.mit.edu/wiki/")
+    (synopsis "Library for non-linear optimization")
+    (description "NLopt is a library for non-linear optimization, providing a
+common interface for a number of different free optimization routines available
+online as well as original implementations of various other algorithms.")
+    (license license:lgpl3)))
+
 (define-public superlu
   (package
     (name "superlu")
-- 
2.5.5


[-- Attachment #2: Type: text/plain, Size: 285 bytes --]

Dear Guix,

I'd like to add 'nlopt', a library for non-lineair optimizations.
By passing "--enable-shared" to the configure script, it generates
a shared library as well as a static library.  Otherwise, this patch
is pretty standard.

Thanks for your time.

Kind regards,
Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Leo Famulari]

On Thu, Apr 07, 2016 at 01:26:21PM +0200, Roel Janssen wrote:
> From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Thu, 7 Apr 2016 13:22:35 +0200
> Subject: [PATCH] gnu: Add nlopt.
> 
> * gnu/packages/maths.scm (nlopt): New variable.

Looks good, but for some reason I can't apply the patch to my source
tree. Does it work for you?

> ---
>  gnu/packages/maths.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index adebf09..6b9d79d 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -911,7 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
>      (inputs
>       (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
>  
> +(define-public nlopt
> +  (package
> +    (name "nlopt")
> +    (version "2.4.2")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
> +    (home-page "http://ab-initio.mit.edu/wiki/")
> +    (synopsis "Library for non-linear optimization")
> +    (description "NLopt is a library for non-linear optimization, providing a
> +common interface for a number of different free optimization routines available
> +online as well as original implementations of various other algorithms.")
> +    (license license:lgpl3)))
> +
>  (define-public superlu
>    (package
>      (name "superlu")
> -- 
> 2.5.5
> 

> Dear Guix,
> 
> I'd like to add 'nlopt', a library for non-lineair optimizations.
> By passing "--enable-shared" to the configure script, it generates
> a shared library as well as a static library.  Otherwise, this patch
> is pretty standard.
> 
> Thanks for your time.
> 
> Kind regards,
> Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Alex Kost]

Leo Famulari (2016-04-07 18:44 +0300) wrote:

> On Thu, Apr 07, 2016 at 01:26:21PM +0200, Roel Janssen wrote:
>> From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 7 Apr 2016 13:22:35 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>> 
>> * gnu/packages/maths.scm (nlopt): New variable.
>
> Looks good, but for some reason I can't apply the patch to my source
> tree. Does it work for you?

Same for me, there is some problem with this patch.

-- 
Alex

Re: [PATCH] gnu: Add nlopt.

[Alex Kost]

Roel Janssen (2016-04-07 14:26 +0300) wrote:

> From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Thu, 7 Apr 2016 13:22:35 +0200
> Subject: [PATCH] gnu: Add nlopt.
>
> * gnu/packages/maths.scm (nlopt): New variable.
> ---
>  gnu/packages/maths.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index adebf09..6b9d79d 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -911,7 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
>      (inputs
>       (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
>  
> +(define-public nlopt
> +  (package
> +    (name "nlopt")
> +    (version "2.4.2")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
> +    (home-page "http://ab-initio.mit.edu/wiki/")
> +    (synopsis "Library for non-linear optimization")
> +    (description "NLopt is a library for non-linear optimization, providing a
> +common interface for a number of different free optimization routines available
> +online as well as original implementations of various other algorithms.")
> +    (license license:lgpl3)))

Where did you get that it is lgpl3?  COPYING names GNU LGPL version 2.1
or later and MIT (which is 'expat').  I quickly looked at the source
files: most of them do not have a license header, the others use the
mentioned licenses, so I think it should be:

  (license (list license:lgpl2.1+ license:expat))

-- 
Alex

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-nlopt.patch --]
[-- Type: text/x-patch, Size: 1539 bytes --]

From bb41efffc5258b0fe79b744e96981411b94e6aad Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 7 Apr 2016 22:45:01 +0200
Subject: [PATCH] gnu: Add nlopt.

* gnu/packages/maths.scm (nlopt): New variable.
---
 gnu/packages/maths.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index adebf09..6b9d79d 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -911,6 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
     (inputs
      (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
 
+(define-public nlopt
+  (package
+    (name "nlopt")
+    (version "2.4.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
+    (home-page "http://ab-initio.mit.edu/wiki/")
+    (synopsis "Library for non-linear optimization")
+    (description "NLopt is a library for nonlinear optimization, providing a
+common interface for a number of different free optimization routines available
+online as well as original implementations of various other algorithms.")
+    (license license:lgpl3)))
+
 (define-public superlu
   (package
     (name "superlu")
-- 
2.5.5


[-- Attachment #2: Type: text/plain, Size: 746 bytes --]

Dear Leo,

Thanks again for reviewing my package.  I really appreciate your
time and effort. :)

Leo Famulari writes:

> On Thu, Apr 07, 2016 at 01:26:21PM +0200, Roel Janssen wrote:
>> From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 7 Apr 2016 13:22:35 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>> 
>> * gnu/packages/maths.scm (nlopt): New variable.
>
> Looks good, but for some reason I can't apply the patch to my source
> tree. Does it work for you?

Strangely enough, I couldn't apply it either.  I don't know what
happened..  I regenerated the patch, and now I was able to apply it to
my source tree.  Hopefully it works for you too now.

Kind regards,
Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-nlopt.patch --]
[-- Type: text/x-patch, Size: 1542 bytes --]

From 224c4e32265dc229663f693759bd1cafa5ee6a20 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 7 Apr 2016 23:18:04 +0200
Subject: [PATCH] gnu: Add nlopt.

* gnu/packages/maths.scm (nlopt): New variable.
---
 gnu/packages/maths.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index adebf09..2a79e41 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -911,6 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
     (inputs
      (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
 
+(define-public nlopt
+  (package
+    (name "nlopt")
+    (version "2.4.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
+    (home-page "http://ab-initio.mit.edu/wiki/")
+    (synopsis "Library for non-linear optimization")
+    (description "NLopt is a library for nonlinear optimization, providing a
+common interface for a number of different free optimization routines available
+online as well as original implementations of various other algorithms.")
+    (license license:lgpl2.1+)))
+
 (define-public superlu
   (package
     (name "superlu")
-- 
2.5.5


[-- Attachment #2: Type: text/plain, Size: 2579 bytes --]


Alex Kost writes:

> Roel Janssen (2016-04-07 14:26 +0300) wrote:
>
>> From 558175f69ba52446eca75ab79b641c8f0204093e Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 7 Apr 2016 13:22:35 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>>
>> * gnu/packages/maths.scm (nlopt): New variable.
>> ---
>>  gnu/packages/maths.scm | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
>> index adebf09..6b9d79d 100644
>> --- a/gnu/packages/maths.scm
>> +++ b/gnu/packages/maths.scm
>> @@ -911,7 +911,26 @@ sparse system of linear equations A x = b using Guassian elimination.")
>>      (inputs
>>       (alist-delete "pt-scotch" (package-inputs mumps-openmpi)))))
>>  
>> +(define-public nlopt
>> +  (package
>> +    (name "nlopt")
>> +    (version "2.4.2")
>> +    (source (origin
>> +      (method url-fetch)
>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>> +                          version ".tar.gz"))
>> +      (sha256
>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:configure-flags '("--enable-shared"))) ; Also create a shared library.
>> +    (home-page "http://ab-initio.mit.edu/wiki/")
>> +    (synopsis "Library for non-linear optimization")
>> +    (description "NLopt is a library for non-linear optimization, providing a
>> +common interface for a number of different free optimization routines available
>> +online as well as original implementations of various other algorithms.")
>> +    (license license:lgpl3)))
>
> Where did you get that it is lgpl3?  COPYING names GNU LGPL version 2.1
> or later and MIT (which is 'expat').  I quickly looked at the source
> files: most of them do not have a license header, the others use the
> mentioned licenses, so I think it should be:
>
>   (license (list license:lgpl2.1+ license:expat))

Thanks for your carefulness.

On the website they explain it as follows:  A part of the code is "LGPL"
(no version specified) and a part is MIT.  The most "restrictive" (as
they call it), determines the license of the whole package (and thus
it's "LGPL").

I actually couldn't find which version of the LGPL, so I assumed the
latest variant.  The COPYING file does mention version 2.1 or later.
The same file also reassures that the entirety of the package is
governed by the LGPL (v2.1+):

http://ab-initio.mit.edu/wiki/index.php/NLopt_License_and_Copyright

I attached a new patch.

Kind regards,
Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Ludovic Courtès]

Hi,

I have it too, in a private repo.  :-)

--8<---------------cut here---------------start------------->8---
(define-public nlopt
  (package
    (name "nlopt")
    (version "2.4.2")
    (source (origin
              (method url-fetch)
              (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
                                  version ".tar.gz"))
              (sha256
               (base32
                "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
    (build-system gnu-build-system)
    (arguments
     '(;; Shared libraries are not built by default.  They are required to
       ;; build the Guile, Octave, and Python bindings.
       #:configure-flags '("--enable-shared")

       #:phases (alist-cons-before
                 'configure 'pre-configure
                 (lambda* (#:key outputs #:allow-other-keys)
                   ;; Make sure the Scheme module refers to the library by its
                   ;; absolute file name (we cannot do that from a snippet
                   ;; because the expansion of @libdir@ contains
                   ;; ${exec_prefix}.)
                   (let ((out (assoc-ref outputs "out")))
                     (substitute* "swig/nlopt.scm.in"
                       (("libnlopt")
                        (string-append out "/lib/libnlopt")))
                     #t))
                 %standard-phases)))
    ;; TODO: Figure out which dependencies make sense here.
    (inputs `(;; ("octave" ,octave)
              ("guile" ,guile-2.0)))
    (native-inputs `(("pkg-config" ,pkg-config)))
    (home-page "http://ab-initio.mit.edu/nlopt/")
    (synopsis "Library for nonlinear optimization")
    (description
     "NLOpt is a library for nonlinear optimization, providing a common
interface for a number of different free optimization routines available
online as well as original implementations of various other algorithms.")
    (license l:lgpl2.1+)))
--8<---------------cut here---------------end--------------->8---

The reason I did not include in Guix is because of unclear licensing on
a file.  I emailed the author in Jan. 2015 but didn’t get an answer:

--8<---------------cut here---------------start------------->8---
I’m looking at packaging NLOpt for Guix, a free software GNU/Linux
distribution.

I noticed this paragraph in luksan/COPYRIGHT:

    Subroutines PBUN, PNEW, PVAR, PSEN, Copyright ACM, 2001. The original
    versions were published in Transactions on Mathematical Software, 
    Vol.27, 2001, pp.193-213. Here are the author's modifications. They
    are posted here by permission of ACM for your personal use. Not for
    redistribution. Subroutines PLIP, PSEN, Copyright Jan Vlcek, 2007. 
    The remaining subroutines, Copyright Ladislav Luksan, 2007. Many of  
    sparse matrix modules were prepared by Miroslav Tuma.

My understanding is that these subroutines cannot be redistributed nor
modified by anyone; what do you think?

Thank you,
Ludovic.
--8<---------------cut here---------------end--------------->8---

Could you check if this is still relevant, and possibly get in touch
with them?

Thanks,
Ludo’.

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

Hi Ludo’,

I think the licensing page on the website is pretty clear:
http://ab-initio.mit.edu/wiki/index.php/NLopt_License_and_Copyright

From the page:
> The NLopt library is under the GNU Lesser General Public License
> (LGPL), and the copyrights are owned by a variety of authors.

And:
> The combination of all of this software is under the conjunction of the
> license terms, and in particular they are limited by the most
> restrictive of the licenses for the portions, which in this case is the
> LGPL. (The other portions of NLopt are under LGPL-compatible,
> less-restrictive licenses like the MIT license. So, if you remove the
> LGPL portions, which are currently code by Ladislav Luksan, the
> remainder reverts to a looser license.)

What's not clear from that page is which version of the LGPL.  But
that's cleared up in the COPYING file of the source repository.

Kind regards,
Roel Janssen


Ludovic Courtès writes:

> Hi,
>
> I have it too, in a private repo.  :-)
>
> --8<---------------cut here---------------start------------->8---
> (define-public nlopt
>   (package
>     (name "nlopt")
>     (version "2.4.2")
>     (source (origin
>               (method url-fetch)
>               (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>                                   version ".tar.gz"))
>               (sha256
>                (base32
>                 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>     (build-system gnu-build-system)
>     (arguments
>      '(;; Shared libraries are not built by default.  They are required to
>        ;; build the Guile, Octave, and Python bindings.
>        #:configure-flags '("--enable-shared")
>
>        #:phases (alist-cons-before
>                  'configure 'pre-configure
>                  (lambda* (#:key outputs #:allow-other-keys)
>                    ;; Make sure the Scheme module refers to the library by its
>                    ;; absolute file name (we cannot do that from a snippet
>                    ;; because the expansion of @libdir@ contains
>                    ;; ${exec_prefix}.)
>                    (let ((out (assoc-ref outputs "out")))
>                      (substitute* "swig/nlopt.scm.in"
>                        (("libnlopt")
>                         (string-append out "/lib/libnlopt")))
>                      #t))
>                  %standard-phases)))
>     ;; TODO: Figure out which dependencies make sense here.
>     (inputs `(;; ("octave" ,octave)
>               ("guile" ,guile-2.0)))
>     (native-inputs `(("pkg-config" ,pkg-config)))
>     (home-page "http://ab-initio.mit.edu/nlopt/")
>     (synopsis "Library for nonlinear optimization")
>     (description
>      "NLOpt is a library for nonlinear optimization, providing a common
> interface for a number of different free optimization routines available
> online as well as original implementations of various other algorithms.")
>     (license l:lgpl2.1+)))
> --8<---------------cut here---------------end--------------->8---
>
> The reason I did not include in Guix is because of unclear licensing on
> a file.  I emailed the author in Jan. 2015 but didn’t get an answer:
>
> --8<---------------cut here---------------start------------->8---
> I’m looking at packaging NLOpt for Guix, a free software GNU/Linux
> distribution.
>
> I noticed this paragraph in luksan/COPYRIGHT:
>
>     Subroutines PBUN, PNEW, PVAR, PSEN, Copyright ACM, 2001. The original
>     versions were published in Transactions on Mathematical Software, 
>     Vol.27, 2001, pp.193-213. Here are the author's modifications. They
>     are posted here by permission of ACM for your personal use. Not for
>     redistribution. Subroutines PLIP, PSEN, Copyright Jan Vlcek, 2007. 
>     The remaining subroutines, Copyright Ladislav Luksan, 2007. Many of  
>     sparse matrix modules were prepared by Miroslav Tuma.
>
> My understanding is that these subroutines cannot be redistributed nor
> modified by anyone; what do you think?
>
> Thank you,
> Ludovic.
> --8<---------------cut here---------------end--------------->8---
>
> Could you check if this is still relevant, and possibly get in touch
> with them?
>
> Thanks,
> Ludo’.

Re: [PATCH] gnu: Add nlopt.

[Mathieu Lirzin]

Roel Janssen <roel@gnu.org> writes:

> Strangely enough, I couldn't apply it either.  I don't know what
> happened..  I regenerated the patch, and now I was able to apply it to
> my source tree.  Hopefully it works for you too now.

This problem has already happened to me last year.  I suspect it is/was a
bug in Git.

-- 
Mathieu Lirzin

Re: [PATCH] gnu: Add nlopt.

[Leo Famulari]

On Fri, Apr 08, 2016 at 12:18:15PM +0200, Mathieu Lirzin wrote:
> Roel Janssen <roel@gnu.org> writes:
> 
> > Strangely enough, I couldn't apply it either.  I don't know what
> > happened..  I regenerated the patch, and now I was able to apply it to
> > my source tree.  Hopefully it works for you too now.
> 
> This problem has already happened to me last year.  I suspect it is/was a
> bug in Git.

I've attached the diffoscope report (HTML) between the first two patches
in this thread.

The diff header in the 'bad' patch says that the hunk applies to 7
lines.  In the 'good' patch, the header instead says 6.

The 'bad' patch can be applied when that parameter is changed to 6.

I wonder if the bug can be reproduced?

Re: [PATCH] gnu: Add nlopt.

[Mathieu Lirzin]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Apr 08, 2016 at 12:18:15PM +0200, Mathieu Lirzin wrote:
>> Roel Janssen <roel@gnu.org> writes:
>> 
>> > Strangely enough, I couldn't apply it either.  I don't know what
>> > happened..  I regenerated the patch, and now I was able to apply it to
>> > my source tree.  Hopefully it works for you too now.
>> 
>> This problem has already happened to me last year.  I suspect it is/was a
>> bug in Git.
>
> I've attached the diffoscope report (HTML) between the first two patches
> in this thread.

Do you mean “attached” like in email attachment?  If so then I don't see
the attachment...

> The diff header in the 'bad' patch says that the hunk applies to 7
> lines.  In the 'good' patch, the header instead says 6.
>
> The 'bad' patch can be applied when that parameter is changed to 6.
>
> I wonder if the bug can be reproduced?

That would be great.  :)

-- 
Mathieu Lirzin

Re: [PATCH] gnu: Add nlopt.

[Ludovic Courtès]

Hello!

Roel Janssen <roel@gnu.org> skribis:

> I think the licensing page on the website is pretty clear:
> http://ab-initio.mit.edu/wiki/index.php/NLopt_License_and_Copyright
>
> From the page:
>> The NLopt library is under the GNU Lesser General Public License
>> (LGPL), and the copyrights are owned by a variety of authors.
>
> And:
>> The combination of all of this software is under the conjunction of the
>> license terms, and in particular they are limited by the most
>> restrictive of the licenses for the portions, which in this case is the
>> LGPL. (The other portions of NLopt are under LGPL-compatible,
>> less-restrictive licenses like the MIT license. So, if you remove the
>> LGPL portions, which are currently code by Ladislav Luksan, the
>> remainder reverts to a looser license.)

Still, according to luksan/COPYRIGHT, “[s]ubroutines PBUN, PNEW, PVAR,
PSEN” are “for your personal use […] [n]ot for redistribution”.

So my understanding is that we need to remove those four subroutines.
The rest in that directory is LGPLv2.1+.

WDYT?

I don’t see it at
<https://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.
Debian has a package: <https://packages.debian.org/source/sid/nlopt>.
Could you check if they apply any patches?

Besides, I suggest reusing the bits about Guile bindings from the patch
I sent.

Thanks,
Ludo’.

Re: [PATCH] gnu: Add nlopt.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

On Sat, Apr 09, 2016 at 12:54:43PM +0200, Mathieu Lirzin wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, Apr 08, 2016 at 12:18:15PM +0200, Mathieu Lirzin wrote:
> >> Roel Janssen <roel@gnu.org> writes:
> >> 
> >> > Strangely enough, I couldn't apply it either.  I don't know what
> >> > happened..  I regenerated the patch, and now I was able to apply it to
> >> > my source tree.  Hopefully it works for you too now.
> >> 
> >> This problem has already happened to me last year.  I suspect it is/was a
> >> bug in Git.
> >
> > I've attached the diffoscope report (HTML) between the first two patches
> > in this thread.
> 
> Do you mean “attached” like in email attachment?  If so then I don't see
> the attachment...

Gah, I do that all the time! :p

Here it is...

[-- Attachment #2: report.html --]
[-- Type: text/html, Size: 26605 bytes --]

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

Ludovic Courtès writes:

> Hello!
>
> Roel Janssen <roel@gnu.org> skribis:
>
>> I think the licensing page on the website is pretty clear:
>> http://ab-initio.mit.edu/wiki/index.php/NLopt_License_and_Copyright
>>
>> From the page:
>>> The NLopt library is under the GNU Lesser General Public License
>>> (LGPL), and the copyrights are owned by a variety of authors.
>>
>> And:
>>> The combination of all of this software is under the conjunction of the
>>> license terms, and in particular they are limited by the most
>>> restrictive of the licenses for the portions, which in this case is the
>>> LGPL. (The other portions of NLopt are under LGPL-compatible,
>>> less-restrictive licenses like the MIT license. So, if you remove the
>>> LGPL portions, which are currently code by Ladislav Luksan, the
>>> remainder reverts to a looser license.)
>
> Still, according to luksan/COPYRIGHT, “[s]ubroutines PBUN, PNEW, PVAR,
> PSEN” are “for your personal use […] [n]ot for redistribution”.
>
> So my understanding is that we need to remove those four subroutines.
> The rest in that directory is LGPLv2.1+.
>
> WDYT?

I agree to your understanding.

A little later in the same file I found: "This library (with exception
of PBUN, PNEW, PVAR, PSEN) is a free software".

> I don’t see it at
> <https://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.
> Debian has a package: <https://packages.debian.org/source/sid/nlopt>.
> Could you check if they apply any patches?

I haven't found any patches.  So I dug a little deeper and attempted to
remove them myself with a patch, but I haven't been able to find these
subroutines.

I ran the following commands on the root of the source directory:
grep -i -r "pbun" .
grep -i -r "pmin" .
grep -i -r "psen" .
grep -i -r "pvar" .

And I haven't found the routines.  So I think we're safe.  That could
also be why Debian doesn't have a patch for this either.

> Besides, I suggest reusing the bits about Guile bindings from the patch
> I sent.

Shall I prepare a new patch?

Kind regards,
Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> Ludovic Courtès writes:

[...]

>> Still, according to luksan/COPYRIGHT, “[s]ubroutines PBUN, PNEW, PVAR,
>> PSEN” are “for your personal use […] [n]ot for redistribution”.
>>
>> So my understanding is that we need to remove those four subroutines.
>> The rest in that directory is LGPLv2.1+.
>>
>> WDYT?
>
> I agree to your understanding.
>
> A little later in the same file I found: "This library (with exception
> of PBUN, PNEW, PVAR, PSEN) is a free software".
>
>> I don’t see it at
>> <https://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.
>> Debian has a package: <https://packages.debian.org/source/sid/nlopt>.
>> Could you check if they apply any patches?
>
> I haven't found any patches.  So I dug a little deeper and attempted to
> remove them myself with a patch, but I haven't been able to find these
> subroutines.
>
> I ran the following commands on the root of the source directory:
> grep -i -r "pbun" .
> grep -i -r "pmin" .
> grep -i -r "psen" .
> grep -i -r "pvar" .
>
> And I haven't found the routines.  So I think we're safe.  That could
> also be why Debian doesn't have a patch for this either.

Indeed.  Actually, luksan/README states:

  [We also did not convert the PMIN, PBUN, PNEW, or PVAR subroutines
  since these were published in ACM Trans. on Math. Software (TOMS) and
  are subject to the non-free ACM licensing conditions.]

So indeed, the COPYRIGHT file is confusing, but we’re safe.

Sorry for the false alarm.

>> Besides, I suggest reusing the bits about Guile bindings from the patch
>> I sent.
>
> Shall I prepare a new patch?

Yes please.

Thank you!

Ludo’.

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

Ludovic Courtès writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> Ludovic Courtès writes:
>
> [...]
>
>>> Still, according to luksan/COPYRIGHT, “[s]ubroutines PBUN, PNEW, PVAR,
>>> PSEN” are “for your personal use […] [n]ot for redistribution”.
>>>
>>> So my understanding is that we need to remove those four subroutines.
>>> The rest in that directory is LGPLv2.1+.
>>>
>>> WDYT?
>>
>> I agree to your understanding.
>>
>> A little later in the same file I found: "This library (with exception
>> of PBUN, PNEW, PVAR, PSEN) is a free software".
>>
>>> I don’t see it at
>>> <https://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.
>>> Debian has a package: <https://packages.debian.org/source/sid/nlopt>.
>>> Could you check if they apply any patches?
>>
>> I haven't found any patches.  So I dug a little deeper and attempted to
>> remove them myself with a patch, but I haven't been able to find these
>> subroutines.
>>
>> I ran the following commands on the root of the source directory:
>> grep -i -r "pbun" .
>> grep -i -r "pmin" .
>> grep -i -r "psen" .
>> grep -i -r "pvar" .
>>
>> And I haven't found the routines.  So I think we're safe.  That could
>> also be why Debian doesn't have a patch for this either.
>
> Indeed.  Actually, luksan/README states:
>
>   [We also did not convert the PMIN, PBUN, PNEW, or PVAR subroutines
>   since these were published in ACM Trans. on Math. Software (TOMS) and
>   are subject to the non-free ACM licensing conditions.]
>
> So indeed, the COPYRIGHT file is confusing, but we’re safe.
>
> Sorry for the false alarm.
>
>>> Besides, I suggest reusing the bits about Guile bindings from the patch
>>> I sent.
>>
>> Shall I prepare a new patch?
>
> Yes please.

I added your magic for Guile.  Here is the patch:

From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 3 May 2016 14:30:25 +0200
Subject: [PATCH] gnu: Add nlopt.

* gnu/packages/maths.scm (nlopt): New variable.
---
 gnu/packages/maths.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index d37897d..0ad6f4b 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -59,6 +59,7 @@
   #:use-module (gnu packages less)
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages guile)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages m4)
@@ -430,6 +431,41 @@ extremely large and complex data collections.")
     (license (license:x11-style
               "http://www.hdfgroup.org/ftp/HDF5/current/src/unpacked/COPYING"))))
 
+(define-public nlopt
+  (package
+    (name "nlopt")
+    (version "2.4.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--enable-shared") ; Also create a shared library.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'fix-guile-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Make sure the Scheme module refers to the library by its
+             ;; absolute file name (we cannot do that from a snippet
+             ;; because the expansion of @libdir@ contains
+             ;; ${exec_prefix}.)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "swig/nlopt.scm.in"
+                 (("libnlopt")
+                  (string-append out "/lib/libnlopt")))
+               #t))))))
+    (inputs
+     `(("guile" ,guile-2.0)))
+    (home-page "http://ab-initio.mit.edu/wiki/")
+    (synopsis "Library for nonlinear optimization")
+    (description "NLopt is a library for nonlinear optimization, providing a
+common interface for a number of different free optimization routines available
+online as well as original implementations of various other algorithms.")
+    (license license:lgpl2.1+)))
+
 
 ;; For a fully featured Octave, users  are strongly recommended also to install
 ;; the following packages: texinfo, less, ghostscript, gnuplot.
-- 
2.7.4

Re: [PATCH] gnu: Add nlopt.

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> I added your magic for Guile.  Here is the patch:
>
>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 3 May 2016 14:30:25 +0200
> Subject: [PATCH] gnu: Add nlopt.
>
> * gnu/packages/maths.scm (nlopt): New variable.

Pushed with minor cosmetic changes, notably:

> +    (source (origin
> +      (method url-fetch)
> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))

“(method” should be indented below the “r” of “origin” (I think this
pattern also appears in the R patches you recently submitted.)

Thank you!

Ludo’.

PS: I’d be happy to add configuration files for editors other than Emacs
    so that everyone has their indentation and stuff properly set up.

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

Ludovic Courtès writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> I added your magic for Guile.  Here is the patch:
>>
>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Tue, 3 May 2016 14:30:25 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>>
>> * gnu/packages/maths.scm (nlopt): New variable.
>
> Pushed with minor cosmetic changes, notably:
>
>> +    (source (origin
>> +      (method url-fetch)
>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>> +                          version ".tar.gz"))
>> +      (sha256
>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>
> “(method” should be indented below the “r” of “origin” (I think this
> pattern also appears in the R patches you recently submitted.)
>
> Thank you!

I've been submitting most packages this way.  Should I align (method
...) to the r in origin for all packages in the future?

Thank you!

Kind regards,
Roel Janssen

Re: [PATCH] gnu: Add nlopt.

[Alex Kost]

Roel Janssen (2016-05-03 23:17 +0300) wrote:

> Ludovic Courtès writes:
>
>> Roel Janssen <roel@gnu.org> skribis:
>>
>>> I added your magic for Guile.  Here is the patch:
>>>
>>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <roel@gnu.org>
>>> Date: Tue, 3 May 2016 14:30:25 +0200
>>> Subject: [PATCH] gnu: Add nlopt.
>>>
>>> * gnu/packages/maths.scm (nlopt): New variable.
>>
>> Pushed with minor cosmetic changes, notably:
>>
>>> +    (source (origin
>>> +      (method url-fetch)
>>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>>> +                          version ".tar.gz"))
>>> +      (sha256
>>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>>
>> “(method” should be indented below the “r” of “origin” (I think this
>> pattern also appears in the R patches you recently submitted.)
>>
>> Thank you!
>
> I've been submitting most packages this way.  Should I align (method
> ...) to the r in origin for all packages in the future?

Yes, 'method' is a sub-expression or 'origin', not of 'source', and it
should be aligned accordingly.

I suppose you don't use Emacs; may I ask what editor do you use?

-- 
Alex

Re: [PATCH] gnu: Add nlopt.

[Roel Janssen]

Alex Kost writes:

> Roel Janssen (2016-05-03 23:17 +0300) wrote:
>
>> I've been submitting most packages this way.  Should I align (method
>> ...) to the r in origin for all packages in the future?
>
> Yes, 'method' is a sub-expression or 'origin', not of 'source', and it
> should be aligned accordingly.
>
> I suppose you don't use Emacs; may I ask what editor do you use?

I use Emacs.  So, how did it adjust indenting to source instead of
origin you might ask next..  The answer is: I did that manually :-).

Kind regards,
Roel Janssen