From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Wingo <wingo@igalia.com>
Subject: Re: [PATCH 05/11] gnu: gmp: build shared library for mingw.
Date: Mon, 09 May 2016 09:20:51 +0200
Message-ID: <87bn4f3df0.fsf@igalia.com>
References: <1462740169-15029-1-git-send-email-janneke@gnu.org>
	<1462740169-15029-6-git-send-email-janneke@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1azfUy-0007x0-JC
	for guix-devel@gnu.org; Mon, 09 May 2016 03:21:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1azfUv-0004ic-65
	for guix-devel@gnu.org; Mon, 09 May 2016 03:21:00 -0400
In-Reply-To: <1462740169-15029-6-git-send-email-janneke@gnu.org> (Jan
	Nieuwenhuizen's message of "Sun, 8 May 2016 22:42:43 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

On Sun 08 May 2016 22:42, Jan Nieuwenhuizen <janneke@gnu.org> writes:

> * gnu/packages/multiprecision.scm (gmp)[MINGW]: Use --enable-shared.
> ---
>  gnu/packages/multiprecision.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/multiprecision.scm b/gnu/packages/multiprecisio=
n.scm
> index 9924323..8c1a9b7 100644
> --- a/gnu/packages/multiprecision.scm
> +++ b/gnu/packages/multiprecision.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright =C2=A9 2014 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright =C2=A9 2015 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright =C2=A9 2016 Nicolas Goaziou <mail@nicolasgoaziou.fr>
> +;;; Copyright =C2=A9 2016 Jan Nieuwenhuizen <janneke@gnu.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -49,7 +50,13 @@
>                  '(;; Build a "fat binary", with routines for several
>                    ;; sub-architectures.
>                    "--enable-fat"
> -                  "--enable-cxx")))
> +                  "--enable-cxx"
> +                  ,@(cond ((mingw-target?)
> +                           ;; Static and shared cannot be built in one g=
o:
> +                           ;; they produce different headers.  We need s=
hared.
> +                           `("--disable-static"
> +                             "--enable-shared"))
> +                          (else '())))))
>     (synopsis "Multiple-precision arithmetic library")
>     (description
>      "GMP is a library for arbitrary precision arithmetic, operating on

LGTM.  A bit of a shame that mingw is an abnormal architecture in this
way -- i.e. other targets will have both static and shared libraries,
but not this one.  Oh well, this does look to be the right thing for
now.