From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [PATCH] Add opendht. Date: Fri, 03 Jun 2016 10:27:32 -0500 Message-ID: <87bn3iuwbf.fsf@openmailbox.org> References: <87h9de2txi.fsf@openmailbox.org> <20160531220415.GA31130@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8r0v-00087q-7x for guix-devel@gnu.org; Fri, 03 Jun 2016 11:27:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8r0q-0000qG-1w for guix-devel@gnu.org; Fri, 03 Jun 2016 11:27:56 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:46662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8r0p-0000q5-Ns for guix-devel@gnu.org; Fri, 03 Jun 2016 11:27:51 -0400 In-Reply-To: <20160531220415.GA31130@jasmine> (Leo Famulari's message of "Tue, 31 May 2016 18:04:15 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Hi Leo, Thank you for your review! Leo Famulari writes: > On Tue, May 31, 2016 at 09:17:29AM -0500, Lukas Gradl wrote: >> * gnu/packages/telephony.scm (opendht): New variable. > > I wonder if there is a better module? Distributed hash tables aren't > specific to telephony. I am thinking about putting it in crypto.scm. Do you think that is more appropriate? > >> +(define-public opendht >> + (let ((commit "13f8c13ac4ebb3b43474d91ca48b42a1019083f4")) >> + ;; This is the commit used by the Ring Project. > > If Ring works with the latest tagged release, then I think we should use > that instead of the Git commit. They released only 3 days ago, so it's > unlikely that Ring needs some feature that's not in the tarball. > OK, Yes, I will look into that. >> + (inputs >> + `(("gnutls" ,gnutls) >> + ("nettle" ,nettle) >> + ("msgpack" ,msgpack) >> + ("readline" ,readline))) > > I noticed they bundle Argon2, which is a password hashing library: > https://github.com/savoirfairelinux/opendht/tree/master/src/argon2 > > I think we should delete the bundled library in an origin snippet and > make opendht use an external package. Oops! Sorry that I missed that. I looked onto that and argon2 bundles blake2. I am working on patches for the two of those right now. > >> + (native-inputs >> + `(("autoconf" ,autoconf) >> + ("pkg-config" ,pkg-config) >> + ("automake" ,automake) >> + ("libtool" ,libtool))) >> + (arguments >> + `(#:configure-flags '("--disable-tools" "--disable-python") >> + #:phases (modify-phases %standard-phases >> + (add-before 'configure 'autoconf >> + (lambda _ >> + (zero? (system* "autoreconf" "-vfi"))))))) > > If we package a tagged release, it's possible that we won't need to > bootstrap. > >> + (license gpl3)))) > > I skimmed the source files, and most of them said "either version 3 of > the License, or (at your option) any later version.", so we should use > gpl3+. Ah, OK. I just looked at their README which just says GPL3. I will change that. I am planning to submit a new patch after argon2 + blake2. Hopefully that will happen this weekend. Thank you! Best, Lukas