From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: services: Add dicod-service.
Date: Sun, 05 Jun 2016 00:43:31 +0200 [thread overview]
Message-ID: <87bn3gtw18.fsf@gnu.org> (raw)
In-Reply-To: <1464969365-1593-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Fri, 3 Jun 2016 23:56:05 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> * gnu/services/dict.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Various Services): Document it.
Nice! I’ve been wanting it for some time. :-)
> +@deffn {Scheme Procedure} dicod-service [#:config (dicod-configuration)]
> +Return a service that runs the dicod daemon, an implementation of
@command{dicod}
> +DICT server.
^
Add @pxref{Dicod,,, dico, GNU Dico Manual}
> The optional CONFIG argument specifies the configuration
@var{config}
> +for dicod, which should be a <dicod-configuration> object, by default
@command{dicod}, @code{<dicod-configuration>}
> +it serving the GNU Collaborative International Dictonary of English.
s/it serving/it serves/.
It would be nice to document ‘dicod-configuration’ with @deftp, as done
in some other places.
Also, maybe we should mention or cross-reference how to configure dico
to connect to localhost, since the default is to connect elsewhere;
WDYT?
> + (($ <dicod-database> name module options)
> + `("
> +load-module " ,module ";
> +database {
> + name \"" ,name "\";
> + handler \"" ,module
> + ;; append the options list using space as separator before each element.
> + ,@(fold-right (cut cons* " " <> <>) '() options) "\";
> +}\n")))
> + databases))))
Maybe (string-join (fold-right cons '() options)) instead.
> +(define* (dicod-service #:key (config (dicod-configuration)))
> + "Return a service that runs the dicod daemon, an implementation of
> +DICT server."
Use the guix.texi doc as a docstring.
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-06-04 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 15:56 [PATCH] gnu: services: Add dicod-service 宋文武
2016-06-04 22:43 ` Ludovic Courtès [this message]
2016-06-05 5:51 ` 宋文武
2016-06-05 12:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn3gtw18.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).