From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add ircii. Date: Tue, 09 Aug 2016 21:38:55 +0200 Message-ID: <87bn11enqo.fsf@elephly.net> References: <87fuqoe10m.fsf@we.make.ritual.n0.is> <20160802005413.GB15847@jasmine> <20160802075834.GB1957@solar> <878twf4dcu.fsf@we.make.ritual.n0.is> <87y44bhfvz.fsf@elephly.net> <87zioridda.fsf@we.make.ritual.n0.is> <87a8gr9xox.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXCrm-0007PT-01 for guix-devel@gnu.org; Tue, 09 Aug 2016 15:39:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXCrg-0002G4-T5 for guix-devel@gnu.org; Tue, 09 Aug 2016 15:39:08 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXCrg-0002Fu-KS for guix-devel@gnu.org; Tue, 09 Aug 2016 15:39:04 -0400 In-reply-to: <87a8gr9xox.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 writes: > From 1438e5654cfd5f4eb4141a42580bd73c716e7134 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Mon, 1 Aug 2016 19:31:23 +0000 > Subject: [PATCH] gnu: Add ircii. > * gnu/packages/irc.scm (ircii): New variable. > --- > gnu/packages/irc.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm > index 03f014a..7087022 100644 > --- a/gnu/packages/irc.scm > +++ b/gnu/packages/irc.scm > @@ -194,3 +194,49 @@ with a keyboard, though it also supports mouse. It is customizable > and extensible with plugins and scripts.") > (home-page "http://www.weechat.org/") > (license license:gpl3))) > + > +(define-public ircii > + (package > + (name "ircii") > + (version "20151120") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://ircii.warped.com/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "178dc279f5j894qvp96dzz7c0jpryqlcqw5g0dc9yaxg9kgw1lqm")))) > + (build-system gnu-build-system) > + ;; TODO: Configure with socks client (ghc-socks is too big). > + (arguments > + `(#:tests? #f Please add a comment like “; no tests”. > + #:configure-flags (list > + ;;(string-append "--prefix=" (assoc-ref %outputs "out")) I suppose this line can be removed? > + "--enable-ipv6" > + (string-append "--with-openssl=" > + (assoc-ref %build-inputs "openssl")) > + "--with-emacs-meta-keys") What does this do? > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-bsdinstall-absolute-path-bins That’s a somewhat unusual name for a phase. In other packages we use something simpler like “fix-paths” or “patch-paths”. > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "bsdinstall" > + (("/bin/strip") "strip") > + (("/bin/cp") "cp") > + (("/bin/chmod") "chmod") > + (("/etc/chown") "chown") > + (("/bin/chgrp") "chgrp") > + (("/bin/mkdir") "mkdir") > + (("/bin/rm") "rm") > + (("/bin/mv") "mv"))))))) Four things: - you don’t use the “inputs” key, so you can simplify this to “(lambda _ …)” - “/etc/chown”? - can this be simplified by just deleting any occurrence of “/bin/”? - please end this phase with “#t” as “substitute*” has no defined return value. > + (inputs > + `(("ncurses" ,ncurses) > + ("openssl" ,openssl))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("perl" ,perl))) > + (home-page "http://www.eterna.com.au/ircii/") > + (synopsis "Terminal-based IRC and ICB client") > + (description > + "ircII is a terminal based IRC and ICB client for UNIX systems.") I’d remove “for UNIX systems”. Is there more that can be said about this application? > + (license license:bsd-3))) > -- > 2.9.2 ~~ Ricardo