From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 1/7] gnu: lua: Build with support for dynamic libraries.
Date: Sun, 28 Aug 2016 10:23:20 +0200
Message-ID: <87bn0d5mkn.fsf@elephly.net>
References: <20160822193918.27397-1-rekado@elephly.net>
	<20160822193918.27397-2-rekado@elephly.net>
	<20160823020240.3304b5a4@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bdvNU-0000SC-4q
	for guix-devel@gnu.org; Sun, 28 Aug 2016 04:23:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bdvNL-0004T3-Ig
	for guix-devel@gnu.org; Sun, 28 Aug 2016 04:23:34 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24410)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bdvNL-0004RX-9a
	for guix-devel@gnu.org; Sun, 28 Aug 2016 04:23:31 -0400
In-reply-to: <20160823020240.3304b5a4@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: gno <gnopap@gmail.com>
Cc: guix-devel@gnu.org


gno <gnopap@gmail.com> writes:

> On Mon, 22 Aug 2016 21:39:12 +0200
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
>> * gnu/packages/lua.scm (lua)[arguments]: Use regular build phase and
>> add make-flags.
>> ---
>>  gnu/packages/lua.scm | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
>> index b4b5dee..52606f4 100644
>> --- a/gnu/packages/lua.scm
>> +++ b/gnu/packages/lua.scm
>> @@ -4,6 +4,7 @@
>>  ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
>>  ;;; Copyright © 2014 Andreas Enge <andreas@enge.fr>
>>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
>> +;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -44,14 +45,15 @@
>>      (inputs `(("readline" ,readline)))
>>      (arguments
>>       '(#:modules ((guix build gnu-build-system)
>> -                    (guix build utils)
>> -                    (srfi srfi-1))
>> +                  (guix build utils)
>> +                  (srfi srfi-1))
>>         #:test-target "test"
>> +       #:make-flags
>> +       '("CFLAGS=-fPIC -DLUA_DL_DLOPEN -DLUA_USE_POSIX"
>> +         "linux")
>>         #:phases
>>         (modify-phases %standard-phases
>>           (delete 'configure)
>> -         (replace 'build
>> -           (lambda _ (zero? (system* "make" "CFLAGS=-fPIC"
>> "linux")))) (replace 'install
>>             (lambda* (#:key outputs #:allow-other-keys)
>>               (let ((out (assoc-ref outputs "out")))
>
>
> This doesn't work for me - lua-lgi still complains about lua not being
> able to dynamically load. But this does work:
>
> (replace 'build
>   (lambda _ (zero? (system* "make"
>      "LDFLAGS=-ldl" "CFLAGS=-fPIC -DLUA_USE_DLOPEN" "linux"))))
>
> I tried adding LDFLAGS in #make-flags to no avail.

I don’t have a package for “lua-lgi” so I cannot reproduce this.  All I
can say is that it appears to work in the case of prosody.  Without
LUA_DL_DLOPEN defined Lua will not even attempt to load dynamic
libraries.

~~ Ricardo