From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add praat Date: Sat, 03 Sep 2016 15:43:58 +0200 Message-ID: <87bn05m735.fsf@gnu.org> References: <50962352-6623-74c9-0f33-3615daf46fcc@openmailbox.org> <87h99yo5ms.fsf@gnu.org> <5131120b-a4a5-c53f-478d-5973c4458267@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgBEs-0004tZ-IE for guix-devel@gnu.org; Sat, 03 Sep 2016 09:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgBEo-00034s-BT for guix-devel@gnu.org; Sat, 03 Sep 2016 09:44:05 -0400 In-Reply-To: <5131120b-a4a5-c53f-478d-5973c4458267@openmailbox.org> (Brendan Tildesley's message of "Sat, 3 Sep 2016 01:12:03 +1000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Brendan Tildesley Cc: guix-devel@gnu.org Brendan Tildesley skribis: > On 2016-09-02 22:20, Ludovic Court=C3=A8s wrote: >> [...] >> >>> + (add-after 'unpack 'be-timeless >>> + (lambda _ >>> + (substitute* "external/portaudio/pa_front.c" >>> + ((" \\(built \" __DATE__ \" \" __TIME__ \"\\)") "")) >>> + #t)) >> Could you move it to a =E2=80=98snippet=E2=80=99 in the =E2=80=98origin= =E2=80=99 form? (See the >> =E2=80=98squeak-vm=E2=80=99 package for an example.) >> > Sure. >> As Alex Griffin wrote, we should remove all of external/ in =E2=80=98sni= ppet=E2=80=99 >> (see item #9 about =E2=80=9Cbundling=E2=80=9D at >> ), >> and instead add GSL, GLPK, FLAC, etc. as =E2=80=98inputs=E2=80=99 of the= package. >> >> Would you like to try it? >> >> I think this is the only remaining blocker here. >> >> Thank you for your work! >> >> Ludo=E2=80=99. > > I don't have any issue with this per se, but I haven't the slightest > clue how to due it. Roughly: (origin =E2=80=A6 (modules '((guix build utils))) (snippet '(delete-file-recursively "external"))) ;like =E2=80=98rm -rf= =E2=80=99 The =E2=80=98crossmap=E2=80=99 package is one example of that. > Praat Has no configure script, rather it just has a make file that > compiles everything into a single binary. is the code in FLAC the same > as the flac package?? I hope so. > How would I go about making these external packages? Most or all of them are already packaged. So just add: (inputs `(("gsl" ,gsl) ("glpk" ,gplk) ("flac" ,flac) =E2=80=A6)) Maybe you=E2=80=99ll also have to tweak the Makefile so it doesn=E2=80=99t = try to build stuff in external/. Could you give it a try and report back? > Also I'm wondering how to go about adding an icon and .desktop file > supporting internationalisation. It seems upstream should do this but > they haven't so the package is nothing like a standard GNU program. Is > it possible to do all this without learning C? Probably, but let=E2=80=99s leave that for a subsequent patch. :-) Thank you! Ludo=E2=80=99.