Re: [PATCH] gnu: Add praat

[ludo@gnu.org (Ludovic Courtès)]

Brendan Tildesley <brendan.tildesley@openmailbox.org> skribis:

> On 2016-09-02 22:20, Ludovic Courtès wrote:
>> [...]
>>
>>> +         (add-after 'unpack 'be-timeless
>>> +           (lambda _
>>> +             (substitute* "external/portaudio/pa_front.c"
>>> +               ((" \\(built \" __DATE__  \" \" __TIME__ \"\\)") ""))
>>> +             #t))
>> Could you move it to a ‘snippet’ in the ‘origin’ form?  (See the
>> ‘squeak-vm’ package for an example.)
>>
> Sure.
>> As Alex Griffin wrote, we should remove all of external/ in ‘snippet’
>> (see item #9 about “bundling” at
>> <https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>),
>> and instead add GSL, GLPK, FLAC, etc. as ‘inputs’ of the package.
>>
>> Would you like to try it?
>>
>> I think this is the only remaining blocker here.
>>
>> Thank you for your work!
>>
>> Ludo’.
>
> I don't have any issue with this per se, but I haven't the slightest
> clue how to due it.

Roughly:

  (origin
    …
    (modules '((guix build utils)))
    (snippet '(delete-file-recursively "external")))  ;like ‘rm -rf’

The ‘crossmap’ package is one example of that.

> Praat Has no configure script, rather it just has a make file that
> compiles everything into a single binary. is the code in FLAC the same
> as the flac package??

I hope so.

> How would I go about making these external packages?

Most or all of them are already packaged.  So just add:

  (inputs
    `(("gsl" ,gsl)
      ("glpk" ,gplk)
      ("flac" ,flac)
      …))

Maybe you’ll also have to tweak the Makefile so it doesn’t try to build
stuff in external/.

Could you give it a try and report back?

> Also I'm wondering how to go about adding an icon and .desktop file
> supporting internationalisation. It seems upstream should do this but
> they haven't so the package is nothing like a standard GNU program. Is
> it possible to do all this without learning C?

Probably, but let’s leave that for a subsequent patch.  :-)

Thank you!

Ludo’.