From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: femtolisp: Remove support for mips and armhf. Date: Tue, 27 Sep 2016 08:13:53 +0000 Message-ID: <87bmz9pxoe.fsf@we.make.ritual.n0.is> References: <87mvjbegxs.fsf@elephly.net> <87oa3rmtg8.fsf@we.make.ritual.n0.is> <87d1k6etze.fsf@elephly.net> <874m5i3k0h.fsf@we.make.ritual.n0.is> <87y42u24nc.fsf@we.make.ritual.n0.is> <87a8faer2a.fsf@elephly.net> <871t0miy7t.fsf@we.make.ritual.n0.is> <877faeeo7m.fsf@elephly.net> <87sht2afyr.fsf@we.make.ritual.n0.is> <87h99ieljb.fsf@we.make.ritual.n0.is> <20160918100239.GA4752@solar> <87fuovp06b.fsf@gnu.org> <87mvj0z4bu.fsf@we.make.ritual.n0.is> <87mvivj68i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bonWz-0006aS-5n for guix-devel@gnu.org; Tue, 27 Sep 2016 04:14:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bonWs-00005Y-5Z for guix-devel@gnu.org; Tue, 27 Sep 2016 04:14:24 -0400 Received: from aibo.runbox.com ([91.220.196.211]:36810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bonWr-0008WD-Po for guix-devel@gnu.org; Tue, 27 Sep 2016 04:14:18 -0400 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1bonWo-0007IB-9T for guix-devel@gnu.org; Tue, 27 Sep 2016 10:14:14 +0200 Received: from xd9bb8a2f.dyn.telefonica.de ([217.187.138.47] helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1bonWU-0007M3-Va for guix-devel@gnu.org; Tue, 27 Sep 2016 10:13:55 +0200 In-Reply-To: <87mvivj68i.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > ng0 skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Andreas Enge skribis: >>> >>>> femtolisp fails on mips and arm: >>>> http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload >>>> with the message >>>> In file included from llt/llt.h:6:0, >>>> from string.c:16: >>>> llt/utils.h:27:4: error: #error "unknown architecture" >>>> # error "unknown architecture" >>>> >>>> Should it be disabled there? >>> >>> Definitely. It would be worth checking in that file the set of >>> supported architectures, and putting them in =E2=80=98supported-platfor= ms=E2=80=99. >> >> I'm not exactly sure what's supported, I found win32, osx, freebsd, >> openbsd, and that's it. > > Sorry, I really meant supported architectures, which is what utils.h > seems to be about (although I don=E2=80=99t have the source here to check= ). > Could you check the #ifdefs in there? #if defined( __amd64__ ) || defined( _M_AMD64 ) # define ARCH_X86_64 # define __CPU__ 686 #elif defined( _M_IX86 )//msvs, intel, digital mars, watcom # if ! defined( __386__ ) # error "unsupported target: 16-bit x86" # endif # define ARCH_X86 # define __CPU__ ( _M_IX86 + 86 ) #elif defined( __i686__ )//gnu c # define ARCH_X86 # define __CPU__ 686 #elif defined( __i586__ )//gnu c # define ARCH_X86 # define __CPU__ 586 #elif defined( __i486__ )//gnu c # define ARCH_X86 # define __CPU__ 486 #elif defined( __i386__ )//gnu c # define ARCH_X86 # define __CPU__ 386 #else # error "unknown architecture" #endif >> + ;; armhf and mips64el fail to build, it has been reported upstrea= m: >> + ;; https://github.com/JeffBezanson/femtolisp/issues/25 >> + (supported-systems >> + (and >> + (delete "armhf-linux" %supported-systems) >> + (delete "mips64el-linux" %supported-systems) >> + #t)) > > =E2=80=98supported-systems=E2=80=99 must be a list of strings, so: > > (fold delete %supported-systems > '("armhf-linux" "mips64el-linux")) > > Thanks, > Ludo=E2=80=99. > --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-femtolisp-Remove-support-for-mips-and-armhf.patch Content-Transfer-Encoding: quoted-printable From=2032c4d64ada9ab2573a00385b15b2b0a03a6fa44f Mon Sep 17 00:00:00 2001 From: ng0 Date: Thu, 22 Sep 2016 09:08:03 +0000 Subject: [PATCH] gnu: femtolisp: Remove support for mips and armhf. * gnu/packages/lisp.scm (femtolisp)[supported-systems]: New field, remove support for mips64el and armhf. =2D-- gnu/packages/lisp.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index d1180a7..439433a 100644 =2D-- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -3,7 +3,7 @@ ;;; Copyright =C2=A9 2015 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer ;;; Copyright =C2=A9 2015 Mark H Weaver ;;; Copyright =C2=A9 2016 Federico Beffa =2D;;; Copyright =C2=A9 2016 ng0 +;;; Copyright =C2=A9 2016 ng0 ;;; Copyright =C2=A9 2016 Andy Patterson ;;; ;;; This file is part of GNU Guix. @@ -44,7 +44,8 @@ #:use-module (gnu packages ed) #:use-module (gnu packages m4) #:use-module (gnu packages version-control) =2D #:use-module (ice-9 match)) + #:use-module (ice-9 match) + #:use-module (srfi srfi-1)) =20 (define-public gcl (package @@ -501,6 +502,11 @@ the InterLisp Standard.") (sha256 (base32 "04rnwllxnl86zw8c6pwxznn49bvkvh0f1lfliy085vjzvlq3rgja"))= )) + ;; See "utils.h" for supported systems. Upstream bug: + ;; https://github.com/JeffBezanson/femtolisp/issues/25 + (supported-systems + (fold delete %supported-systems + '("armhf-linux" "mips64el-linux"))) (build-system gnu-build-system) (arguments `(#:make-flags '("CC=3Dgcc" "release") =2D-=20 2.10.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 ng0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJX6ipBAAoJEAKilhUMIBgjEa0P/3qcAVBL1LalUx1MlNDAwso4 RBe4qSQmJMaQzMDivo1WHVGkS5wJzFXnXzRjZHMbOtzOsMZN93G4kvVQynVYCdXW pIBFDHvzTPo0K5/LlXmmoKnaG5DK8L0VPz4+tH+bj+LJOVnDw6s0i7Mi2/eiqwfV VzoQZhlS0GLim5pdQYMDjpR2DyrvvECnyLBEX3pKATOp7M4uJE3DslrId/v+Jzna II7MYKvQdH+gTzVwJ5Omwe2kedFuBPrFyJpGIWwGxKtR1KYTzmx8tzbnAmB5Kr59 1jUBuI56qUQjOini6zNwSQ+nrTscRb9lbf1RBMQUYeZF5R3IMdQ+AcDdPwEd34Ur WyBuu7PqJFfXZaZuL/PKx3AZ3YyT9LDQATLrh65h0syd3SC0SuA2ciOLP47vcAI1 G+ubAuktdGcMMeEbmAgE/CELVz5eqg3bGh3hUabhV4WVKhlR1SFdA5YBOuuo37w9 BloWIv+VtOklhC6KVKzrq8sWCg+EE1dmbng69RoTA65Qy7xh62/ODg98atPV2LFF OouM715EM31OGgIjbfkk5VhyWmzMIYT8RskHtIoUgPYLQQP23WRqziHtplz+XgWr F5jR42vGRycZsuYV3X26bQZf6kyQUUqeSR+0R4rSiH4Jgr1S6QLggYndWmPYSeno yF27od18tshaAJOCl7rr =oR3z -----END PGP SIGNATURE----- --==-=-=--