From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH v2 2/3] gnu: Add hidapi. Date: Fri, 28 Oct 2016 18:35:27 +0300 Message-ID: <87bmy4trk0.fsf@openmailbox.org> References: <20161026210807.27390-1-theodoros.for@openmailbox.org> <20161026210807.27390-3-theodoros.for@openmailbox.org> <87funhf11d.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c09F8-0004sv-Oy for guix-devel@gnu.org; Fri, 28 Oct 2016 11:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c09F4-0004XU-MJ for guix-devel@gnu.org; Fri, 28 Oct 2016 11:38:54 -0400 Received: from smtp1.openmailbox.org ([62.4.1.35]:54900) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c09F4-0004X8-BE for guix-devel@gnu.org; Fri, 28 Oct 2016 11:38:50 -0400 In-reply-to: <87funhf11d.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Guix-devel Ricardo Wurmus writes: > Theodoros Foradis writes: > >> * gnu/packages/hidapi.scm: New file. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. >> --- >> gnu/local.mk | 1 + >> gnu/packages/hidapi.scm | 63 ++++++++++++++++++++++++++++++++++++++++= +++++++++ >> 2 files changed, 64 insertions(+) >> create mode 100644 gnu/packages/hidapi.scm >> >> diff --git a/gnu/local.mk b/gnu/local.mk >> index ff2d976..9019b98 100644 >> --- a/gnu/local.mk >> +++ b/gnu/local.mk >> @@ -178,6 +178,7 @@ GNU_SYSTEM_MODULES =3D \ >> %D%/packages/gxmessage.scm \ >> %D%/packages/haskell.scm \ >> %D%/packages/hexedit.scm \ >> + %D%/packages/hidapi.scm \ >> %D%/packages/hugs.scm \ >> %D%/packages/hurd.scm \ >> %D%/packages/ibus.scm \ >> diff --git a/gnu/packages/hidapi.scm b/gnu/packages/hidapi.scm >> new file mode 100644 >> index 0000000..88e5eba >> --- /dev/null >> +++ b/gnu/packages/hidapi.scm >> @@ -0,0 +1,63 @@ >> +;;; GNU Guix --- Functional package management for GNU >> +;;; Copyright =C2=A9 2016 Theodoros Foradis >> +;;; >> +;;; This file is part of GNU Guix. >> +;;; >> +;;; GNU Guix is free software; you can redistribute it and/or modify = it >> +;;; under the terms of the GNU General Public License as published by >> +;;; the Free Software Foundation; either version 3 of the License, or= (at >> +;;; your option) any later version. >> +;;; >> +;;; GNU Guix is distributed in the hope that it will be useful, but >> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of >> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +;;; GNU General Public License for more details. >> +;;; >> +;;; You should have received a copy of the GNU General Public License >> +;;; along with GNU Guix. If not, see . >> + >> +(define-module (gnu packages hidapi) >> + #:use-module (guix packages) >> + #:use-module (guix download) >> + #:use-module ((guix licenses) #:prefix license:) >> + #:use-module (guix build-system gnu) >> + #:use-module (gnu packages) >> + #:use-module (gnu packages autotools) >> + #:use-module (gnu packages libusb) >> + #:use-module (gnu packages linux) >> + #:use-module (gnu packages pkg-config)) >> + >> +(define-public hidapi >> + (package >> + (name "hidapi") >> + (version "0.8.0-rc1") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/signal11/hidapi= /archive/hidapi-" >> + version ".tar.gz")) >> + (sha256 >> + (base32 >> + "0qdgyj9rgb7n0nk3ghfswrhzzknxqn4ibn3wj8g4r828pw07451w= ")))) >> + (build-system gnu-build-system) >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-before 'configure 'bootstrap >> + (lambda _ >> + (zero? (system* "autoreconf" "-vfi"))))))) >> + (inputs >> + `(("libusb" ,libusb) >> + ("udev" ,eudev))) >> + (native-inputs >> + `(("autoconf" ,autoconf) >> + ("automake" ,automake) >> + ("libtool" ,libtool) >> + ("pkg-config" ,pkg-config))) >> + (home-page "http://www.signal11.us/oss/hidapi/") >> + (synopsis "HID API library") >> + (description >> + "HIDAPI is a library which allows an application to interface wi= th USB and Bluetooth >> + HID-Class devices.") > > There should be no indentation for the continuing line starting with > =E2=80=9CHID-Class=E2=80=9D. > Ok. > I wonder, should this rather go to =E2=80=9Clibusb.scm=E2=80=9D? Havin= g a separate > module just for this one package seems a little excessive :) > I wondered this as well, I can move is to libusb, if it's more appropriate. >> + (license (list license:gpl3 ;HIDAPI can be used under one of >> three licenses. > > I=E2=80=99d move the comment above the =E2=80=9Clicense=E2=80=9D field = because it doesn=E2=80=99t apply > to the GPL in particular. Ok. > >> + license:bsd-3 >> + license:non-copyleft)))) ;LICENSE-orig.txt - permi= ssive license > > =E2=80=9Cnon-copyleft=E2=80=9D takes at least one argument. In this ca= se this would be > > (license:non-copyleft "file://LICENCE-orig.txt") > > There=E2=80=99s no need to mention that it=E2=80=99s a =E2=80=9Cpermiss= ive=E2=80=9D (or =E2=80=9Cpush-over=E2=80=9D) > license, because that=E2=80=99s what non-copyleft already states. > > ~~ Ricardo Thanks, I'll fix that as well. --=20 Theodoros Foradis