From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] git-download: Add some helpers.
Date: Tue, 03 Jan 2017 13:28:45 +0100 [thread overview]
Message-ID: <87bmvo8gzm.fsf@gnu.org> (raw)
In-Reply-To: <20170102171958.32131-1-david@craven.ch> (David Craven's message of "Mon, 2 Jan 2017 18:19:52 +0100")
David Craven <david@craven.ch> skribis:
> * guix/git-download.scm (git-version, git-file-name): New variables.
> ---
> guix/git-download.scm | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/guix/git-download.scm b/guix/git-download.scm
> index 81d1d4fbf..c453aaa6d 100644
> --- a/guix/git-download.scm
> +++ b/guix/git-download.scm
> @@ -30,7 +30,9 @@
> git-reference-commit
> git-reference-recursive?
>
> - git-fetch))
> + git-fetch
> + git-version
> + git-file-name))
>
> ;;; Commentary:
> ;;;
> @@ -110,4 +112,10 @@ HASH-ALGO (a symbol). Use NAME as the file name, or a generic name if #f."
> #:guile-for-build guile
> #:local-build? #t)))
>
> +(define (git-version version revision commit)
> + (string-append version "-" revision "." (string-take commit 7)))
> +
> +(define (git-file-name name version)
> + (string-append name "-" version "-checkout"))
Please add a docstring. OK with this change, thank you!
Ludo’.
prev parent reply other threads:[~2017-01-03 12:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 17:19 [PATCH 1/7] git-download: Add some helpers David Craven
2017-01-02 17:19 ` [PATCH 2/7] gnu: Order module imports in (gnu packages haskell) alphabetically David Craven
2017-01-03 12:22 ` Ludovic Courtès
2017-01-02 17:19 ` [PATCH 3/7] gnu: idris: Update to 0.99 David Craven
2017-01-03 12:22 ` Ludovic Courtès
2017-01-03 12:29 ` Ludovic Courtès
2017-01-02 17:19 ` [PATCH 4/7] gnu: Add idris-lightyear David Craven
2017-01-03 12:26 ` Ludovic Courtès
2017-01-03 13:13 ` David Craven
2017-01-03 15:05 ` Ludovic Courtès
2017-01-03 15:08 ` David Craven
2017-01-03 18:21 ` David Craven
2017-01-05 10:43 ` Ludovic Courtès
2017-01-02 17:19 ` [PATCH 5/7] gnu: Add idris-wl-pprint David Craven
2017-01-03 12:28 ` Ludovic Courtès
2017-01-02 17:19 ` [PATCH 6/7] gnu: Add idris-bifunctors David Craven
2017-01-03 12:27 ` Ludovic Courtès
2017-01-02 17:19 ` [PATCH 7/7] gnu: Add idris-lens David Craven
2017-01-03 12:27 ` Ludovic Courtès
2017-01-03 12:28 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmvo8gzm.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).