From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang\, Ying" Subject: Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output Date: Sun, 05 Feb 2017 18:33:37 +0800 Message-ID: <87bmuhgc5a.fsf@163.com> References: <20170205050306.3349-1-huang_ying_caritas@163.com> <87fujtdtdy.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caK8k-0003uM-U2 for guix-devel@gnu.org; Sun, 05 Feb 2017 05:33:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caK8h-0004PY-RG for guix-devel@gnu.org; Sun, 05 Feb 2017 05:33:50 -0500 Received: from m12-12.163.com ([220.181.12.12]:48292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caK8h-0004NN-0S for guix-devel@gnu.org; Sun, 05 Feb 2017 05:33:47 -0500 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: iyzsong@member.fsf.org Cc: guix-devel@gnu.org Hi, Wenwu, Thanks for comments! iyzsong@member.fsf.org (宋文武) writes: > huang_ying_caritas@163.com writes: > >> * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output. >> >> Signed-off-by: "Huang, Ying" >> --- >> gnu/packages/fonts.scm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm >> index 1f6d1d0c3..088a6bec9 100644 >> --- a/gnu/packages/fonts.scm >> +++ b/gnu/packages/fonts.scm >> @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.") >> (string-append "PCFDEST=" pcf) >> (string-append "CONSOLEDEST=" psf) >> "install") >> + (system* "mkfontdir" pcf) > > This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of > font-gnu-unifont package. When multiple packages have this file, > collisions occour and then I guess it won't work as expected. I think so too. > The right > place to create this file is the 'fonts-dir-file' hook in profiles.scm, > currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts > under 'share/fonts/truetype', which can be extended for each directory > under 'share/fonts'. What do you think? I think that is better. I have thought about that before. But I didn't know whether that is necessary in general at that time. Best Regards, Huang, Ying