Re: [PATCH 01/26] gnu: Add perl-file-pushd.

[Alex Sassmannshausen <alex.sassmannshausen@gmail.com>]

Hi Kei,

Kei Kebreau writes:

> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:
>
>> * gnu/packages/perl.scm (perl-file-pushd): New variable
>> ---
>>  gnu/packages/perl.scm | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
>> index 086e1fae0..4944ceb2a 100644
>> --- a/gnu/packages/perl.scm
>> +++ b/gnu/packages/perl.scm
>> @@ -3002,6 +3002,34 @@ of arbitrary depth and to delete an entire directory subtree from the
>>  file system.")
>>      (license (package-license perl))))
>>  
>> +(define-public perl-file-pushd
>> +  (package
>> +    (name "perl-file-pushd")
>> +    (version "1.014")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/File-pushd-"
>> +             version
>> +             ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "02rlqvyy7gly3dsqwaa81aisyy9c791b8xvwzczcbgmcwgzkgaxm"))))
>> +    (build-system perl-build-system)
>> +    (home-page
>> +     "http://search.cpan.org/dist/File-pushd")
>> +    (synopsis
>> +     "Change directory temporarily for a limited scope")
>> +    (description "@code{File::pushd} does a temporary @code{chdir} that is
>> +easily and automatically reverted, similar to @code{pushd} in some Unix
>> +command shells.  It works by creating an object that caches the original
>> +working directory.  When the object is destroyed, the destructor calls
>> +@code{chdir} to revert to the original working directory.  By storing the
>> +object in a lexical variable with a limited scope, this happens automatically
>> +at the end of the scope.")
>> +    (license asl2.0)))
>> +
>>  (define-public perl-file-list
>>    (package
>>      (name "perl-file-list")
>
> This series of packages builds and lints fine for me. There are over 200
> dependent packages that would have to be rebuilt though, and
> core-updates is frozen to my knowledge. We can save this for the next
> core-updates cycle, though!
>
> Other Guix users, please correct me if I'm wrong.

Thanks for the review!

What command do you use to check the number of packages that would have
to be rebuilt?  I'm asking, because if they are mainly perl libraries
then that figure of 200 really isn't that big of a deal: most perl libs
build super fast.

Ta,

Alex