Hello! My name is Tatiana.

I have insta= lled guix=C2=A0for the first time and noticed that the installation script = at=C2=A0https://git.savannah.gnu.org/cgit/guix.git/tree/etc/guix-insta= ll.sh=C2=A0did not work for me. So, I had to make some modifications.

There was a problem with the path to root user home= directory. Below I provide diff output for original script and my modified= script.

= 266c266,267

<=C2=A0= =C2=A0 =C2=A0ln -sf /var/guix/profiles/per-user/root/guix-profile /root/.g= uix-profile

---=

>=C2=A0 =C2=A0 =C2=A0ln -= sf /var/guix/profiles/per-user/root/guix-profile \

>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ~root/.guix-pr= ofile

268c269

<=C2=A0 =C2=A0 =C2=A0GUIX_P= ROFILE=3D"/root/.guix-profile"

---

>=C2=A0 =C2=A0 =C2=A0GUIX_PROFILE=3D"${HOME}/.guix-profile"

These changes allowed me to install gu= ix=C2=A0via the script.

P. S.

I am reall= y a newcomer to the guix community. And still not sure how everything=C2=A0= works here. Sorry If my post's format is not appropriate.

Tatiana Sholokhova

--001a114db6c21ed806056824d404-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: Modification for guix installation script. Date: Sat, 24 Mar 2018 18:05:37 +0100 Message-ID: References:

Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:41615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezmkC-0000QT-Ba for guix-devel@gnu.org; Sat, 24 Mar 2018 13:15:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezmbq-0003bE-Kb for guix-devel@gnu.org; Sat, 24 Mar 2018 13:09:13 -0400 Received: from mail-qk0-x22f.google.com ([2607:f8b0:400d:c09::22f]:33417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezmbq-0003b8-G0 for guix-devel@gnu.org; Sat, 24 Mar 2018 13:05:38 -0400 Received: by mail-qk0-x22f.google.com with SMTP id d206so3766960qkb.0 for ; Sat, 24 Mar 2018 10:05:38 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tatiana Sholokhova Cc: guix-devel On Sat, Mar 24, 2018 at 6:00 PM, Tatiana Sholokhova wrote: > I just sent diff between my modified script and original script. (So, my > version of the script goes first in the diff output). I had to replace > ${HOME} and ~root with /root since there supposed to be the root user home > directory path. OK, so you have a reversed patch, so my remark was misplaced. What is the OS you're installing guix on ? -- Vincent Legoll From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tatiana Sholokhova Subject: Re: Modification for guix installation script. Date: Sat, 24 Mar 2018 20:00:58 +0300 Message-ID: References:

Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1139da281b7bc505682b7c4d" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezoAI-0008BK-Ls for guix-devel@gnu.org; Sat, 24 Mar 2018 14:48:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezneR-0002qr-3v for guix-devel@gnu.org; Sat, 24 Mar 2018 14:13:29 -0400 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:38525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezmXM-0001AZ-1y for guix-devel@gnu.org; Sat, 24 Mar 2018 13:01:00 -0400 Received: by mail-vk0-x22d.google.com with SMTP id b16so2472524vka.5 for ; Sat, 24 Mar 2018 10:00:59 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vincent Legoll Cc: guix-devel --001a1139da281b7bc505682b7c4d Content-Type: text/plain; charset="UTF-8" I just sent diff between my modified script and original script. (So, my version of the script goes first in the diff output). I had to replace ${HOME} and ~root with /root since there supposed to be the root user home directory path. 2018-03-24 19:46 GMT+03:00 Vincent Legoll : > Hello, > > > 266c266,267 > > < ln -sf /var/guix/profiles/per-user/root/guix-profile > > /root/.guix-profile > > --- > >> ln -sf /var/guix/profiles/per-user/root/guix-profile \ > >> ~root/.guix-profile > > 268c269 > > < GUIX_PROFILE="/root/.guix-profile" > > --- > >> GUIX_PROFILE="${HOME}/.guix-profile" > > > > These changes allowed me to install guix via the script. > > Why didn't you also use ${HOME} in the "ln" case ? (or "~/" in > the two cases...) > > -- > Vincent Legoll > --001a1139da281b7bc505682b7c4d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I just sent diff between my modified script and origi= nal script. (So, my version of the script=C2=A0goes first in the diff outpu= t). I had to replace=C2=A0${HOME} and=C2=A0~root with=C2=A0/root since there supposed to be the root user home directory pa= th.

2018= -03-24 19:46 GMT+03:00 Vincent Legoll <vincent.legoll@gmail.com= >:

Hello,

> 266c266,267
> <=C2=A0 =C2=A0 =C2=A0ln -sf /var/guix/profiles/per-user/root/g= uix-profile
> /root/.guix-profile
> ---
>>=C2=A0 =C2=A0 =C2=A0ln -sf /var/guix/profiles/per-user/root/gu= ix-profile \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ~root/.guix-profile
> 268c269
> <=C2=A0 =C2=A0 =C2=A0GUIX_PROFILE=3D"/root/.guix-profile&= quot;
> ---
>>=C2=A0 =C2=A0 =C2=A0GUIX_PROFILE=3D"${HOME}/.guix-profile= "
>
> These changes allowed me to install guix via the script.

Why didn't you also use ${HOME} in the "ln" case ? (or= "~/" in
the two cases...)

--
Vincent Legoll

--001a1139da281b7bc505682b7c4d-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: Modification for guix installation script. Date: Sat, 24 Mar 2018 17:46:23 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezp2E-0001ez-87 for guix-devel@gnu.org; Sat, 24 Mar 2018 15:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezons-0006Dh-VE for guix-devel@gnu.org; Sat, 24 Mar 2018 15:30:40 -0400 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:36975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezmJF-0000fN-4e for guix-devel@gnu.org; Sat, 24 Mar 2018 12:46:25 -0400 Received: by mail-qt0-x22c.google.com with SMTP id w12so8089815qti.4 for ; Sat, 24 Mar 2018 09:46:24 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tatiana Sholokhova Cc: guix-devel Hello, > 266c266,267 > < ln -sf /var/guix/profiles/per-user/root/guix-profile > /root/.guix-profile > --- >> ln -sf /var/guix/profiles/per-user/root/guix-profile \ >> ~root/.guix-profile > 268c269 > < GUIX_PROFILE="/root/.guix-profile" > --- >> GUIX_PROFILE="${HOME}/.guix-profile" > > These changes allowed me to install guix via the script. Why didn't you also use ${HOME} in the "ln" case ? (or "~/" in the two cases...) -- Vincent Legoll From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tatiana Sholokhova Subject: RE: Modification for guix installation script. Date: Sat, 24 Mar 2018 21:26:57 +0000 Message-ID: <5ab69878.4b9d2e0a.f7bd3.467b@mx.google.com> References:

Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_F4AC4520-E725-460C-869E-DB8B1B555E48_" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezpwH-0005yG-NH for guix-devel@gnu.org; Sat, 24 Mar 2018 16:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezpqK-0002RL-Cc for guix-devel@gnu.org; Sat, 24 Mar 2018 16:33:54 -0400 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:33270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eznsg-0002PF-Re for guix-devel@gnu.org; Sat, 24 Mar 2018 14:27:07 -0400 Received: by mail-lf0-x22f.google.com with SMTP id x205-v6so22707900lfa.0 for ; Sat, 24 Mar 2018 11:27:06 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vincent Legoll Cc: guix-devel --_F4AC4520-E725-460C-869E-DB8B1B555E48_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ubuntu 17.10 -- Tatiana Sholokhova =D0=9E=D1=82: Vincent Legoll =D0=9E=D1=82=D0=BF=D1=80=D0=B0=D0=B2=D0=BB=D0=B5=D0=BD=D0=BE: 24 =D0=BC=D0= =B0=D1=80=D1=82=D0=B0 2018 =D0=B3. =D0=B2 17:05 =D0=9A=D0=BE=D0=BC=D1=83: Tatiana Sholokhova =D0=9A=D0=BE=D0=BF=D0=B8=D1=8F: guix-devel =D0=A2=D0=B5=D0=BC=D0=B0: Re: Modification for guix installation script. On Sat, Mar 24, 2018 at 6:00 PM, Tatiana Sholokhova wrote: > I just sent diff between my modified script and original script. (So, my > version of the script goes first in the diff output). I had to replace > ${HOME} and ~root with /root since there supposed to be the root user hom= e > directory path. OK, so you have a reversed patch, so my remark was misplaced. What is the OS you're installing guix on ? --=20 Vincent Legoll --_F4AC4520-E725-460C-869E-DB8B1B555E48_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

Ubuntu 17.10

--=

Tatiana Sholokhova

=D0=9E=D1=82: <= /b>Vincent Legoll
=D0= =9E=D1=82=D0=BF=D1=80=D0=B0=D0=B2=D0=BB=D0=B5=D0=BD=D0=BE: 24 =D0=BC=D0= =B0=D1=80=D1=82=D0=B0 2018 =D0=B3. =D0=B2 17:05
=D0=9A=D0=BE=D0=BC=D1= =83: Tatiana Sholokhova=D0=9A=D0=BE=D0=BF=D0=B8=D1=8F: guix-devel
=D0=A2=D0=B5=D0=BC=D0=B0: Re: Modification for = guix installation script.

On Sat, Mar 24, 2018 at 6:00 PM, Tatiana Sholokhova<= /p>

<tanja201396@gmail.com> wrote:

> I just sent diff between my modified script and original scr= ipt. (So, my

> version of the script goes first = in the diff output). I had to replace

> ${HOME} = and ~root with /root since there supposed to be the root user home

> directory path.

OK, so you have a reversed patch, so my remark = was misplaced.

What is the OS you're installing guix on ?

Vincent= Legoll

= --_F4AC4520-E725-460C-869E-DB8B1B555E48_-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#30728: Modification for guix installation script. Date: Sun, 25 Mar 2018 17:26:34 +0200 Message-ID: <87muywi3bp.fsf@elephly.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tatiana Sholokhova Cc: guix-devel@gnu.org, 30728@debbugs.gnu.org List-Id: guix-devel.gnu.org Hi Tatiana, > I have installed guix for the first time and noticed that the installatio= n > script at > https://git.savannah.gnu.org/cgit/guix.git/tree/etc/guix-install.sh did n= ot > work for me. So, I had to make some modifications. > > There was a problem with the path to root user home directory. Below I > provide diff output for original script and my modified script. Thank you. Could you please make that change on top of the current version of the Guix sources as a git commit? Then you can run =E2=80=9Cgit format-patch -= 1=E2=80=9D to format it as a patch in a format that we can apply. You can send the resulting patch file as an attachment to a reply to this email. This also fixes bug #30728, so please add this line to the commit message: Fixes . -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: Modification for guix installation script. Date: Sun, 25 Mar 2018 14:57:53 -0400 Message-ID: <87vadk3rv2.fsf@netris.org> References: <87muywi3bp.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Aqy-0000vj-Ov for guix-devel@gnu.org; Sun, 25 Mar 2018 14:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Aqv-000089-Il for guix-devel@gnu.org; Sun, 25 Mar 2018 14:58:52 -0400 Received: from world.peace.net ([50.252.239.5]:33134) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0Aqv-000069-CH for guix-devel@gnu.org; Sun, 25 Mar 2018 14:58:49 -0400 In-Reply-To: <87muywi3bp.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 25 Mar 2018 17:26:34 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org, 30728@debbugs.gnu.org, Tatiana Sholokhova Ricardo Wurmus writes: >> I have installed guix for the first time and noticed that the installati= on >> script at >> https://git.savannah.gnu.org/cgit/guix.git/tree/etc/guix-install.sh did = not >> work for me. So, I had to make some modifications. >> >> There was a problem with the path to root user home directory. Below I >> provide diff output for original script and my modified script. > > Thank you. > > Could you please make that change on top of the current version of the > Guix sources as a git commit? Then you can run =E2=80=9Cgit format-patch= -1=E2=80=9D to > format it as a patch in a format that we can apply. You can send the > resulting patch file as an attachment to a reply to this email. > > This also fixes bug #30728, so please add this line to the commit > message: > > Fixes . Note that there's also another proposed patch for this same issue, here: https://bugs.gnu.org/30728#11 Regards, Mark From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: Modification for guix installation script. Date: Mon, 26 Mar 2018 10:27:57 +0200 Message-ID: <87d0zr9r76.fsf@lassieur.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0NU4-0006yu-Ot for guix-devel@gnu.org; Mon, 26 Mar 2018 04:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0NU1-0002IR-Kz for guix-devel@gnu.org; Mon, 26 Mar 2018 04:28:04 -0400 Received: from mail.lassieur.org ([83.152.10.219]:55656) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0NU1-0002HX-Al for guix-devel@gnu.org; Mon, 26 Mar 2018 04:28:01 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tatiana Sholokhova Cc: guix-devel@gnu.org, 30728@debbugs.gnu.org Hi Tatiana, Tatiana Sholokhova writes: > Hello! My name is Tatiana. > > I have installed guix for the first time and noticed that the installation > script at > https://git.savannah.gnu.org/cgit/guix.git/tree/etc/guix-install.sh did not > work for me. So, I had to make some modifications. > > There was a problem with the path to root user home directory. Below I > provide diff output for original script and my modified script. Thank you for working on this! > 266c266,267 > < ln -sf /var/guix/profiles/per-user/root/guix-profile > /root/.guix-profile > --- >> ln -sf /var/guix/profiles/per-user/root/guix-profile \ >> ~root/.guix-profile > 268c269 > < GUIX_PROFILE="/root/.guix-profile" > --- >> GUIX_PROFILE="${HOME}/.guix-profile" > > These changes allowed me to install guix via the script. As I said to Chris (Cc'ed), I don't think it's a good idea to install Guix in root's home directory. Instead, we should probably honor the USER and HOME environment variables, so that the command can be run as a non-root user (with sudo) in a consistent way. What do you think? You can follow the discussion there: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30728. Every email sent to 30728@debbugs.gnu.org will appear there. Clément From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#30728: Modification for guix installation script. Date: Mon, 26 Mar 2018 11:11:49 +0200 Message-ID: <87fu4ngq0a.fsf@elephly.net> References: <87d0zr9r76.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87d0zr9r76.fsf@lassieur.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: guix-devel@gnu.org, 30728@debbugs.gnu.org, Tatiana Sholokhova List-Id: guix-devel.gnu.org Hi Cl=C3=A9ment, > As I said to Chris (Cc'ed), I don't think it's a good idea to install > Guix in root's home directory. Instead, we should probably honor the > USER and HOME environment variables, so that the command can be run as a > non-root user (with sudo) in a consistent way. What do you think? The script should be run as root as it follows the manual=E2=80=99s instructions, which tell people to install Guix for the root user and then make it available system-wide. This is why I think that it would be correct to install it to the root=E2= =80=99s home directory and not to the sudoing user=E2=80=99s HOME. Or am I missing something? --=20 Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#30728: Modification for guix installation script. Date: Mon, 26 Mar 2018 14:59:30 +0200 Message-ID: <87bmfb9eml.fsf@lassieur.org> References: <87d0zr9r76.fsf@lassieur.org> <87fu4ngq0a.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Rir-0001Zs-BW for guix-devel@gnu.org; Mon, 26 Mar 2018 08:59:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Rin-0008Ef-EC for guix-devel@gnu.org; Mon, 26 Mar 2018 08:59:37 -0400 Received: from mail.lassieur.org ([83.152.10.219]:55678) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0Rin-0008DT-5U for guix-devel@gnu.org; Mon, 26 Mar 2018 08:59:33 -0400 In-reply-to: <87fu4ngq0a.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus , Marius Bakke Cc: guix-devel@gnu.org, 30728@debbugs.gnu.org, Tatiana Sholokhova Hi Ricardo and Marius, Marius Bakke writes: > The binary installation tarball only comes with a profile for 'root'. Indeed, but it's easy to copy it for any user isn't it? > The problem is that the installation script assumes $HOME will expand to > ~root when sourcing the profile, but as you found that isn't always the > case. > > ~root/.guix-profile is "hard-coded" many other places in the script, so > Tatianas solution seems sensible to me. Ricardo Wurmus writes: > Hi Clément, > >> As I said to Chris (Cc'ed), I don't think it's a good idea to install >> Guix in root's home directory. Instead, we should probably honor the >> USER and HOME environment variables, so that the command can be run as a >> non-root user (with sudo) in a consistent way. What do you think? > > The script should be run as root as it follows the manual’s > instructions, which tell people to install Guix for the root user and > then make it available system-wide. > > This is why I think that it would be correct to install it to the root’s > home directory and not to the sudoing user’s HOME. > > Or am I missing something? Thank you both for your comments. :-) What I dislike with the present state of things is the need for Guix to be installed within root's directory. For two reasons : 1. I don't think a command should ever install something in another user's home directory. The home directory of a user is for things that are specific to that user, I believe. 2. Users need to update the root profile if they want to update the Guix daemon, which is cumbersome. The systemd configuration file must know where to find the Guix daemon. If it's not in ~root, it must be in the user's home directory. Either way, the Guix daemon, which is system-wide, still depends on a user. (A way to make the daemon user-independant would be to add a new command that would update, say, /var/guix/guix-daemon, with the systemd configuration file pointing to it.) I personally prefer that the Guix daemon points to my home directory because I don't want to update root's profile. Some other people might prefer that it points to ~root because they might later delete their profile and want Guix to keep working. Do we have to take a decision here? Can't we just let the user decide by letting them customize their environment variables? I think it is the point of environment variables: giving freedom to users. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tatiana Sholokhova Subject: Re: bug#30728: Modification for guix installation script. Date: Mon, 26 Mar 2018 19:09:38 +0300 Message-ID: References: <87d0zr9r76.fsf@lassieur.org> <87fu4ngq0a.fsf@elephly.net> <87bmfb9eml.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1139da28425594056853005a" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Ugn-0007us-QO for guix-devel@gnu.org; Mon, 26 Mar 2018 12:09:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Ugm-0004CL-JC for guix-devel@gnu.org; Mon, 26 Mar 2018 12:09:41 -0400 Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:35990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0Ugm-0004Bz-8l for guix-devel@gnu.org; Mon, 26 Mar 2018 12:09:40 -0400 Received: by mail-vk0-x22f.google.com with SMTP id q198so4802909vke.3 for ; Mon, 26 Mar 2018 09:09:40 -0700 (PDT) In-Reply-To: <87bmfb9eml.fsf@lassieur.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Cl=C3=A9ment_Lassieur?= Cc: guix-devel , 30728@debbugs.gnu.org --001a1139da28425594056853005a Content-Type: multipart/alternative; boundary="001a1139da2842558f0568530058" --001a1139da2842558f0568530058 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! Could you please make that change on top of the current version of the > Guix sources as a git commit? Then you can run =E2=80=9Cgit format-patch= -1=E2=80=9D to > format it as a patch in a format that we can apply. You can send the > resulting patch file as an attachment to a reply to this email. > This also fixes bug #30728, so please add this line to the commit > message: > -- > Ricardo I have attached the patch file to this email. This patch fixes the installation process but it place guix within root's directory. I personally prefer that the Guix daemon points to my home directory > because I don't want to update root's profile. Some other people might > prefer that it points to ~root because they might later delete their > profile and want Guix to keep working. > Do we have to take a decision here? Can't we just let the user decide > by letting them customize their environment variables? I think it is > the point of environment variables: giving freedom to users. We can further work on the script's flexibility using the environment variable solution. -- Tatiana --001a1139da2842558f0568530058 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello!

Cou= ld you please make that change on top of the current version of the
Guix sources as a git commit?=C2=A0 Then you c= an run =E2=80=9Cgit format-patch -1=E2=80=9D to
format it as a patch in a format that we can apply.=C2=A0 You can = send the
resulting patch file as an att= achment to a reply to this email.
This also f= ixes bug #30728, so please add this line to the commit
message:
--
<= span style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:sm= all;font-style:normal;font-variant-ligatures:normal;font-variant-caps:norma= l;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;te= xt-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(= 255,255,255);text-decoration-style:initial;text-decoration-color:initial;fl= oat:none;display:inline">Ricardo

I h= ave attached the patch file to this email. This patch fixes the installatio= n process but it place=C2=A0guix=C2=A0within roo= t's directory.=C2=A0

I personally prefer that the Guix daemon points to my ho= me directory
because I don't want = to update root's profile.=C2=A0 Some other people might
prefer that it points to ~root because they might lat= er delete their
profile and want Guix = to keep working.=C2=A0

Do we have to take a decision he= re?=C2=A0 Can't we just let the user decide
by letting them customize their environment variables?=C2=A0 I th= ink it is
the point of environment var= iables: giving freedom to users.
<= /div>
We = can further work on the script's flexibility using the environment vari= able solution.

--
Tatiana
--001a1139da2842558f0568530058-- --001a1139da28425594056853005a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fixes-https-debbugs.gnu.org-30728.patch" Content-Disposition: attachment; filename="0001-Fixes-https-debbugs.gnu.org-30728.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jf8f8euu0 RnJvbSBmMjg2YjZlOWM2MGNiYTU0ZjNkYTY4NDI4ZmMwMzRkMjcyYmE1ZmZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiB0c2hvbG9raG92YSA8dGFuamEyMDEzOTZAZ21haWwuY29tPgpE YXRlOiBNb24sIDI2IE1hciAyMDE4IDE4OjU5OjQwICswMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZXMgPGh0dHBzOi8vZGViYnVncy5nbnUub3JnLzMwNzI4PgoKLS0tCiBldGMvZ3VpeC1pbnN0YWxs LnNoIHwgNSArKy0tLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvZ3VpeC1pbnN0YWxsLnNoIGIvZXRjL2d1aXgtaW5zdGFs bC5zaAppbmRleCA5MzM0OTJhMzMuLmI0YTljZGY5NCAxMDA3NTUKLS0tIGEvZXRjL2d1aXgtaW5z dGFsbC5zaAorKysgYi9ldGMvZ3VpeC1pbnN0YWxsLnNoCkBAIC0yNjMsMTAgKzI2Myw5IEBAIHN5 c19jcmVhdGVfc3RvcmUoKQogICAgIGZpCiAKICAgICBfbXNnICIke0lORn1MaW5raW5nIHRoZSBy b290IHVzZXIncyBwcm9maWxlIgotICAgIGxuIC1zZiAvdmFyL2d1aXgvcHJvZmlsZXMvcGVyLXVz ZXIvcm9vdC9ndWl4LXByb2ZpbGUgXAotICAgICAgIH5yb290Ly5ndWl4LXByb2ZpbGUKKyAgICBs biAtc2YgL3Zhci9ndWl4L3Byb2ZpbGVzL3Blci11c2VyL3Jvb3QvZ3VpeC1wcm9maWxlIC9yb290 Ly5ndWl4LXByb2ZpbGUKIAotICAgIEdVSVhfUFJPRklMRT0iJHtIT01FfS8uZ3VpeC1wcm9maWxl IgorICAgIEdVSVhfUFJPRklMRT0iL3Jvb3QvLmd1aXgtcHJvZmlsZSIKICAgICBzb3VyY2UgIiR7 R1VJWF9QUk9GSUxFfS9ldGMvcHJvZmlsZSIKICAgICBfbXNnICIke1BBU31hY3RpdmF0ZWQgcm9v dCBwcm9maWxlIGF0IC9yb290Ly5ndWl4LXByb2ZpbGUiCiB9Ci0tIAoyLjE0LjEKCg== --001a1139da28425594056853005a-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Modification for guix installation script. Date: Tue, 27 Mar 2018 13:53:32 +0200 Message-ID: References: <87d0zr9r76.fsf@lassieur.org> <87fu4ngq0a.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113eb35c36a2560568638a6d" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0nAW-00073I-1g for guix-devel@gnu.org; Tue, 27 Mar 2018 07:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0nAU-0002E4-RY for guix-devel@gnu.org; Tue, 27 Mar 2018 07:53:36 -0400 Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]:44773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0nAU-0002DT-LT for guix-devel@gnu.org; Tue, 27 Mar 2018 07:53:34 -0400 Received: by mail-io0-x234.google.com with SMTP id d7so11864260ioc.11 for ; Tue, 27 Mar 2018 04:53:34 -0700 (PDT) In-Reply-To: <87fu4ngq0a.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Guix-devel , 30728@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment_Lassieur?= , Tatiana Sholokhova --001a113eb35c36a2560568638a6d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-03-26 11:11 GMT+02:00 Ricardo Wurmus : > > Hi Cl=C3=A9ment, > > > As I said to Chris (Cc'ed), I don't think it's a good idea to install > > Guix in root's home directory. Instead, we should probably honor the > > USER and HOME environment variables, so that the command can be run as = a > > non-root user (with sudo) in a consistent way. What do you think? > > The script should be run as root as it follows the manual=E2=80=99s > instructions, which tell people to install Guix for the root user and > then make it available system-wide. > > This is why I think that it would be correct to install it to the root=E2= =80=99s > home directory and not to the sudoing user=E2=80=99s HOME. > > Or am I missing something? > > I think Ricardo is right on this one. I would also recommend installing in root's home directory. Ibelieve, that installing in a user home would make sense only with a big amount of additional instrumentation and documentation changes, along with arrangements to allow guix in userspace. This is a straightforward way to make the script do what it's purpose is. > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > > --001a113eb35c36a2560568638a6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -03-26 11:11 GMT+02:00 Ricardo Wurmus <rekado@elephly.net>:=

Hi Cl=C3=A9ment,

> As I said to Chris (Cc'ed), I don't think it's a good idea= to install
> Guix in root's home directory.=C2=A0 Instead, we should probably h= onor the
> USER and HOME environment variables, so that the command can be run as= a
> non-root user (with sudo) in a consistent way.=C2=A0 What do you think= ?

The script should be run as root as it follows the manual=E2=80=99s<= br> instructions, which tell people to install Guix for the root user and
then make it available system-wide.

This is why I think that it would be correct to install it to the root=E2= =80=99s
home directory and not to the sudoing user=E2=80=99s HOME.

Or am I missing something?

<= br>
I think Ricardo is right on this one. I would also recommend = installing in
root's home directory. Ibelieve, that installin= g in a user home would make
sense only with a big amount of addit= ional instrumentation and
documentation changes, along with arran= gements to allow guix in
userspace. This is a straightforward way= to make the script do what it's
purpose is.
=C2=A0=
--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net

--001a113eb35c36a2560568638a6d-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: Modification for guix installation script. Date: Thu, 29 Mar 2018 10:11:35 +0200 Message-ID: <87bmf7wbbc.fsf@lassieur.org> References: <87d0zr9r76.fsf@lassieur.org> <87fu4ngq0a.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1Ses-00024t-99 for guix-devel@gnu.org; Thu, 29 Mar 2018 04:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1Sep-0000b9-1f for guix-devel@gnu.org; Thu, 29 Mar 2018 04:11:42 -0400 Received: from mail.lassieur.org ([83.152.10.219]:56168) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f1Seo-0000ZO-Nj for guix-devel@gnu.org; Thu, 29 Mar 2018 04:11:38 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?G=C3=A1bor?= Boskovits Cc: Guix-devel , 30728@debbugs.gnu.org, Tatiana Sholokhova Gábor Boskovits writes: > 2018-03-26 11:11 GMT+02:00 Ricardo Wurmus : > >> >> Hi Clément, >> >> > As I said to Chris (Cc'ed), I don't think it's a good idea to install >> > Guix in root's home directory. Instead, we should probably honor the >> > USER and HOME environment variables, so that the command can be run as a >> > non-root user (with sudo) in a consistent way. What do you think? >> >> The script should be run as root as it follows the manual’s >> instructions, which tell people to install Guix for the root user and >> then make it available system-wide. >> >> This is why I think that it would be correct to install it to the root’s >> home directory and not to the sudoing user’s HOME. >> >> Or am I missing something? >> >> > I think Ricardo is right on this one. I would also recommend installing in > root's home directory. But you don't explain why. And "as it follows the manual's instructions" isn't a good reason to me. > I believe, that installing in a user home would make sense only with a > big amount of additional instrumentation and documentation changes, > along with arrangements to allow guix in userspace. I think it would be fairly easy. The kind of edit we do all the time when patches are being reviewed. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Subject: bug#30728: Modification for guix installation script. Date: Thu, 29 Mar 2018 10:24:57 +0200 Message-ID: <87a7urwap2.fsf@lassieur.org> References: <87d0zr9r76.fsf@lassieur.org> <87fu4ngq0a.fsf@elephly.net> <87bmfb9eml.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tatiana Sholokhova Cc: guix-devel , 30728@debbugs.gnu.org List-Id: guix-devel.gnu.org Hi Tatiana, Tatiana Sholokhova writes: > Hello! > > > Could you please make that change on top of the current version of the > Guix sources as a git commit? Then you can run “git format-patch -1” to > format it as a patch in a format that we can apply. You can send the > resulting patch file as an attachment to a reply to this email. > This also fixes bug #30728, so please add this line to the commit > message: > -- > Ricardo > > > I have attached the patch file to this email. This patch fixes the installation > process but it placeguixwithin root's directory. > > > I personally prefer that the Guix daemon points to my home directory > because I don't want to update root's profile. Some other people might > prefer that it points to ~root because they might later delete their > profile and want Guix to keep working. > > > Do we have to take a decision here? Can't we just let the user decide > by letting them customize their environment variables? I think it is > the point of environment variables: giving freedom to users. > > > We can further work on the script's flexibility using the environment variable > solution. Thank you for your patch. The one Chris did has been pushed, but if you want, you can still work on improving the script's flexibility. I still haven't seen any valid argument for or against it, though, so I don't know if it's a good idea. Maybe we can wait until someone says something about it! Clément