From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: Add rclone.
Date: Wed, 28 Nov 2018 12:23:26 +0100 [thread overview]
Message-ID: <87bm69saxd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87sgzl92yf.fsf@netris.org> (Mark H. Weaver's message of "Wed, 28 Nov 2018 00:37:49 -0500")
Hello,
Mark H Weaver <mhw@netris.org> writes:
> Did you test this?
Yes, of course I tested it. I was using it for my own needs before
sending the patch for review. I obviously fumbled somehow when I sent
the mail, but I still do not get when or why.
> There's a syntax error in the code, such that it not only fails to
> build, but it fails even to produce a _derivation_ describing the build.
> Unfortunately, this kind of error in any package causes problems for our
> build farm, which currently assumes that this kind of error will not
> occur. Such errors not only cause the individual build to fail, but
> moreover for the entire process that generates a new CI "evaluation" to
> fail, which effectively prevents subsequent package updates on that
> branch from being built until the problem is corrected.
I suggest to add a check, if possible, for that kind of mistake — e.g.,
check if `arguments' value is a valid property list — because forgetting
a line in a leaf package should not cause the whole build farm to die.
> I reverted this commit.
OK. I'll fix the commit.
> Please be careful when pushing to master.
I sincerely hope you're not suggesting I'm not careful when I send
a patch or push it to master. You must know carefulness is not strictly
equivalent to perfectness. Not quite.
Thank you for fixing my mistake.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-11-28 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181127204001.24071.37439@vcs0.savannah.gnu.org>
[not found] ` <20181127204002.3CA6B209DD@vcs0.savannah.gnu.org>
2018-11-28 5:37 ` 01/01: gnu: Add rclone Mark H Weaver
2018-11-28 11:23 ` Nicolas Goaziou [this message]
2018-11-28 14:50 ` Ludovic Courtès
2018-12-12 2:33 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm69saxd.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).