From: iyzsong@member.fsf.org (宋文武)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, 34407@debbugs.gnu.org
Subject: Re: [PATCH] shepherd: Delete the socket file upon exit.
Date: Sat, 23 Feb 2019 16:53:00 +0800 [thread overview]
Message-ID: <87bm32998z.fsf@member.fsf.org> (raw)
In-Reply-To: <20190219200900.12407d94@scratchpost.org> (Danny Milosavljevic's message of "Tue, 19 Feb 2019 20:08:59 +0100")
Danny Milosavljevic <dannym@scratchpost.org> writes:
> On Sun, 17 Feb 2019 11:38:16 +0800
> iyzsong@member.fsf.org (宋文武) wrote:
>
>> Yes, I have the 'rm /run/user/1000/shepherd/socket' workaround in my session
>> script too...
>>
>> According to 'man 2 bind', the socket pathname should be deleted when no
>> longer required, so a patch to fix this bug:
>
> Hmm, I guess you can do that.
>
> But /run is supposed to be a tmpfs and elogind is supposed to rm -rf /run/user/1000
> after all sessions of that user terminated in any case, so how is it left over
> in the first place?
>
Well, maybe the elogind version I used didn't have this feature, or I
had another user session running...
> If the deletion in the case above doesn't work, please report a bug.
Thanks, good to know, and it indeed works.
>
> If that patch is only in order to enable users to restart user's shepherd
> without exiting all their sessions, then I guess that's ok--although unusual.
>
> Does your patch do the right thing if the user's shepherd is already
> running? (i.e. keep the socket file)
Yes, it deletes the socket file at exit (not at startup).
next prev parent reply other threads:[~2019-02-23 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87k1i868hk.fsf@disroot.org>
2019-02-17 3:38 ` [PATCH] shepherd: Delete the socket file upon exit 宋文武
2019-02-19 19:08 ` Danny Milosavljevic
2019-02-23 8:53 ` 宋文武 [this message]
2019-04-08 8:58 ` bug#34407: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm32998z.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=34407@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).