From: Pierre Neidhardt <mail@ambrevar.xyz>
To: zimoun <zimon.toutoune@gmail.com>,
Danny Milosavljevic <dannym@scratchpost.org>
Cc: "Guix Devel" <guix-devel@gnu.org>,
"Clément Lassieur" <clement@lassieur.org>
Subject: Re: Command line option in addition to GUIX_PACKAGE_PATH - Reason?
Date: Thu, 16 Jan 2020 15:30:23 +0100 [thread overview]
Message-ID: <87blr3eao0.fsf@ambrevar.xyz> (raw)
In-Reply-To: <CAJ3okZ2HSh_WbiWEz65-A_LZLgN91Dc-rAQe_7PbA09YQid64Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
I've merged your patch 38678.
Only one nit with guix refresh:
--8<---------------cut here---------------start------------->8---
+ ;; The short option -L is already used by --list-updaters, therefore
+ ;; it needs to be removed from %standard-build-options.
+ (let ((%load-path-option (find (lambda (option)
+ (member "load-path"
+ (option-names option)))
+ %standard-build-options)))
+ (option
+ (filter (lambda (name) (not (equal? #\L name)))
+ (option-names %load-path-option))
+ (option-required-arg? %load-path-option)
+ (option-optional-arg? %load-path-option)
+ (option-processor %load-path-option)))
+
--8<---------------cut here---------------end--------------->8---
I would name the let-bound variable without a percent sign '%' by
convention.
Should I fix this for you?
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-01-16 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 11:28 Document GUIX_LOAD_PATH? Pierre Neidhardt
2019-12-18 13:17 ` zimoun
2019-12-19 10:45 ` Clément Lassieur
2019-12-19 10:59 ` Pierre Neidhardt
2019-12-19 16:57 ` Ludovic Courtès
2019-12-19 17:04 ` Pierre Neidhardt
2019-12-19 17:09 ` zimoun
2019-12-19 17:14 ` Pierre Neidhardt
2019-12-26 20:31 ` Command line option in addition to GUIX_PACKAGE_PATH - Reason? Danny Milosavljevic
2019-12-28 9:56 ` Pierre Neidhardt
2019-12-30 18:29 ` zimoun
2020-01-16 14:30 ` Pierre Neidhardt [this message]
2020-01-16 16:12 ` zimoun
2020-01-17 15:56 ` Pierre Neidhardt
2019-12-19 21:13 ` Document GUIX_LOAD_PATH? zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blr3eao0.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=clement@lassieur.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).