From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH 1/6] gnu: cgit: Make some inputs native. Date: Wed, 01 Apr 2020 01:07:55 +0200 Message-ID: <87blocjf78.fsf@nckx> References: <20200331220439.3828-1-vincent.legoll@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJPzG-0001t2-DS for guix-devel@gnu.org; Tue, 31 Mar 2020 19:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJPzF-0006Mn-1F for guix-devel@gnu.org; Tue, 31 Mar 2020 19:08:02 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:45648) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJPzE-0006G3-FO for guix-devel@gnu.org; Tue, 31 Mar 2020 19:08:00 -0400 In-reply-to: <20200331220439.3828-1-vincent.legoll@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Vincent Legoll Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vincent, Thank you! This list is for general Guix discussion. Although that can=20 sometimes include rough patches (heh), please send any future=20 contributions to our patch tracker at guix-patches@gnu.org =E2=80=94 after= =20 carefully reading the =E2=80=98Submitting Patches=E2=80=99 section of the G= uix=20 manual. Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/version-control.scm (cgit)[native-inputs]: New=20 > field. This is no new field. Neither are those of mailutils, iwd, or=20 graphviz! Please rewrite all commit messages as either * gnu/packages/version-control.scm (cgit)[inputs]: Move groff & python-docutils from here=E2=80=A6 [native-inputs]: =E2=80=A6to this new field. or * gnu/packages/version-control.scm (cgit)[inputs]: Move groff & python-docutils from here=E2=80=A6 [native-inputs]: =E2=80=A6to here. although to be honest, I only ever use the latter format unless=20 I'm feeling particularly pedantic. > [inputs]: Move groff & python-docutils to native-inputs. If we run $ guix gc --references `guix build cgit` we can see that both groff and python-docutils are part of cgit's=20 closure. This means they must to be able to run=E2=80=A6 at run time :-o=20 Oh dear. python-docutils's =E2=80=98rst2html.py=E2=80=99 is required by cgit's=20 /lib/cgit/filters/html-converters/rst2html, and groff itself by=20 cgit's /lib/cgit/filters/html-converters/man2html. Both of these=20 uses look legitimate to me: they weren't accidentally captured by=20 a stray environment variable or overzealous wrapper. Now, it's still possible that either or both of these dependents=20 must *also* run at build time, and for that they would need to be=20 native indeed. Unfortunately: $ guix build cgit --target=3Dmips64el-linux-gnu guix build: error: gnu/packages/python-xyz.scm:2950:2: python-docutils@0.16: build system `python' does not support=20 cross builds I could ignore that and pretend that all Python packages are=20 safely architecture-independent (they're not) to continue=20 investigating, but I'm out of time. I don't think this particular patch adds any value at this time,=20 so let's drop it. The rest LGTM! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6DzUsACgkQ2Imw8BjF STy0TxAAqV8aZhrKgcN44Ad9f4Ga7lT+gItkgdCX0yoByUVNjb6uRzgXWcx4IS1j F418sSMcowBpho5h3swXeXzyJhaVrQJ44CqXDvQTNxad0fC0aVZiklQKFoddl01S ib79raJMPDpfLi4rV7lY6U8xOb06oGwyJMahGu85boA82DisF4ufgvfEjE8lHuMJ jfVfcpX3Q/n/b5b2Lg8LWSs94+wL5oaqScHOm7PulG4qu7H9VfA56StXHsGktI/a BKWtiER6GS6F/nVP1uqE4GV2NdQ14VgXNy/xxAjYM0TCb4CLjIrBiIRVWxbnmNUL CO0Qrl5vz+H/DC7vVGSsZVfQ4Wuj4y9cJpRYscr52YkVE0Tnlr1b0DFMgfuMGg1s aVpY5I5eDV9VGaO7N50p4jbWqw6I3ejwqka8tUf+A8F0CTkfmaeV0RgIqTcyrwUA elYjmUZKIKkoxu7SATp7TUYKxOrozursN5SyK8HWcadgLM5Fl1vE0miygg8U8UH9 NkFxOmRfdBaipU1wT3heqYT419vwzWfJ5AlwP8qFLvSYRYrK2vQdAsWI1P43xRhJ noRKdCUS22IwtmrXN1+JRU7wVpD6h4oSlwvJ4d+V79INK7m7XQ0jEtzJUq248Kdp JV+i5JD64cqloWg/msJa7hYMjMkF75J0n/9CqymfrQikWX6SUOg= =uI48 -----END PGP SIGNATURE----- --=-=-=--