From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GPw/H+Qqr16bHQAA0tVLHw (envelope-from ) for ; Sun, 03 May 2020 20:34:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yAQwHO4qr15JEAAA1q6Kng (envelope-from ) for ; Sun, 03 May 2020 20:34:54 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 532B7941FC6 for ; Sun, 3 May 2020 20:34:53 +0000 (UTC) Received: from localhost ([::1]:34300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVLK9-0002jx-NP for larch@yhetil.org; Sun, 03 May 2020 16:34:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVLJw-0002jp-7D for guix-devel@gnu.org; Sun, 03 May 2020 16:34:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59766) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVLJv-0006Ka-Lz; Sun, 03 May 2020 16:34:39 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49856 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jVLJv-0003vF-88; Sun, 03 May 2020 16:34:39 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jan Nieuwenhuizen Subject: Re: 05/36: vm: Make the device node procedure a parameter. References: <20200427101927.7020.76060@vcs0.savannah.gnu.org> <20200427101943.A4BDD20A5E@vcs0.savannah.gnu.org> <87y2qcmymt.fsf@gnu.org> <87368kur22.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 =?utf-8?Q?Flor=C3=A9al?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 03 May 2020 22:34:38 +0200 In-Reply-To: <87368kur22.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Fri, 01 May 2020 08:07:01 +0200") Message-ID: <87bln4wye9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49398685119265]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.14), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: tQNsC0lCFUPp Hi! Jan Nieuwenhuizen skribis: > We may even want to move this (and "friends") into the qemu-image > declaration itself; in a much later patch on wip-hurd-vm I have > > (define* qemu-image #:key > [...] > - (file-system-type "ext4") > - (file-system-options '()) > - (device-nodes 'linux) > + (file-system-type (if (hurd-target?) "ext2" "ext4")) > + (file-system-options > + (if (hurd-target?) '("-o" "hurd") '())) > + (device-nodes (if (hurd-target?) 'hurd 'linux)) > > Having linux-specific defaults in a generic function is kind of awkward; > we would need to change all callers, or ... Ah yes, we should do something like that. Ludo=E2=80=99.