From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KHNcJuITyF8QGwAA0tVLHw (envelope-from ) for ; Wed, 02 Dec 2020 22:23:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gM0rIuITyF8JEAAAB5/wlQ (envelope-from ) for ; Wed, 02 Dec 2020 22:23:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 417E59402DD for ; Wed, 2 Dec 2020 22:23:30 +0000 (UTC) Received: from localhost ([::1]:34096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkaX1-00019b-Ur for larch@yhetil.org; Wed, 02 Dec 2020 17:23:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkaWX-00017n-AA for guix-devel@gnu.org; Wed, 02 Dec 2020 17:22:57 -0500 Received: from world.peace.net ([64.112.178.59]:58822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkaWV-0005b1-Kg for guix-devel@gnu.org; Wed, 02 Dec 2020 17:22:56 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkaWT-0001ML-NE; Wed, 02 Dec 2020 17:22:53 -0500 From: Mark H Weaver To: Ryan Prior , Raghav Gururajan , Danny Milosavljevic Subject: Re: Questionable "cosmetic changes" commits In-Reply-To: References: Date: Wed, 02 Dec 2020 17:22:02 -0500 Message-ID: <87blfbg862.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Development of GNU Guix and the GNU System distribution Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.28 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 417E59402DD X-Spam-Score: -2.28 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: NZk8fxriFdvv Hi Ryan, Ryan Prior writes: > I do think it's important to acknowledge that the commits written by > Raghav were part of his internship and advised by his mentors who signed > off on the commits, so it's not like these changes were unsolicited and > materialized out of nowhere. If those cosmetic changes were solicited by his mentors, then please consider my comments to be directed at them. Incidentally, my comments were not meant to shame anyone. I very much appreciate Raghav's contributions to Guix. I'm merely pointing out a practice that I think is suboptimal and should be discouraged. Thanks, Mark