From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iMfCLsaOT2CPRgAA0tVLHw (envelope-from ) for ; Mon, 15 Mar 2021 16:43:50 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sPKvKsaOT2DYCAAA1q6Kng (envelope-from ) for ; Mon, 15 Mar 2021 16:43:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 6B2C920F3F for ; Mon, 15 Mar 2021 17:43:50 +0100 (CET) Received: from localhost ([::1]:58232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLqJp-0002GF-GU for larch@yhetil.org; Mon, 15 Mar 2021 12:43:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLqCN-0005vi-Op for guix-devel@gnu.org; Mon, 15 Mar 2021 12:36:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45910) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLqCM-0000WP-Kw; Mon, 15 Mar 2021 12:36:06 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46296 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lLqCL-0007nv-WF; Mon, 15 Mar 2021 12:36:06 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Chris Marusich Subject: Re: Release on April 18th? References: <87im6042fr.fsf@gmail.com> <875z1y3vj0.fsf@gmail.com> <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> <87h7lgzs8h.fsf@gmail.com> <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> <87h7lgzs8h.fsf@gmail.com> <87czw4z01x.fsf_-_@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?utf-8?Q?Vent=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 15 Mar 2021 17:36:03 +0100 In-Reply-To: <87czw4z01x.fsf_-_@gmail.com> (Chris Marusich's message of "Fri, 12 Mar 2021 10:42:02 -0800") Message-ID: <87blbkfk7g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615826630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=r4Lbg1UygGwEMXDoPqegEzl3ZG/1xwRfEk8mFD2MInk=; b=HCnHCXQs3Yt/tlpQ7ys/U5sx3ShnaEBEy1GfR8FTXGL4appPTo5a3qCtcjgGCgOW16vfvD j43IlD8a3GokoASsqxeTFaJFrGiEqgnvFtwFbFEeGEVzi9q3rmMpDaKeQV+iRx6qPKArWO jc0PN++Ba3siPGv6gXEj7mqx65TZHZIrn34IXw3VErkoAa4XPXpKO2qdEKKD2XLST3B43x Nh9kQOZEk7nXD2XFT97jqlR8dqQbnqwWFFknt33EQ1pOnU5G32sr3WeVqEubfRNBjZr08X WlJ9X5/OpagOon5pMHPW0CYb0PCERgwiIqpxisbyDr7i7Mr0z6zSXF2jVIxMaQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615826630; a=rsa-sha256; cv=none; b=l+5kavKR1Kp9myYeP5WRcbF2J00xNjFtj7DAeRDHYDYIkMTl1k/goHK7IocO2mQlTTBNSL f0TOn36Mfi5o3v0q/LJ8/kzBV6/IJbJbs5GfQFhdBTmTwzGoz2V2HFcwjgkapjMcEd5RZc xL0+8FjCvEq0HO/I1/lbZdAFvvU8XiQ53rsIVNZMIyxqvm3iVRB2oqTcx6C5LK2W4e5J2Y PrBKY2y4JnscrXgVJlI5Hyg22osUqdaPRMX3owezRv1ooA/P8n6e7C5K41vH0vqyB2u4yz wTz2xNO2GQQ8MB5lbDaJzHa2XPrFNdbGhvjzPBlbPdK6D/yHYPBGBxVaMB8EgA== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.90 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6B2C920F3F X-Spam-Score: -1.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7lNxG2z2tBmF Hi Chris, Chris Marusich skribis: > From 5417f68ee5892f6a587895105854cadf29eb7297 Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Thu, 11 Mar 2021 23:19:30 -0800 > Subject: [PATCH] syscalls: mount: Fix a matching bug. > > On some systems, the columns in /proc/self/mountinfo look like this: > > 23 28 0:21 / /proc rw,nosuid,nodev,noexec,relatime shared:11 - proc proc = rw > > Before this change, the mount procedure was written with the assumption t= hat > the type and source could always be found in columns 8 and 9, respectivel= y. > However, the proc(5) man page explains that there can be zero or more opt= ional > fields starting at column 7 (e.g., "shared:11" above), so this assumption= is > false in some situations. > > * guix/build/syscalls.scm (mount): Update the match pattern to use ellips= is to > match zero or more optional fields followed by a single hyphen. Remove t= he > trailing ellipsis, since multiple ellipses are not allowed in the same le= vel. > The proc(5) man page indicates that there are no additional columns, so i= t is > probably OK to match an exact number of columns at the end like this. > --- > guix/build/syscalls.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm > index 552343a481d..726c8e86d06 100644 > --- a/guix/build/syscalls.scm > +++ b/guix/build/syscalls.scm > @@ -621,8 +621,9 @@ current process." > (if (eof-object? line) > (reverse result) > (match (string-tokenize line) > + ;; See the proc(5) man page for a description of the col= umns. > ((id parent-id major:minor root mount-point > - options _ type source _ ...) > + options _ ... "-" type source _) > (let ((devno (string->device-number major:minor))) > (loop (cons (%mount (octal-decode source) > (octal-decode mount-point) It works on my laptop. :-) If you=E2=80=99re confident, please push=E2=80= =94thanks for the fix! (Next time please report the issue to bug-guix where it=E2=80=99s more like= ly to be seen and dealt with. :-)) Ludo=E2=80=99.