From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CCuAC6QrgWDHoAAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 09:54:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uAcqB6QrgWBHagAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 07:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FD4797D9 for ; Thu, 22 Apr 2021 09:54:11 +0200 (CEST) Received: from localhost ([::1]:59726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZUA5-0003ve-T9 for larch@yhetil.org; Thu, 22 Apr 2021 03:54:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZU9Z-0003uc-UZ for guix-devel@gnu.org; Thu, 22 Apr 2021 03:53:38 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZU9W-0001jG-5m for guix-devel@gnu.org; Thu, 22 Apr 2021 03:53:36 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id DC87C27BC7B; Thu, 22 Apr 2021 08:53:32 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1863060e; Thu, 22 Apr 2021 07:53:32 +0000 (UTC) References: <20210421152914.461bbdbb@lubrito> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines To: Luciana Lima Brito Subject: Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons. In-reply-to: <20210421152914.461bbdbb@lubrito> Date: Thu, 22 Apr 2021 08:53:29 +0100 Message-ID: <87bla6iwli.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619078051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=NCQlEC2g/Of6a8q02FOAt6P5qTwTGC7S5jXyaWc1lc4=; b=iEW/qaCZJS9lJ2fO5cPOiNg76OZ9OverHYKzZZD6hm3EEOVbZSfI3KvCddi3C8DYd6SqNp Fph9tMHp2p+t5gP6f5Lmlwd4GuI2bkhSC/c9IBa1ilV26oXI5cHAJ3A44gw6bOZvRc7IwO 1DeTGfMtzRfCr4MGG1pc0UcKzpWziixqv0+JuG6Ey48ct7d08BKAShjG8p6VcHdV+T2XMo K/tuXLW5yiMJugprC8yY982t+K7ESb2gOnVDAzvMMyefeLaSUND5XoAU+OZPp/z8sejwYc 9vUbz2FN1O36ZARQLU0g2XcnAUZc9jIqxJRKljv98GyBIZmSMoF+PZ1iQ8oJWw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619078051; a=rsa-sha256; cv=none; b=JxrHFxYtBkIEVHef1KRXTWNwVvAjeohKOLSlThrYm0VNX/tPJH2UD0E/bKSrerjM7y0rV0 20nu9IC1ZrEsNd+zqKIirrD6MUXB3ej6a/vRnw9NOqcmCWrpGgNJ3OlMbC2uqcjNSx5EoX 1o/3xPDOH7L6LCQL9CVUe4AiRSEGBiUsrrbzFAbldISb6oV/2jnt/cKqDO0bA4B6mWwSV/ XWutLHgMBNjhNLb023bha1OH3NNIoh/B5os95c+7M+1nL+EzrwneyNIaNmbUmXaEFHce2p HZ3xAiNdybim/uQe+S5GxhfIIhwZvTD0ybyTfspmWwh8MYLXh4/WSzslc3FL2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.54 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 7FD4797D9 X-Spam-Score: -4.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: RJoyw4D3D9P+ --=-=-= Content-Type: text/plain Luciana Lima Brito writes: > Hi, > > This email is mostly addressed to Christopher Baines, due to the > Outreachy. > > In the last email to me, you said this about my next steps on > contributing: > > "In terms of what to do next, you could continue on this derivation > comparison path. Some of the code you've got here could be used to make > the data better right when the database is queried. Take the recursive > field for outputs for example, it would be better to convert it to a > boolean where the database query is made." > > I looked for something related to that in the project and I found > interesting stuff on comparison.scm, is this the relevant file to make > the data better? I could see that the queries are made in there. > > For example, the test I used for the outputs field "recursive" > (recursive. ,(string=? recursive 't')) on controller.scm I moved to the > function derivation-outputs-differences-data on comparison.scm, and it > worked properly. Is this the kind of change I should be doing? > > In case of a yes, which kind of improvements should I be aiming for? > > Furthermore, should I try to achieve any improvements to the queries > itself, or this is not necessary? Small intentional changes are better, so I'd start just with looking at some of the data coming out of the query. But yes, I think you're in the right place. The hard part here is probably to look at how those values are used in the JSON and HTML rendering code, and adjust that accordingly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmCBK3pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfYlg/+N0Mp5NDiielQL7fXIDMeEJEmPpX3hYG8 hBMEpuJfh4RM7KEoQ427/bYkxvHDF/pO38PUY/9bnCmlZ20L7rvdHn97Ogu2w9Ht se6i9ij6/i2V24A8G2qGgVx6GUVSXtN/w4PDsBHOLyTNnxlqCCTr9zT1YnmgcJu2 N8z/aToN5QTIcC9iw2pfTdEQSrb9fgngwntnDsEfKe53YueaSsTjUH3s3V1KjqgO 11apQl5jiC4oRkiMG16VU/3ICksmky67zgCatb+jME86+1KSfo1IM0fTwDxg3WE4 hYjJePsMfjQWLpgjVWAz1kTWN8/1Ilsc3Y0CwcO5wCQGZ1vzeUq6l/VU2e+QfJaI jmH4QrnBgP1mVf4YGZA2q/44EgK6bR2zKalmaBjasOVAz43lAvpV5eNzN6pImJmE toqCOWhwWFC9DP366PE2nK8KzRGYZxafnX4JfpevukQF5RVR28rh0viYWc65IBx5 IMS53Yikz424xYmqP7gV3a1DdmMaI50Ak3GoMFLMFVZ0aMhREHNnPNPWhuPSdQew Ldq2Yx07cAs8kMHq4ysyRdX/tUBGETig/vEGVxV3PPjkMDVqI2Q2sKmF0ruUeTE4 VdpLrB7FpPaw3MLCHc4eUu7TVnEWJ7zTiApWumepvjZHBlFfZLFBqhur0QB8Wvm6 qT3IEAsi5tg= =8UrJ -----END PGP SIGNATURE----- --=-=-=--