From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0r.migadu.com with LMTPS id V5mYDWEOjWC8AAEALuJCtg (envelope-from ) for ; Sat, 01 May 2021 10:16:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sNObCGEOjWAQUAAAbx9fmQ (envelope-from ) for ; Sat, 01 May 2021 08:16:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85F7917415 for ; Sat, 1 May 2021 10:16:32 +0200 (CEST) Received: from localhost ([::1]:60560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcknf-0001mH-B6 for larch@yhetil.org; Sat, 01 May 2021 04:16:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcknS-0001lD-1s for guix-devel@gnu.org; Sat, 01 May 2021 04:16:18 -0400 Received: from mira.cbaines.net ([212.71.252.8]:48332) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcknP-0001Jp-Kk for guix-devel@gnu.org; Sat, 01 May 2021 04:16:17 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 0C50D27BC7C; Sat, 1 May 2021 09:16:13 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f60ce48a; Sat, 1 May 2021 08:16:12 +0000 (UTC) References: <20210428145941.4bd0dd6f@lubrito> <87y2d2e0j4.fsf@cbaines.net> <20210428162030.2cab4106@lubrito> <87v986dvrn.fsf@cbaines.net> <87eeerem9g.fsf@cbaines.net> <20210430181902.3e7baaf3@lubrito> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines To: Luciana Lima Brito Subject: Re: Outreachy: Timeline tasks In-reply-to: <20210430181902.3e7baaf3@lubrito> Date: Sat, 01 May 2021 09:16:08 +0100 Message-ID: <87bl9ueunr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619856992; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=2q7hgbNB/zLNJ4WVKR0IzJpQwRd3vlAz5Y959FXQ1eg=; b=HTZOE8Lg9+TPSMzFM21MWkwXX+Bgi8eypBI7yQTu0vU4h5rbBvkbIrJ+iuFMQMZt/MZYSD peVZG0d1GEFR9k3vdKUA6SYxoZGUfTMfZHhtdphQhxW821kZGU7mtjiKNtDYEOHgrTDiHd 8scMZT66Xy9e9y1NWC6zCBhppHglj4zPsFJAC1K0XRScF8i2bQECG9r49hZ/R4Bv+fG25h NdGUhg99y5hnDV2ybk+xRiLKcBCgwWSfRKUt7Izlo+ht3ya1FKyRqMvWFL8rOzuqAUJj9M 7xzhi9meqKZWJX3YXGdLr7giDad1DDNJis4ByE7RekH/hrtr66itGOGm86RM3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619856993; a=rsa-sha256; cv=none; b=fayaaTWeE7hcAaOC0dBFfD14udVPST4oTiNIPBHi7rN6/pvaz6l7WlG3XAdYrqHzPOogm5 4xy8n1xrCarwWxVTZYx2w+nHVFywvEJPcMx2GXyfMrehJK9dyS5H5gLJmt+m3BjGe8AWKO SgITU9lb+J4zHlsNQOaAvDG4kFFGxabkSVejHY08rTfCscc5jTJZE6bhNu/25nBmpQ6F2/ u+zkGnreAKC+myffY/i7XxWb5eWKtj7JnAj9Rn958ke6Lsgf6vILgdtJGovZYgvD/Eu+Qf SBHzoNe2gG7F5kmPSWpMEcbTxfDeDYaVmrEBLGbLBiF/Lv7z2sKTQzR+zghU1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.06 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 85F7917415 X-Spam-Score: -2.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: lqgEMNFeV9lr --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Luciana Lima Brito writes: > On Fri, 30 Apr 2021 18:05:15 +0100 > Christopher Baines wrote: > >> > >> > Task 1: Add instrumentation to identify the slow parts of processing >> > new revisions: >> > >> > - Implementing a chart over time to identify slow parts: >> > - The chart should consider two aspects, the time took by >> > each specific part, and its name, for identification >> > purpose. A bar chart is a good candidate for this task, it is >> > simple and can show the whole picture of the time taken by the >> > system to process a new revision; >> > - The bars on the chart should be sorted in order of >> > precedence of the process in the X axis, and its height, which >> > is determined by the time it takes, measured in the Y >> > axis; >> >> I'm not sure what you mean by "precedence of the process" here? > > As we are concerned only with the time each process takes, and each bar > on the chart will be presented side by side, the order of the bars would > be the order that the processes appear. If you prefer, they could be > sorted alphabetically, or by time taken. Ok, I think I follow. Currently the timing of various sections of the process includes timing smaller sections, and that may complicate reading the chart, since it won't convey which timed sections include other timed sections. Does that make sense? >> > - The charts should work as picture-logs for timing; >> > - A chart should be generated for each new revision in real >> > time;=20 >>=20 >> It would be good to say explicitly how the chart will be stored, since >> "the same way as the logs already are" is quite vague. > > I misunderstood this point so this part about storing the chart is > completely messed. But I think now I got it. Let me correct the last > point and add some more: > ... > - The time is already being computed for each part and it > is shown in the logs, the same data can be used to build the charts. > The data to build the chart for each revision could be > stored as a new table in the database*, first in parts, for > when a revision is still being processed, then combining their > parts when the processing is finished. > - The new table on the database should store three information: > the job_id, the action, and the time taken. > - Then, when one wants to see the chart, this table is queried > and the chart is rendered as html. > > * Although the information is already in the log, it is stored as a > text, so it is harder to get the names of the actions and the time > taken by each, so I think that create a new table, with only these > values, is more suitable. Great, this is a good amount of detail. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmCNDkhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeIPw/+IoH+8mDaM8X8zaOKfvN3EdAvTPbiD5qW QJccO/Atyd8DZ6GIixKH2mxDjyaUyBRV/i+cwsw2KJ3CJUZG4EjvvC46WmCRWUaG aHfTtXFDulLyQoSLBKLCysZ/8lc0vFE6T+oRpGSx0I5CvH6rRp0GMtOq0uqYaAcN AyFoFPF6bmM6Y2FiFOg+6B70hTBN65s8koOqUdcNfQZGEQeSTUeJF4OWsvs0opv7 xMUBHZYuwd0juhMjxPdFN4upicdaShU8U3dY6Qf+ds/2Z/CD6UkiUxh2+qqqDplQ GpXzWd7rNTNA+HsmQ6cqN6xYf6gB7qhiT3uRfMLgqW/OvtQUZzdvVAzxDdtcY8Z4 chLXPhf1AJ8rpdlihsEBwxBcNdVNINqBgtKGxLwvs4zvG0uMAvaVLLmYH3uE0mGj AOYr1pORy6xGi9A+qccFmzKjQ0wu9mBJ5rBCdkaTPDmDfWC+l2N/jNJMsMRr2Luq nYuQJhhMQ50N2vBq6/QBT6Cg34k7vARg9YfRrZjJ7JI9eslF/hMMRdrkTrPyRWgX FU6cRaxgGeCtl6UamiYapv20JDqGvb5hAm8MWHw0OSLRamJxv4rNzKbrW1GN5dXl M/U/kT0t04psIwnX+6In6UDWe2s4+EtptqVIpfsHkUrn/Qv6fSUwt3qg61ZchPzf jNbgX6rtMcI= =AVdi -----END PGP SIGNATURE----- --=-=-=--