From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id xHhFFLXnUGGtHgEAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 23:35:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id bcdcD7XnUGHVbgAA1q6Kng (envelope-from ) for ; Sun, 26 Sep 2021 21:35:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EDAFC308C3 for ; Sun, 26 Sep 2021 23:35:48 +0200 (CEST) Received: from localhost ([::1]:47674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUboK-0005qd-4k for larch@yhetil.org; Sun, 26 Sep 2021 17:35:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUbnr-0005pw-Re for guix-devel@gnu.org; Sun, 26 Sep 2021 17:35:20 -0400 Received: from mail.cock.li ([37.120.193.124]:56622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUbnn-0003gw-CZ; Sun, 26 Sep 2021 17:35:18 -0400 References: <87mto8zpll.fsf@airmail.cc> <87zgs3829p.fsf@gnu.org> <87tuiaq411.fsf@airmail.cc> <864ka7qwz1.fsf@fsfe.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=airmail.cc; s=mail; t=1632692098; bh=9nShchtcmmrxY1wzsscJ/pQkMHacIfFkMuWOVUpWNGo=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=epuXrIlWIA6NOKb4nCzEntlrgDcsewuRSlV97y/aOetO/EeMZ+vtfhV1extUEu1Ux sGYRaaJt5vYcgdrKro0KpA7lO5e1x3XnrQc2lPvewPIOEZ/xfMN1VIS+Nw1A0ra23E ll0m0ExVD/6eAGHdKUN+i6mkh7BGllohZmbmHGrS8A2+rGyg4ecoG5rVNrXWIzZsWD C8Zs99x5P2EU8l/Pd841prewEj4OBQ/OjJLRscnAKUXDxeAZy2Z+MGY+2x61PGL2zM GrPFkP3vjesh20l0YaXDlW0e9TYI3tDhux/AOJR6mBt+Zuj2xgh8szK73XWrn5rK63 GhcXCCt5RkVUQ== User-agent: mu4e 1.4.15; emacs 27.2 From: pinoaffe To: Jelle Licht Subject: Re: Merging the =?utf-8?B?4oCcYmluYXJ54oCd?= NPM importer? In-reply-to: <864ka7qwz1.fsf@fsfe.org> Date: Sun, 26 Sep 2021 23:34:57 +0200 Message-ID: <87bl4fdnr2.fsf@airmail.cc> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=37.120.193.124; envelope-from=pinoaffe@airmail.cc; helo=mail.cock.li X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632692149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jZSrluJmA2y9CeT3GadkQZiVznRUo6S01M5CXVDzH/8=; b=XnA2hlQFc0TML/i7xGXKL6zDW4K+A5UKRo7RmilOsdyXikY2Igfv7SEILWAZKFl1nZBUK0 MP/aeFquO2AdFPIjWILxA1kY/ieHWL/cPdXcDhQrwqlcOr9NviKYIW++6o72s5zs9vtJii qSe2qvg5Zg869NcuP5f6AGOjMDdP9rXVJRF2AXuxiqJY4KxpubN2yn72xFdYj4PFGhilq9 lpc5mPHfPDwl3Hx7GFSa7WfSFzwNRzDrEThYw/Hm05JpUOxCewynMgOqpUZarMJvwq19eL 3Rw5F8lKKtizgQuEnWau/i3jBhwWIXI4FZueVSQcpmWYL/fjFO4B09eYJyMKFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632692149; a=rsa-sha256; cv=none; b=npdGapNuAKC8O/ElOFAjnnRyIN3j8raE8DcH/6dbmBq+W9rsDhUm1VjBY8pzA+t1ZKIwNl JWa/elRmKYxWh+Ztp1Lkl3Gia65TbdoVS+H63QJbkBC+jyXP2opJ68g3/WR02LDwPWAX6F ZdMY+KXnTldKOrIPYGI55oXlRf/ji+5M5BSfUUa5i2VyDFUT7ksBUUcPm8RcX5krPBtNro kdKlW0kUIS3h+FbEMBOD90Uv/WY1QbY4MojXsxeFsoA8i7mMdDbwnB9gwh+0KG9C3fgg7S AQG3BfaI9m92f9sqcIPiT68sLJanE4ICe8MHpwEP5XXXcugwQ++2G8dpm86XAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=airmail.cc header.s=mail header.b=epuXrIlW; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=airmail.cc header.s=mail header.b=epuXrIlW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: EDAFC308C3 X-Spam-Score: -0.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: U3CuzBdwEVgQ Hi! Jelle Licht writes: > pinoaffe writes: >> I do however think that quite a couple of improvements would be >> necessary before this can be merged > The major ones I can think of are; > - Be rebased on current master (or perhaps core-updates-fixed?) > - tests > - documentation > > Could you perhaps list some additional blockers? We can always refine > and improve on an acceptable upstreamed version, since it will be a > once-and-done tool instead of some stable API. I think one would also need to deal with the fact that a recursive import is likely to include several versions of the same package, and I think rebasing might end up requiring a bit of rewriting since it appears to me that some of the interfaces used in the guix-npm-binary importer have changed since it was written Kind regards, pinoaffe