From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Recommend order for package fields?
Date: Wed, 17 Nov 2021 12:18:48 +0100 [thread overview]
Message-ID: <87bl2jxc6f.fsf@gnu.org> (raw)
In-Reply-To: <86tugd9xlz.fsf@gmail.com> (zimoun's message of "Mon, 15 Nov 2021 17:45:12 +0100")
Hi,
zimoun <zimon.toutoune@gmail.com> skribis:
> On Sun, 07 Nov 2021 at 13:40, Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org> wrote:
>
>> So the de-facto ordering of common fields is something like:
>>
>> name
>> version
>> source
>> build-system
>> outputs ; a bit inconsistent, yes, and sometimes put after *inputs
>> arguments ; to the build-system
>> native-inputs, inputs, propagated-inputs
>> metadata: synopsis, description, home-page, properties, license…
>>
>> There's some minor variation in where to put inputs, but
>> (build-system trivial-build-system) definitely belongs here, above
>> arguments, no matter what.
>
> Does it make sense to add this ordering advice in the manual? Somewhere
> under section “Contributing”.
I don’t think so; examples in the manual, ‘guix import’, etc. are
already mostly consistent.
> Especially when there is probably some issues with the semantic, for
> instance, compare [1] corner cases:
It’s not a corner case, it’s lexical scoping. :-)
> If yes, why not add a checker for “guix lint” for warning that? And
> obviously, it could be nice to have an automatic tool for formatting;
> something similar as etc/indent-code.el for ordering packages. ;-)
I think ‘guix style’ should eventually be improved to replace
etc/indent-code.el. We could augment it with specific stylers, such as
alphabetically sorting inputs.
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-11-17 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3add15b77522d6e9ebd715a19d966666@selfhosted.xyz>
[not found] ` <87r1bsqdy8.fsf@nckx>
2021-11-15 16:45 ` Recommend order for package fields? zimoun
2021-11-16 18:54 ` Katherine Cox-Buday
2021-11-17 11:15 ` Ludovic Courtès
2021-11-17 11:18 ` Ludovic Courtès [this message]
2021-11-17 11:40 ` zimoun
2021-11-19 14:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl2jxc6f.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).