From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CPmpNnP6m2EHOgEAgWs5BA (envelope-from ) for ; Mon, 22 Nov 2021 21:15:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iJVfMnP6m2G1HQAA1q6Kng (envelope-from ) for ; Mon, 22 Nov 2021 20:15:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8124D30395 for ; Mon, 22 Nov 2021 21:15:47 +0100 (CET) Received: from localhost ([::1]:34842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpFj8-0006MV-NZ for larch@yhetil.org; Mon, 22 Nov 2021 15:15:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpFi6-0006JM-Kc for guix-devel@gnu.org; Mon, 22 Nov 2021 15:14:42 -0500 Received: from [2607:f8b0:4864:20::72c] (port=45675 helo=mail-qk1-x72c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpFi4-0004Qt-Vn; Mon, 22 Nov 2021 15:14:42 -0500 Received: by mail-qk1-x72c.google.com with SMTP id d2so19399802qki.12; Mon, 22 Nov 2021 12:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Kx9izFsE951IWwUfvZ5gAx7Mty7Rpp4Z9eJ2YERZ5VQ=; b=dv4IzVNwZoPdv/Bd5pxHaK29VzWUHwRqHvw0hxpOM4C+k7QgazKVSBSjN0kL0mRHd/ F1nlkbVxWqt7v0AdTFUtLgUbwuCSyfDEa5xywkoUA9Q9L1thOxpq+zhbqoJGlMte69NY 3znPeUDz5GVvzc6kA2x7KulRYjXErjVwTn92DpYvsWHXraYQyjmitaPO0udW7XIW1o+o tqMs2k6IGCSUK5AAY9DP/F0anU7ePLvP4kaFUDwBGa4FKjYryXTuhbfhDDJ0miQS2KqJ tsAmKTWMlqiVwIKR6o3mT0VsTQvQohhOunI1upXEd6cbf86N3DEFIxXN6FMvHAch5J1q ZMlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Kx9izFsE951IWwUfvZ5gAx7Mty7Rpp4Z9eJ2YERZ5VQ=; b=LCpeSzK5ddAvdfACscmru6uCawNqb57cC4WaXoqdw6PjkIcRGpdTB0uoIUi1rmYvRO 0r5U6Yn1spuIhOGe7v7I2JPqCBas4e8/2pomf5H+h/pw1uYK2xj7mtiEdIknoVeZvqlv R+/0IL1q9nsCC7ARCM/0nY0MSX/rkBsvPOgByB/2SwsGzLMeV0b0aPPwyk66l0BNBWkO S8P6MPJ+kcl5znv1UUGVbgGOo758kbvCELZzMX0nKX0wjsuVCu4O68l0zm00/ht0bCZX RPh8XdrsuZsGBUjSLcnvHVPIc2bTG9ufK96tfAg9uj+XKxfBjr9xbcjLIYqOXGC0WpUq qHpg== X-Gm-Message-State: AOAM5320T40iKW3IrIhc72+ClrsR/HKRFzbhLlNDaZ1sm6tbLuiR0yJC w77gt1BOrn6Xnr5GYrlFqjB5gXXmaicRoQ== X-Google-Smtp-Source: ABdhPJy953l3O+uL3TlkkqKnIPJUGvh8rcekhoBJx36+JV7Fvb/iMKPCAdNh23FkE81wbENme2wqOg== X-Received: by 2002:a05:620a:131a:: with SMTP id o26mr50888161qkj.71.1637612079560; Mon, 22 Nov 2021 12:14:39 -0800 (PST) Received: from hurd (dsl-149-45.b2b2c.ca. [66.158.149.45]) by smtp.gmail.com with ESMTPSA id u11sm4998426qko.33.2021.11.22.12.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 12:14:39 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: default tar format for "make dist" and patch file length References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87zgpxaqvn.fsf@gmail.com> <871r38pgt9.fsf@gnu.org> Date: Mon, 22 Nov 2021 15:14:38 -0500 In-Reply-To: <871r38pgt9.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 22 Nov 2021 12:31:46 +0100") Message-ID: <87bl2caqxd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vagrant Cascadian , guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637612147; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Kx9izFsE951IWwUfvZ5gAx7Mty7Rpp4Z9eJ2YERZ5VQ=; b=DQddrgdbC1N/itBEV9lLdTfkQkd0MXpGu+Gz+x3qFzpP25q77bZhY/gGVn8ykebpzEK54q 3CByWUb8gSFoifMYLurkci8tC8XbjjtOM6YL8d5ZE+Jcs3vI47xRRazp2MZrulTR0DVCCb 5QpOqcPiesz5T55K6M4op5kzrnHSRxMs5qVdEJNJIoQE95wvumriQrJEx9H19P1edN5Mmt A/pFiWOXLSDluS+8myb6pOUOv3IW3USBEMmj8DB4gyE5csks19uqzm5A408bnlu2fLWoqy gyMyWkuQWPrSP2aoF1mSVWQCOJDLrvwCpiBBUcAuDG2TIQORSbD195d+644aMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637612147; a=rsa-sha256; cv=none; b=KQMPW86xEvbKRtQA40jEtlcvEWzwznHQx4PyK6tJ2+ywF1Qs+j1iGpFkqLpaUR2ZRyD9/M yryYjsWdRl2x+MD4U2hJKGFUUICG4fms5Oy5kn+ijrnmlOeIs9PKfkqpc+m72kMdpfptzQ RCITOvN4VyhZjpu4caSfZd71IolenTzxwdDosSpJDEhB0Pq9gQkD0zNhTZl6NccQDUGvms Jao0rZOW8IVOVYOs3MsbTG9YI9UePm+McLBWqOoLM9B0eXL6xD1SGiYvv3z27eYDFUUv6r dYjvK92B5lNImgoP2BDMal9Ed6XEw3zugDoH9H6qfFoKHYmgDYNevMXRcQ2iUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dv4IzVNw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.08 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dv4IzVNw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8124D30395 X-Spam-Score: -4.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: d6fC2H87UHBM Hi Ludo, Ludovic Court=C3=A8s writes: [...] > Any objections against the patch below? > > diff --git a/configure.ac b/configure.ac > index 84592f6041..341cff8fbd 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -8,7 +8,7 @@ AC_INIT([GNU Guix], > [https://www.gnu.org/software/guix/]) > AC_CONFIG_AUX_DIR([build-aux]) >=20=20 > -AM_INIT_AUTOMAKE([1.14 gnu silent-rules subdir-objects \ > +AM_INIT_AUTOMAKE([1.14 gnu tar-ustar silent-rules subdir-objects \ > color-tests parallel-tests -Woverride -Wno-portability]) >=20=20 > # Enable silent rules by default. > > > I tried it and there=E2=80=99s no tar warning and the file looks just fin= e, > including the long file names: > > $ make dist -j5 > [=E2=80=A6] > make[2]: Leaving directory '/home/ludo/src/guix' > tardir=3Dguix-1.3.0.8612-7cad44-dirty && tar --format=3Dustar -chf - "$ta= rdir" | eval GZIP=3D gzip --best -c >guix-1.3.0.8612-7cad44-dirty.tar.gz > make[1]: Leaving directory '/home/ludo/src/guix' > if test -d "guix-1.3.0.8612-7cad44-dirty"; then find "guix-1.3.0.8612-7ca= d44-dirty" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "guix-1.3.= 0.8612-7cad44-dirty" || { sleep 5 && rm -rf "guix-1.3.0.8612-7cad44-dirty";= }; else :; fi > $ tar tvf guix-1.3.0.8612-7cad44-dirty.tar.gz |grep patches/xplanet > -rw-r--r-- ludo/users 1252 2020-04-06 00:14 guix-1.3.0.8612-7cad44-di= rty/gnu/packages/patches/xplanet-1.3.1-libimage_gif.c.patch > -rw-r--r-- ludo/users 765 2020-04-06 00:14 guix-1.3.0.8612-7cad44-di= rty/gnu/packages/patches/xplanet-1.3.1-xpUtil-Add2017LeapSecond.cpp.patch > -rw-r--r-- ludo/users 6990 2020-04-06 00:14 guix-1.3.0.8612-7cad44-di= rty/gnu/packages/patches/xplanet-1.3.1-cxx11-eof.patch > -rw-r--r-- ludo/users 783 2020-04-06 00:14 guix-1.3.0.8612-7cad44-di= rty/gnu/packages/patches/xplanet-1.3.1-libdisplay_DisplayOutput.cpp.patch > >> Seems a good thing to be as portable as can be, especially since 200 >> chars patch file names wouldn't look good in the sources anyway ;-). > > I don=E2=80=99t think we care about =E2=80=9Cportability=E2=80=9D as unde= rstood in the context > of Automake, which roughly translates to =E2=80=9Csupport SunOS 2 and HP-= UX=E2=80=99s > 1991 =E2=80=98tar=E2=80=99 implementation=E2=80=9D. :-) Hehe. The patch LGTM. Thanks! Maxim