From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AIBVEeG4o2HtmwAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 18:14:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MFT2DOG4o2FyLgAAB5/wlQ (envelope-from ) for ; Sun, 28 Nov 2021 17:14:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F001A17AEB for ; Sun, 28 Nov 2021 18:14:08 +0100 (CET) Received: from localhost ([::1]:58892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrNke-0006wJ-7E for larch@yhetil.org; Sun, 28 Nov 2021 12:14:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNk4-0006uZ-Hc for guix-devel@gnu.org; Sun, 28 Nov 2021 12:13:32 -0500 Received: from [2001:470:142:3::e] (port=38970 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNk3-00044B-RD; Sun, 28 Nov 2021 12:13:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=STNFypIyU41PSgnTVMFIEtgFMv4+LbuHpVEONkcwLr0=; b=XcQf5/WM0zWA2t5dQAyK SNyUcUwf+6x72f5xHkVOllnIt0X/sCWJj//ZBGYuSUKKtQgJhVasPXHvoFtI3WGMpoF4gERKywXa3 y/d7pVwue3Pe3K7piOM+atfRBIzH0pWs155oKy1ZCouO1iuCvYMSaHTGb9ntKCxNiHh3GmkwLkQb4 shnMIxa6kwv8vDU2TM1lNyfHJiNsdBgiVBi3JmBzxh6Ww2fPs0f65H6HX5XIxuKIJk+x474RKjx5r eFzJi3YECA2a+5G48cbq/hT3RoIOK+LC/v8z/lBKtTNkLedpm2NrI490AMLGPiOgStc6jlh847bPr I5FgDysA8QzxnQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNk2-000433-8L; Sun, 28 Nov 2021 12:13:31 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org, Tobias Geerinckx-Rice Subject: Re: 13/30: daemon: Print the line whence we expect an integer. References: <20211126235303.14269.45736@vcs0.savannah.gnu.org> <20211126235309.0983120983@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Nov 2021 18:13:27 +0100 In-Reply-To: <20211126235309.0983120983@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Fri, 26 Nov 2021 18:53:08 -0500 (EST)") Message-ID: <87bl24b3uw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638119649; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=STNFypIyU41PSgnTVMFIEtgFMv4+LbuHpVEONkcwLr0=; b=SSMQ/H9r0afGuzw+O+FVz3A/CZT9uXWu5JNr+f9DtBV+OdT/e8y3IeH0nMTyqZbCG47NrJ 4ogTYUZXJMgwkET6yiv3SpefJeK3G95hmHDFPkhNZ9Cn2x/bvwpg6TGeYhlF5J5ail452G W/J1cktenHTa2NTWwq81brJMTG5G/y9CehgkDel7ilV6uFpu3Q9ZzYgBcs9QT4moof47O7 ufgNiBCsapd4z06SMm0rZ23RCFhYCmuPnk9YZ3Bd83d5weSdzCfu1jc+ugMDj0vvcbPkR1 2K/R1eFUa6HRmkBFGyoXakQQydZnZZAmSavmGSURba7IOtNYH3ByYCcHhKEO4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638119649; a=rsa-sha256; cv=none; b=r0GB6BnOCKNknbhdhNMYJQQLrIcm46W5B0mZaCmfYOoAgv4E0oAkGXdxtoZFvDAD6qbGG8 UBibWbSw9NlTZlau4x/z/r94TREHhWrdU2YjOGMZr0SRWuZMIGAvUcQeBWfa0SPUCYrvtV 6UQxk8cQWunc64VioVd6nKpcwisNtI0RwQwTNJa/HLVUle04WIijbI0Ga/UrkL9H4Y4sxp GGyhsQRhM//wYB+C+fxLi3gNdLnZffkYJBYUH3RqgzkE7o0lZrWYLTn8I0DLHlwRfCRr19 c1dYZSv+Tp0jEY6EtvpSJ47Cl2ZiAFuXKnYjbXg8NBSVIbhXNMXnRnffj34wYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="XcQf5/WM"; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.31 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="XcQf5/WM"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: F001A17AEB X-Spam-Score: -5.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: Rw7GL1DtBdfw Hi Tobias! guix-commits@gnu.org skribis: > --- a/nix/libstore/local-store.cc > +++ b/nix/libstore/local-store.cc > @@ -839,7 +839,8 @@ template T LocalStore::getIntLineFromSubstit= uter(Agent & run) > { > string s =3D getLineFromSubstituter(run); > T res; > - if (!string2Int(s, res)) throw Error("integer expected from stream"); > + if (!string2Int(s, res)) > + throw Error(format("integer expected from stream: %1%") % s); I would not print =E2=80=98s=E2=80=99 as-is because it could contain garbag= e, which in turn could have undesirable side effects. My 2=C2=A2, Ludo=E2=80=99.