Re: 13/30: daemon: Print the line whence we expect an integer.

Re: 13/30: daemon: Print the line whence we expect an integer.

[Ludovic Courtès]

Hi Tobias!

guix-commits@gnu.org skribis:

> --- a/nix/libstore/local-store.cc
> +++ b/nix/libstore/local-store.cc
> @@ -839,7 +839,8 @@ template<class T> T LocalStore::getIntLineFromSubstituter(Agent & run)
>  {
>      string s = getLineFromSubstituter(run);
>      T res;
> -    if (!string2Int(s, res)) throw Error("integer expected from stream");
> +    if (!string2Int(s, res))
> +        throw Error(format("integer expected from stream: %1%") % s);

I would not print ‘s’ as-is because it could contain garbage, which in
turn could have undesirable side effects.

My 2¢,
Ludo’.