From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yHs2MKbOzmGQNgEAgWs5BA (envelope-from ) for ; Fri, 31 Dec 2021 10:34:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6HepLabOzmFvsAAA9RJhRA (envelope-from ) for ; Fri, 31 Dec 2021 10:34:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4DA952EF23 for ; Fri, 31 Dec 2021 10:34:30 +0100 (CET) Received: from localhost ([::1]:49442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3EIv-0002Ct-El for larch@yhetil.org; Fri, 31 Dec 2021 04:34:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EI3-0002Cl-J2 for guix-devel@gnu.org; Fri, 31 Dec 2021 04:33:35 -0500 Received: from sender3-of-o51.zoho.com ([136.143.184.51]:21119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EHz-0001F1-9F for guix-devel@gnu.org; Fri, 31 Dec 2021 04:33:33 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1640943208; cv=none; d=zohomail.com; s=zohoarc; b=gugiA9EgDkJg9NzfigqfE5ElocwhJe242EOoeRAWAUsS4+nar+WxiC9M6KoIjao1wHA8v9Ka8Nl1O79tPy2nZGDFQnWm453/wv2g08+KrQGL9f1wAq0Rdtp9701xoe0zCPFfUNMFaoUJAyLsq0l3jrQDgft4MLTEO8YlGdNtOMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640943208; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GKS+CMTTygHnPfVhvq0DboL8BWGBsYX6GyIfIAUEGG4=; b=Bjq6e8+nefvHzFE9hWIzTkGBVptfv0c4ekJfNzwZM7zTsTxnkeCrZELA/zrfC0brhBg1kr2kgmV0sEz7mSiiie30uGKcVRHrm8TAjXtWm5ij5vUs4PyYc1jh794IAKa+fjrQg383QnBE+AGj403BtV8As+nkjTIG3Pp6FYnB6Xc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640943208; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=GKS+CMTTygHnPfVhvq0DboL8BWGBsYX6GyIfIAUEGG4=; b=i0+Ayuh0am4cH1siG1Pdt7du3EWxgAkxmPGcftYC26RvNkU8xIGrx2vPFFpU4BVX /kcQcw1lHi2JKTL3TlTXLkz7Ag42Vm2C0bAXJF/d5Eal/TXoqpH9TkeF2RleYxj50XH QnwPKCCG+tkwomyRPMoMh93FWdAiPC95lXeY139c= Received: from localhost (p54ad4eae.dip0.t-ipconnect.de [84.173.78.174]) by mx.zohomail.com with SMTPS id 1640943206247587.2555726725146; Fri, 31 Dec 2021 01:33:26 -0800 (PST) References: <6e451a878b749d4afb6eede9b476e5faabb0d609.camel@gmail.com> <86y243kdoo.fsf@gmail.com> <899587fb6a76ddfa37d197d3d0fd23cdc7ad8592.camel@gmail.com> <867dbmi7pf.fsf@gmail.com> <3d448fe42f0c43574db96fa26aecd7da5fd5a95d.camel@gmail.com> <86k0flpnx5.fsf@gmail.com> <9a5e3e7f44155146d731dd5a97450a9ff9dff5ab.camel@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Ricardo Wurmus To: Liliana Marie Prikler Subject: Re: On raw strings in commit field Date: Fri, 31 Dec 2021 10:31:14 +0100 In-reply-to: <9a5e3e7f44155146d731dd5a97450a9ff9dff5ab.camel@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87bl0xglul.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.51; envelope-from=rekado@elephly.net; helo=sender3-of-o51.zoho.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640943270; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=GKS+CMTTygHnPfVhvq0DboL8BWGBsYX6GyIfIAUEGG4=; b=PcouB383mkOYEZQ+ew/g70/zCaIckB1vxKKDE53Rv+EDJitNAPgI33uuT8c2Qtiys/+Q9L 0+RdwxJYXefKqdyL8waomGyNJgMo+NO/+PWcTjKQwqH5iSPmvguX7clDV8WJMFv2WyBRso ZD7QnSx8SKNcmCiZEIIdTxqk3IXIhvi2Gv12UGfH3+zpx/JVK6ATrfVNeir2ey5RL6l+il MNqbyBrYQ6/GWXFnLAhylweQVt5F/gwphk7XV3beVyoJOt5OSgSWoU2/3IRS3wk/+UdANY J0eFsjmBXRgAqjPfBWslUhG87UPx87fVB0HTG1Br0yUEALEVx2QscD1mCQIfWg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1640943270; a=rsa-sha256; cv=fail; b=EsjQSaTlwk+FmijFZmdeLaJ26W6LXSkV6IXcj0KbKxkm0eKDuwNo+vzX4j42XLxirwNsSX VrhiGQyaJ7xBtKjtx5Bc13U1XNFHuwc1DvwXVOFo5rDqyWbosOMCEnyN3DL+knTd+9eVoI jwgjM08YysH/Gn7Hk3mSqOUm+TlF3EcjcM7NloCNJDppvlHc946m6q77p7zE8BCOzVrT/d M895XkoZAaKvVDAo9q/NY4wo2oeg0jH1QJOt81yVox3Bx0KsqAvNK92MVqNPEFOV6qhh4h ZT/OmJmcRwSWmMfMwJLwWw/CIl6xM24tWStuO2W2jygdvoXJY5jrVh2sKUIFRg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=i0+Ayuh0; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=i0+Ayuh0; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4DA952EF23 X-Spam-Score: -1.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: q0Mul3C87FpT Liliana Marie Prikler writes: >> And for completeness, let quote Ludo again from the same thread. :-) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 No, I think we should conside= r always referring to commits >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 instead of tags.=C2=A0 It=E2= =80=99s annoying from a readability viewpoint, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 but it would ensure reproduci= bility.=C2=A0 Even flatpak has this >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 policy.=C2=A0 :-) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 https://github.co= m/flathub/flathub/wiki/App-Requirements > ...=20 > > Fine, I'mma quote flathub for a change. >> When building from a git tag, both the tag name and the commit id >> should be specified, like so: >>=20 >> "tag": "1.0.4", >> "commit": "cdfb19b90587bc0c44404fae30c139f9ec1cca5c" > It's almost as though they know a commit without a tag has no intrinsic > meaning. Also, I'm pretty sure flatpak could care less about hashes if > asked to (unlike Guix, which requires you provide one to be granted > network access), so the optional by means other than policy SHA-1 hash > here is not comparable to the required SHA-256 hash we always have. In the past I=E2=80=99ve also added a comment above the raw commit, stating= that it corresponds to the given version. I have no strong feelings for or against any of the proposed options. I think that using raw commits might not be great for our tooling because we=E2=80=99re not reusing an existing version string and would need to reme= mber to update the raw commit as well. But other than that I don=E2=80=99t find= the raw commit to introduce readability problems for humans. --=20 Ricardo