From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: Tobias Geerinckx-Rice <me@tobias.gr>, Guix Devel <guix-devel@gnu.org>
Subject: Re: The package/inherit trap
Date: Tue, 07 Mar 2023 11:43:10 -0500 [thread overview]
Message-ID: <87bkl4y0kh.fsf@gmail.com> (raw)
In-Reply-To: <86lek8dbsf.fsf@gmail.com> (Simon Tournier's message of "Tue, 07 Mar 2023 12:46:24 +0100")
Hi Simon,
Simon Tournier <zimon.toutoune@gmail.com> writes:
> Hi,
>
> On Fri, 03 Mar 2023 at 20:21, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
>> Could we rename it to something like
>> ‘package+replacements/inherit’? To me, that captures the spirit,
>> without being overly longer.
>
> Well, I gave a look at the code and have seen the replacement. But I
> had not thought about the package transformation and the like.
>
> From my point of view, the best would to add a paragraph with index
> entries under “Defining-Package-Variants” section [1].
>
> However, in the light of Maxim’s explanations, the example from the
> manual appears to me inconsistent:
>
> You can just as well define variants with a different set of
> dependencies than the original package. For example, the default
> @code{gdb} package depends on @code{guile}, but since that is an
> optional dependency, you can define a variant that removes that
> dependency like so:
>
> @lisp
> (use-modules (gnu packages gdb)) ;for 'gdb'
>
> (define gdb-sans-guile
> (package
> (inherit gdb)
> (inputs (modify-inputs (package-inputs gdb)
> (delete "guile")))))
> @end lisp
Do you mean inconsistent because based on what I wrote it should have
used "package/inherit gdb ..." instead of (package (inherit gdb) ...) ?
If so, I agree. It could be modified to use the former and an extra
explanation offered about why package/inherit is used here when it's to
be preferred to plain inheritance.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-07 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230221130600.18932-1-sharlatanus@gmail.com>
[not found] ` <20230226004406.6215-1-sharlatanus@gmail.com>
[not found] ` <87ilfmhkuh.fsf_-_@gnu.org>
[not found] ` <87lekijcwi.fsf@gmail.com>
[not found] ` <87v8jixg6u.fsf@gnu.org>
[not found] ` <CAJ3okZ1oYVdW6R0x3u-zOGnCoSHa+RmB2w7cwsdwnpKzyXYaww@mail.gmail.com>
[not found] ` <87o7p94yqk.fsf@gmail.com>
2023-03-03 19:21 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Tobias Geerinckx-Rice
2023-03-04 3:44 ` The package/inherit trap Maxim Cournoyer
2023-03-07 11:46 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Simon Tournier
2023-03-07 16:43 ` Maxim Cournoyer [this message]
2023-03-07 17:46 ` The package/inherit trap Simon Tournier
2023-03-07 22:11 ` Tobias Geerinckx-Rice
2023-03-08 9:07 ` Simon Tournier
2023-07-31 20:17 ` John Kehayias
2023-08-06 23:10 ` Mark H Weaver
2023-08-07 14:41 ` Maxim Cournoyer
2023-08-10 20:40 ` Mark H Weaver
2023-08-10 21:27 ` Mark H Weaver
2023-09-02 18:46 ` Maxim Cournoyer
2023-08-07 0:00 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) (
2023-08-07 6:29 ` Attila Lendvai
2023-08-07 14:43 ` The package/inherit trap Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkl4y0kh.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).