From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OGRTKYVI92SPzgAA9RJhRA:P1 (envelope-from ) for ; Tue, 05 Sep 2023 17:25:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OGRTKYVI92SPzgAA9RJhRA (envelope-from ) for ; Tue, 05 Sep 2023 17:25:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 809CC375CE for ; Tue, 5 Sep 2023 17:25:57 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZJWpsQC2; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693927557; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wH33QLfSFtbHnAo0wcjMjZWLp3WeyRzbbcCVIYn9XG4=; b=O/9GmEcg/Y/Rp1cm8t1T+n/GunN+u6CyvEav2wpQ7f0mzRiT4LjtSX/IjG0zuL/tCeJaah x5lyEpMAERwmpGrCjQcLfMUW3XXXDaxaUeHN9M2G9Ml7SL1sDvLvUOfodbq+5mr5pKXRi2 Pd4Iy/6vC+Y7UUsog+xQKB00hLCz6I1Z3R4YkevnlumT1ojB9Lh4mWCVAfNHQSrDMjJA23 72QubiKLhD2zRU97uPDwFb8J8hqAGWXOjT9vHjEATpEWdZb/7743e0Kc+xsjRRVRFIoQCj A+TSQC9r+7VE7jnhCTWF5EH0RUAjQe6nkSRJwVIpzYSukjQwSbYk4NvREKskoA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693927557; a=rsa-sha256; cv=none; b=ZiR6UMRpfQ4GQsrIrnGs8Jes6kO8pdHkzL06TPLrD38HnOx11gIT7GqKextiHPpkiXs6Qn w0pWHfTy2nBOelOnRoNuUFu7XaXz+Lw8jy2ErruKDWtTg1A1JEORbD/XDcu50W6vdUeBI/ C4l13cQMETu1yJHdJE0emcTYvbMPllASwLgs/33+Dd9mvUQZFIIcJqRhVP/WIkd8hYYEuR XBsWCkPYB8wDLPn/CvBs81MJ28hXd3dV7IIIitgmxpWkPlFCrg/0sLMjH5Ti25av2n28do XTED5ZbFad3Snfb2n2iF0erjUKjX7PIa4UvRLVg+ROzyhMypOlS43iff8z+zKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZJWpsQC2; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdXvY-0001uo-B1; Tue, 05 Sep 2023 11:25:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdXvW-0001tk-Gg for guix-devel@gnu.org; Tue, 05 Sep 2023 11:25:14 -0400 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdXvU-0002yk-9n for guix-devel@gnu.org; Tue, 05 Sep 2023 11:25:14 -0400 Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-64c5f5d6f04so15311306d6.3 for ; Tue, 05 Sep 2023 08:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693927511; x=1694532311; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wH33QLfSFtbHnAo0wcjMjZWLp3WeyRzbbcCVIYn9XG4=; b=ZJWpsQC2liXhuup5zyMQyauRjDah2hvr75eYH2wRKF3uUqhK1oR/YcJmC8Xtoa5KjM 1H7x22VA2fPvQex0OjZhzZJEQa9714qkyjzEQjnlZBvDv73exauwtQdVvGYTPU6aGRAg vUPqrB4/zoN87IXec7+XT7oG5nvOuTKlkJ3Mwn4NjZD76HCLVV50aKPqyHLzdzfWy31p E5AfUw1kDoOricEvldhWuZUwDg2fp3C/rr9TH7T1lqyxupn0kijE7AUxZ0YhbN7aUJEV RwUEvB1WqXssumwTpUFlhBQleXktnpt/MbgcY5IGBJDGYaDfsyJ5/uERdn1iK3/SayOV MiRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693927511; x=1694532311; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wH33QLfSFtbHnAo0wcjMjZWLp3WeyRzbbcCVIYn9XG4=; b=OerqKF9xhXuI5j29yY7kCXFZLH6CiWcqZcJAJxaj1mCTRZVIAy0/uCFECegoi/xECB v2zEiQ8FJRDRWP+7ulDHXc7YLiMWaUa905H6nsc9JcUaPTRMo55/Z679HQkhZ12Q2/16 VDvk2wxlec787B02D8daJ56+aji3ty4yqhLW2aPK5OiW+Ivff3bbj3BNI958Ln84BacV Dfn6MUNwcSlT75eXznVW6vnfgRaIh22lehzLnJRkebXB8FcD/45kBkeJinA8Y8zzu/oj WZO5MVADy7a0fC4bF5gx7Vf4gt9h5O05XMKdAf9C6DzhPFNmtlJWO/jukCLRvmCEVgDS 4vxA== X-Gm-Message-State: AOJu0Yzb/qqIKdO7e8zz16gI0MT2U7uq83QAPseT+HeXzii4pthN9zYy Xsoq/C4Fu0spsJaTcaN+dFc= X-Google-Smtp-Source: AGHT+IFBDM69Wpt0SyHVbn/gcFtxQmyM7Fm03nIpUQbyOlOUaIuwk9HTJqOrGUDXTVK/F07d31leyw== X-Received: by 2002:a0c:e193:0:b0:651:6123:867a with SMTP id p19-20020a0ce193000000b006516123867amr13333733qvl.5.1693927511103; Tue, 05 Sep 2023 08:25:11 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id k19-20020a05621414f300b006535738d392sm3710874qvw.7.2023.09.05.08.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 08:25:10 -0700 (PDT) From: Maxim Cournoyer To: brian via "Development of GNU Guix and the GNU System distribution." Cc: pinoaffe , brian , Andreas Enge , Attila Lendvai , Csepp , paul , Giovanni Biscuolo , Katherine Cox-Buday Subject: Re: How can we decrease the cognitive overhead for contributors? References: <871qfsuvad.fsf@gmail.com> <8e74c4ac-a6f3-9127-7e13-593a2eb70432@gmail.com> <87a5ubqxm6.fsf@gmail.com> <877cp8965f.fsf@xelera.eu> <8eb1be08-4c3a-bd30-46c7-4ed653c4bb12@autistici.org> <87ledotmqc.fsf@riseup.net> <874jkads65.fsf@spork.org> <8734ztvt1g.fsf@gmail.com> <87edjcbsyx.fsf@spork.org> Date: Tue, 05 Sep 2023 11:25:08 -0400 In-Reply-To: <87edjcbsyx.fsf@spork.org> (brian via's message of "Tue, 05 Sep 2023 10:22:14 -0400") Message-ID: <87bkegiqwb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -7.09 X-Migadu-Queue-Id: 809CC375CE X-Migadu-Spam-Score: -7.09 X-TUID: KRX/zhyI6ffV Hi, brian via "Development of GNU Guix and the GNU System distribution." writes: > pinoaffe writes: > >> Andreas Enge writes: >>> So as far as I am concerned, they are tremendously useful. Well, that m= ay >>> be due to a lack of git knowledge, of course! But while in other projec= ts >>> I often find I need to look at the content of commits, in Guix it is of= ten >>> enough to just look at the changelog. >> >> I also quite like the commit messages, they've allowed me to find things >> that I couldn't have found using `git blame` > > There's a trade-off, though. They seem to have their uses for some > people, though it doesn't appear to me to be majority of people, on some > occasions (the relative number of which I can't guess, since I don't use > them at all). However, there's a cost, too. The very existence of them > as a requirement puts at least some people off from submission at all, > it adds to the work of people who still put in the effort to submit > (especially so for people not using Emacs!), it's an extra check for > committers to go through. If the check fails, the patch can get bounced > back for (to me) trivial reasons, or, best case, the committer fixes the > error themselves. But even in the best case, since the commit hash has > now changed, it causes =E2=80=98git branch -d=E2=80=99 to issue a warning= about unmerged > commits. > > I, clearly, do not think the trade-off is worth it. While experimenting with package builds, it's frequent to add inputs while testing. It can be easy to forget about them later when preparing the commit message. Typing them out in your commit message forces you to sign on these changes as 'intended'. I find them useful for that purpose and frequently catch problems in my commits while writing the associated changelog (in other words, it forces me to review my own code). While 'git log -G' can be useful, it doesn't replace changelog commit messages, which are much faster (cheaper) to go through with 'git log --grep=3D'. --=20 Thanks, Maxim