From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: New package recipe: libopus-1.1
Date: Wed, 22 Jan 2014 23:39:39 +0100 [thread overview]
Message-ID: <87a9enskt0.fsf@gnu.org> (raw)
In-Reply-To: <20140122205933.GA30625@debian> (Andreas Enge's message of "Wed, 22 Jan 2014 21:59:33 +0100")
Andreas Enge <andreas@enge.fr> skribis:
> thanks for the patch, and congratulations for your first guix package
> (which I did not try out yet, I simply assumed it worked...).
Indeed, cool. :-)
And thanks to the other people for the reviews!
> Actually, it should go into oggvorbis.scm, where we put all xiph codecs.
> Could you please do so and drop the new file, also from gnu-system.am?
Agreed.
> I am not sure about the
> Signed-off-by: Sree Harsha Totakura <sreeharsha@totakura.in>
> field; normally you are simply the author, no need to add it (and when
> Ludovic applies patches coming from the list, he normally signs them off).
Right.
Note to the reviewers: feel free to push a patch that looks good to you
and uncontroversial, per the guidelines in ‘HACKING’. Don’t be shy. ;-)
Ludo’.
next prev parent reply other threads:[~2014-01-22 22:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 15:23 New package recipe: libopus-1.1 Sree Harsha Totakura
2014-01-22 15:29 ` Cyril Roelandt
2014-01-22 16:11 ` Sree Harsha Totakura
2014-01-22 16:37 ` Mark H Weaver
2014-01-22 17:10 ` Sree Harsha Totakura
2014-01-22 22:42 ` Ludovic Courtès
2014-01-23 18:41 ` Sree Harsha Totakura
2014-01-24 13:05 ` Ludovic Courtès
2014-01-22 20:59 ` Andreas Enge
2014-01-22 22:39 ` Ludovic Courtès [this message]
2014-01-23 15:49 ` Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1) Mark H Weaver
2014-01-23 16:51 ` Ludovic Courtès
2014-01-23 16:58 ` Thompson, David
2014-01-23 18:12 ` Andreas Enge
2014-01-24 12:53 ` Ludovic Courtès
2014-01-23 19:26 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9enskt0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).