From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] union: Ensure that the output is always a directory
Date: Fri, 04 Apr 2014 00:10:01 +0200 [thread overview]
Message-ID: <87a9c2njye.fsf@gnu.org> (raw)
In-Reply-To: <87mwg2gjcs.fsf_-_@yeeloong.lan> (Mark H. Weaver's message of "Thu, 03 Apr 2014 18:04:51 -0400")
Mark H Weaver <mhw@netris.org> skribis:
> From 6c8582bc41c8935b8e9d63146595e87d9b92fa95 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Apr 2014 17:49:20 -0400
> Subject: [PATCH] union: Ensure that the output is always a directory.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Fixes the creation of single-package profiles, reported by Ludovic Courtès.
>
> * guix/build/union.scm (union-build): Add new internal procedure
> 'union-of-directories' that always creates a directory, containing the code
> previously used only to merge multiple directories. Call it from the
> multiple-directory case in 'union' and from the top-level 'union-build'.
Looks good to me.
Can you run ‘make check TESTS=tests/guix-package.sh’, and push if it’s
OK? (Actually that test was catching the problem.)
Thanks for the quick fix!
Ludo’.
prev parent reply other threads:[~2014-04-03 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 18:37 [PATCH] union: Rewrite to be faster; handle symlink/directory conflicts Mark H Weaver
2014-04-02 19:20 ` Ludovic Courtès
2014-04-03 20:15 ` Ludovic Courtès
2014-04-03 22:04 ` [PATCH] union: Ensure that the output is always a directory Mark H Weaver
2014-04-03 22:10 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9c2njye.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).