From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add patchutils and quilt
Date: Mon, 07 Apr 2014 21:10:44 +0200 [thread overview]
Message-ID: <87a9bxuf9n.fsf@gnu.org> (raw)
In-Reply-To: <871tx98655.fsf@gmail.com> (Eric Bavier's message of "Mon, 07 Apr 2014 11:18:46 -0500")
Eric Bavier <ericbavier@gmail.com> skribis:
> From df0c351c53ede204d4b60bad0c0709fec0708675 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 7 Apr 2014 11:15:48 -0500
> Subject: [PATCH] gnu: Add patchutils and quilt
>
> * gnu/packages/patchutils.scm: New file
> * gnu/packages/patches/patchutils-xfail-gendiff-tests.patch: New patch
> * gnu-system.am (GNU_SYSTEM_MODULES): Add patchutils.
> (dist_patch_DATA): Add patch.
[...]
> + (inputs `(("perl" ,perl)
> + ("diffutils" ,diffutils)
> + ("patch" ,patch)
> + ("sed" ,sed)
> + ("gawk" ,gawk)))
Only Perl needs to be kept; the others are implicitly provided.
If Perl is also needed at build time, it should be added to
‘native-inputs’.
> + (synopsis "Collection of tools for manupulating patch files")
> + (description
> + "Patchutils contains a collection of tools for manipulating patch files:
> +interdiff, combinediff, flipdiff, filterdiff, fixcvsdiff, rediff, lsdiff,
> +grepdiff, splitdiff, recountdiff, and unwrapdiff. You can use interdiff to
> +create an incremental patch between two patches that are against a common
> +source tree, combinediff for creating a cumulative diff from two incremental
> +patches, and flipdiff to transpose two incremental patches. Filterdiff is for
> +extracting or excluding patches from a patch set based on modified files
> +matching shell wildcards. Lsdiff lists modified files in a patch. Rediff,
> +recountdiff, and unwrapdiff correct hand-edited (or otherwise broken)
> +patches.")
It would be perfect if you could shorten that to 6-7 lines, and add two
spaces after end-of-sentence periods.
> + (inputs `(("perl" ,perl)
> + ("diffutils" ,diffutils)
> + ("findutils" ,findutils)
> + ("less" ,less)
> + ("file" ,file)
> + ("ed" ,ed)
> + ("sed" ,sed)
> + ("bash" ,bash)
> + ("grep" ,grep)))
Likewise: only Perl, less, file, and ed must be kept.
Could you change that before pushing?
Thanks,
Ludo’.
prev parent reply other threads:[~2014-04-07 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 16:18 [PATCH] Add patchutils and quilt Eric Bavier
2014-04-07 19:10 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9bxuf9n.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).