From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Thompson <dthompson2@worcester.edu>
Subject: Re: [PATCH] gnu: Add rtorrent and libtorrent.
Date: Sat, 22 Nov 2014 10:43:42 -0500
Message-ID: <87a93jb5qp.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
References: <87a93j9wty.fsf@taylan.uni.cx>
	<87fvdbb9xm.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<8761e79sce.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1XsCqi-0007vp-7J
	for guix-devel@gnu.org; Sat, 22 Nov 2014 10:43:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1XsCqh-0000R7-99
	for guix-devel@gnu.org; Sat, 22 Nov 2014 10:43:48 -0500
Received: from mail.fsf.org ([208.118.235.13]:47484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1XsCqh-0000Qx-6L
	for guix-devel@gnu.org; Sat, 22 Nov 2014 10:43:47 -0500
In-Reply-To: <8761e79sce.fsf@taylan.uni.cx>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?Q?Taylan_Ulrich_Bay=C4=B1rl=C4=B1=2FKammer?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

"Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer" <taylanbayirli@gmail.com> writes:

> David Thompson <dthompson2@worcester.edu> writes:
>
>> Please break this into 2 commits, one for each new package.
>
> rTorrent and its libTorrent kind of belong together, though I guess
> they're strictly speaking separate packages...

Yes, they belong together, but it's best to have small, focused
patches.

>>> +    (home-page "http://nmap.org/")
>>
>> Should be "http://libtorrent.rakshasa.no/"
>
> Whoops, too much copy & paste. :-)
>
> (I'm working on an nmap recipe too.)

I figured.  I've made that mistake, too.

> Here's the new patches.  By the way the first does not strictly need the
> "#:use-module (gnu packages check)" since cppunit is commented out for
> now, but I left it there; is that OK?

Might be best to move that line to the patch that adds rtorrent, for
cleanliness.

The new patches look good to me.  Let's see what Ludo thinks.  :)

--=20
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate