unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Thompson <dthompson2@worcester.edu>
To: "Tomáš Čech" <sleep_walker@suse.cz>, guix-devel@gnu.org
Subject: Re: [PATCH v3] gnu: Add bullet.
Date: Thu, 11 Dec 2014 22:09:22 -0500	[thread overview]
Message-ID: <87a92tftst.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1418336516-27971-1-git-send-email-sleep_walker@suse.cz>

Hello again,

Missed one thing during my previous review.

Tomáš Čech <sleep_walker@suse.cz> writes:

> * gnu/packages/game-development.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu-system.am                     |  1 +
>  gnu/packages/game-development.scm | 43 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 gnu/packages/game-development.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index e923340..481a9a7 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -95,6 +95,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/freeipmi.scm			\
>    gnu/packages/ftp.scm				\
>    gnu/packages/fribidi.scm			\
> +  gnu/packages/game-development.scm		\
>    gnu/packages/games.scm			\
>    gnu/packages/gawk.scm				\
>    gnu/packages/gcal.scm				\
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> new file mode 100644
> index 0000000..72e73dd
> --- /dev/null
> +++ b/gnu/packages/game-development.scm
> @@ -0,0 +1,43 @@
[snip]
> +(define-public bullet
> +  (package
> +    (name "bullet")
> +    (version "2.82")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bullet.googlecode.com/files/bullet-"
> +                                  version "-r2704.tgz"))

I remember there being some discussion about dashes in version numbers,
and I can't remember the outcome.  If there's no issue, I think that the
"-r2704" should be part of the version number string.

> +              (sha256
> +               (base32 "1lnfksxa9b1slyfcxys313ymsllvbsnxh9np06azkbgpfvmwkr37"))))
> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f)) ; no 'test' target
> +    (home-page "http://bulletphysics.org/")
> +    (synopsis "3D physics engine library")
> +    (description
> +     "Bullet is a physics engine library usable for collision detection.  It 
> +is used in some video games and movies.")
> +    (license zlib)))
> -- 
> 2.0.4
>
>

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

  reply	other threads:[~2014-12-12  3:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 22:21 [PATCH v3] gnu: Add bullet Tomáš Čech
2014-12-12  3:09 ` David Thompson [this message]
2014-12-12  7:08   ` Tomas Cech
2014-12-12 13:53     ` Mark H Weaver
2014-12-13 12:41       ` Tomáš Čech
2014-12-13 12:41         ` [PATCH v4] " Tomáš Čech
2014-12-13 15:58           ` David Thompson
2014-12-15 10:48             ` Tomas Cech
2014-12-15 10:50               ` [PATCH v5] " Tomáš Čech
2014-12-15 13:14               ` [PATCH v4] " David Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a92tftst.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me \
    --to=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    --cc=sleep_walker@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).