From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH 11/15] gnu: Add xfce4-settings.
Date: Fri, 12 Dec 2014 20:53:24 +0800
Message-ID: <87a92t81x7.fsf@gmail.com>
References: <1418212956-1698-1-git-send-email-iyzsong@gmail.com>
	<1418212956-1698-11-git-send-email-iyzsong@gmail.com>
	<877fxx1tlx.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1XzPiw-0006Aw-R7
	for guix-devel@gnu.org; Fri, 12 Dec 2014 07:53:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1XzPir-0005Pn-Qz
	for guix-devel@gnu.org; Fri, 12 Dec 2014 07:53:34 -0500
Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:63841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1XzPir-0005PS-JG
	for guix-devel@gnu.org; Fri, 12 Dec 2014 07:53:29 -0500
Received: by mail-pd0-f170.google.com with SMTP id v10so7104718pde.15
	for <guix-devel@gnu.org>; Fri, 12 Dec 2014 04:53:28 -0800 (PST)
In-Reply-To: <877fxx1tlx.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> writes:
>
>> * gnu/packages/xfce.scm (xfce4-settings): New variable.
>> ---
>>  gnu/packages/xfce.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
>> index 5f15594..c601852 100644
>> --- a/gnu/packages/xfce.scm
>> +++ b/gnu/packages/xfce.scm
>> @@ -310,3 +310,33 @@ your system in categories, so you can quickly find =
and launch them.")
>>       "Session manager for Xfce, it will restores your session on startu=
p and
>>  allows you to shutdown the computer from Xfce.")
>>      (license gpl2+)))
>> +
>> +(define-public xfce4-sesttings
>
> The variable name above has a typo:
>   'xfce4-sesttings' ->
>   'xfce4-settings'.
Oh
>
>> +  (package
>> +    (name "xfce4-settings")
>> +    (version "4.10.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "http://archive.xfce.org/xfce/4.10/sr=
c/"
>> +                                  name "-" version ".tar.bz2"))
>
> Instead of putting "4.10" directly in the string above, how about this:
>
>     (uri (string-append "http://archive.xfce.org/xfce/"
>                         (version-major+minor version)
>                         "/src/" name "-" version ".tar.bz2"))
>
> This way, when the package is updated to a new version, there will be
> one less thing to change.  The same change could be made to many of your
> other xfce packages.
>
> 'version-major+minor' is in the (guix utils) module, so you'll need to
> add that to the import list.
Adjusted, thanks for review!
>
> Thanks for working on this!
>
>       Mark