From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] services: xorg: Make SLiM sessions configurable. Date: Fri, 19 Dec 2014 22:24:07 +0100 Message-ID: <87a92juydk.fsf@gnu.org> References: <1418661051-527-1-git-send-email-iyzsong@gmail.com> <87d27jp57m.fsf@gnu.org> <87lhm3ipvg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2522-00070R-VH for guix-devel@gnu.org; Fri, 19 Dec 2014 16:24:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y251z-0006WK-0A for guix-devel@gnu.org; Fri, 19 Dec 2014 16:24:18 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:52671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y251y-0006W2-I7 for guix-devel@gnu.org; Fri, 19 Dec 2014 16:24:14 -0500 In-Reply-To: <87lhm3ipvg.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Sat, 20 Dec 2014 00:08:35 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?5a6L5paH5q2m?= Cc: guix-devel@gnu.org =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > From 144bf00b86f6884615d986598ccc62a3c4747eef Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D > Date: Tue, 16 Dec 2014 00:21:46 +0800 > Subject: [PATCH] services: xorg: Make SLiM sessions configurable. > > * gnu/services/xorg.scm (%default-xsessions): New variable. > (xsessions-directory): New procedure. > (slim-service): Add #:sessions and #:auto-login-session parameters. > [slim.cfg]: Honor #:sessions. > (xinitrc): Adjust accordingly. LGTM. However, please leave .xsession (instead of .xinitrc) in this patch. The change to .xinitrd should be done separately. > + ;; First, try to run ~/.xinitrc with the specified session. > + (exec-from-login-shell (string-append home "/.xinitrc") sessio= n) > + ;; Then starts the specified session directly. > + (exec-from-login-shell session)))) s/Then starts/Then try to start/ OK to push with these two changes. > In additation, I pass session to ~/.xinitrc (replace ~/.xsession, since > it's what to expect from slim according to [1][2]). [...] > [1] https://wiki.archlinux.org/index.php/Slim#Environments > [2] https://lists.gnu.org/archive/html/guix-devel/2014-12/msg00282.html I wasn=E2=80=99t sure about .xsession vs .xinitrc, so I did some research. reads: Your login script, .xinitrc, works with startx, but graphical login managers like GDM do not look for .xinitrc. Instead, they look for a file named .xsession in your home directory. Likewise, reads: Note that ~/.xinitrc is only for configuring the initialization of xinit. If you want the script to be called when ever an X Session is started, then you should instead use ~/.xsession. Someone at writes: If you log in in graphical mode on an X display manager (xdm, gdm, kdm, wdm, lightdm, =E2=80=A6), traditionally, what is executed after you = log in is some scripts in /etc/X11 then ~/.xsession. Citing the =E2=80=98startx=E2=80=99 man page on Debian at : Keep in mind that .xinitrc is used only by xinit(1) and completely ignored by xdm(1). So it seems that the Right Thing is to use ~/.xsession in our case. WDYT? (I think we should provide a =E2=80=98startx=E2=80=99 command as well event= ually, and it will have to read .xinitrc.) Thanks, Ludo=E2=80=99.