From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 3/8] gnu: Add djvulibre. Date: Tue, 03 Mar 2015 13:19:04 +0100 Message-ID: <87a8zup93b.fsf@gnu.org> References: <1425331596-19897-1-git-send-email-paul@denknerd.org> <1425331596-19897-3-git-send-email-paul@denknerd.org> <87k2yzm1du.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSln5-0002SY-HG for guix-devel@gnu.org; Tue, 03 Mar 2015 07:19:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSln1-00038J-4P for guix-devel@gnu.org; Tue, 03 Mar 2015 07:19:11 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSln1-00038C-0r for guix-devel@gnu.org; Tue, 03 Mar 2015 07:19:07 -0500 In-Reply-To: <87k2yzm1du.fsf@netris.org> (Mark H. Weaver's message of "Mon, 02 Mar 2015 18:21:33 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org Mark H Weaver skribis: > Paul van der Walt writes: > >> * gnu/packages/pdf.scm (djvulibre): New variable. >> --- >> gnu/packages/pdf.scm | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) > > The package looks good, but I'm not sure it belongs in pdf.scm. Maybe > the answer is to rename pdf.scm to something more general, perhaps > documents.scm? Or maybe this belongs somewhere else. Thoughts? > > I'd like to hear some opinions on this before okaying the push. Maybe just djvu.scm? Other than that LGTM. Thanks, Ludo=E2=80=99.