From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Various icedtea6 patches Date: Fri, 20 Mar 2015 21:17:04 +0100 Message-ID: <87a8z78lvj.fsf@gnu.org> References: <87wq2d5p9t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ3M0-0003Xl-Ib for guix-devel@gnu.org; Fri, 20 Mar 2015 16:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ3Lx-0008Qe-2B for guix-devel@gnu.org; Fri, 20 Mar 2015 16:17:12 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ3Lw-0008Qa-VN for guix-devel@gnu.org; Fri, 20 Mar 2015 16:17:08 -0400 In-Reply-To: (Ricardo Wurmus's message of "Thu, 19 Mar 2015 14:05:00 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >>> From 9c9ef4fde4003a3bc9af73462552edde5d46c909 Mon Sep 17 00:00:00 2001 >>> From: Ricardo Wurmus >>> Date: Tue, 10 Mar 2015 14:05:48 +0100 >>> Subject: [PATCH 3/5] gnu: icedtea6: patch patches in separate build pha= se. >>> >>> * gnu/packages/java.scm (icedtea6)[arguments]: patch patches in a separ= ate >>> build phase `patch-patches' instead of `patch-paths'. >> >> Is it really patches that are being patched? Not obvious from a quick >> look. > > Yes, it is patches being patched. OpenJDK comes with patches and some > of them have to be patched (rather than the sources), because they are > applied during the build phase, not at a point at which we could > interject another phase. > > In the diff it's not very clear, but looking at the resulting phase > after applying the patch you can see that there are only two substitute > expressions for the following files, all patches: > > "patches/jtreg-jrunscript.patch" > "patches/hotspot/hs23/drop_unlicensed_test.patch" > "patches/openjdk/6799141-split_out_versions.patch" Yuk, OK. Thanks for explaining. >> Anyway, maybe =E2=80=9CMove patching from =E2=80=98patch-paths=E2=80=99 = to new =E2=80=98patch-patches=E2=80=99 >> phase.=E2=80=9D > > Or maybe > > "Move patching of patches from =E2=80=98patch-paths=E2=80=99 to new =E2= =80=98patch-patches=E2=80=99 > phase.", > > because it's not actually patching of sources but patching of patches? OK! Thank you, Ludo'.