From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Thompson <dthompson2@worcester.edu>
Subject: Re: [PATCH] gnu: flexbar: Enable tests.
Date: Mon, 27 Apr 2015 06:57:55 -0400
Message-ID: <87a8xt96to.fsf@fsf.org>
References: <idjvbghew8y.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Ymgjf-0005LD-Vh
	for guix-devel@gnu.org; Mon, 27 Apr 2015 06:58:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Ymgje-0002nm-Q6
	for guix-devel@gnu.org; Mon, 27 Apr 2015 06:57:59 -0400
Received: from mail.fsf.org ([208.118.235.13]:54273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Ymgje-0002ng-Mm
	for guix-devel@gnu.org; Mon, 27 Apr 2015 06:57:58 -0400
In-Reply-To: <idjvbghew8y.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> this patch enables the tests of flexbar.  There is no check target but a
> validation script and some test data, so I'm just running the script
> instead of "make check".

Looks fine to me!  Minor critique below:

> From 7568ba7f62bcbc8ac50a892d8bb58782603a2c70 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 27 Apr 2015 11:48:00 +0200
> Subject: [PATCH] gnu: flexbar: Enable tests.
>
> * gnu/packages/bioinformatics.scm (flexbar): Enable tests.
> ---
>  gnu/packages/bioinformatics.scm | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index fc07bcf..42b1f4f 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -623,15 +623,20 @@ results.  The FASTX-Toolkit tools perform some of these preprocessing tasks.")
>                  "13jaykc3y1x8y5nn9j8ljnb79s5y51kyxz46hdmvvjj6qhyympmf"))))
>      (build-system cmake-build-system)
>      (arguments
> -     `(;; There is no test target, although there is a directory containing
> -       ;; test data and scripts (launched by flexbar_validate.sh).
> -       #:tests? #f
> -       #:configure-flags (list
> +     `(#:configure-flags (list
>                            (string-append "-DFLEXBAR_BINARY_DIR="
>                                           (assoc-ref %outputs "out")
>                                           "/bin/"))
>         #:phases
> -       (alist-delete 'install %standard-phases)))
> +       (alist-replace
> +        'check
> +        (lambda* (#:key outputs #:allow-other-keys)
> +          (setenv "PATH" (string-append
> +                          (assoc-ref outputs "out") "/bin:"
> +                          (getenv "PATH")))
> +          (chdir "../flexbar_v2.5_src/test")
> +          (zero? (system* "bash" "flexbar_validate.sh")))
> +        (alist-delete 'install %standard-phases))))

Consider rewriting using 'modify-phases' syntax.

>      (inputs
>       `(("tbb" ,tbb)
>         ("zlib" ,zlib)))
> -- 
> 2.1.0
>

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate