From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH]: gnu: shogun: Remove non-free source files. Date: Sat, 09 May 2015 01:15:52 -0400 Message-ID: <87a8xeqqk7.fsf@netris.org> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqx7L-0006tA-5s for guix-devel@gnu.org; Sat, 09 May 2015 01:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yqx7I-0001AB-1J for guix-devel@gnu.org; Sat, 09 May 2015 01:16:03 -0400 Received: from world.peace.net ([50.252.239.5]:44731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqx7H-0001A7-UF for guix-devel@gnu.org; Sat, 09 May 2015 01:15:59 -0400 In-Reply-To: (Ricardo Wurmus's message of "Fri, 8 May 2015 16:56:28 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus writes: > Thanks to Bavier for bringing this issue to my attention. This patch > removes two source files that are released under a non-free license. Sounds good, thanks! > There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also > released under non-free terms, but they are enclosed in #ifdef > statements and the make flags we pass disable these functions at build > time. This is not sufficient. We will need to completely remove the non-free functions from the source code using a snippet. We cannot use a patch because the patch would contain the non-free code. Mark