From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] Add preseq. Date: Thu, 09 Jul 2015 11:55:09 -0400 Message-ID: <87a8v5qqaq.fsf@netris.org> References: <87r3osronp.fsf@gnu.org> <87egkrq5xa.fsf@gnu.org> <87k2uakdpm.fsf@gnu.org> <87si8yl1hq.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDEAT-0000Ut-Oj for guix-devel@gnu.org; Thu, 09 Jul 2015 11:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDEAP-0007lD-Lb for guix-devel@gnu.org; Thu, 09 Jul 2015 11:55:21 -0400 Received: from world.peace.net ([50.252.239.5]:40130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDEAP-0007l8-ID for guix-devel@gnu.org; Thu, 09 Jul 2015 11:55:17 -0400 In-Reply-To: (Ricardo Wurmus's message of "Thu, 9 Jul 2015 12:16:29 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus writes: >> ERROR: In procedure mkstemp!: >> ERROR: In procedure mkstemp!: No such file or directory >> builder for `/gnu/store/2ll28ypms57h0k44f4mmclhw9dz3ccvm-preseq-1.0.2.dr= v' failed with exit code 1 >> @ build-failed >> /gnu/store/2ll28ypms57h0k44f4mmclhw9dz3ccvm-preseq-1.0.2.drv - 1 >> builder for >> `/gnu/store/2ll28ypms57h0k44f4mmclhw9dz3ccvm-preseq-1.0.2.drv' >> failed with exit code 1 >> guix build: error: build failed: build of `/gnu/store/2ll28ypms57h0k44f4= mmclhw9dz3ccvm-preseq-1.0.2.drv' failed > > The problem was that the =E2=80=9Center-dir=E2=80=9D and =E2=80=9Cuse-sam= tools-headers=E2=80=9D phases > were both added after =E2=80=9Cunpack=E2=80=9D. (Has the order in which = phases are > added with =E2=80=98modify-phases=E2=80=99 changed? No. It's deterministic, and 'modify-phases' is in (guix build utils) so it can't be changed without triggering a full rebuild. The edits are done in the order shown, as if it was imperative code. For example: (modify-phases %standard-phases (add-after 'unpack 'A ) (add-after 'unpack 'B )) expands into: (let* ((phases* %standard-phases) (phases* (alist-cons-after 'unpack 'A phases*)) (phases* (alist-cons-after 'unpack 'B phases*))) phases*) which is equivalent to: (alist-cons-after 'unpack 'B (alist-cons-after 'unpack 'A %standard-phases)) Since B is the last one added, it ends up after 'unpack' and before A. > When I built it locally back then =E2=80=9Cuse-samtools-headers=E2=80=9D = must have > ended up after =E2=80=9Center-dir=E2=80=9D.) I don't see how that could have happened. Maybe you made some changes after your last test? Anyway, if 'use-samtools-headers' must come after 'enter-dir' then it's surely better to make that explicit. > I just pushed a commit that explicitly moves =E2=80=9Cuse-samtools-header= s=E2=80=9D > after the =E2=80=9Center-dir=E2=80=9D phase, fixing this problem. Thank you! Mark