From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] openblas on MIPS.
Date: Thu, 29 Oct 2015 21:36:44 +0100
Message-ID: <87a8r18l9f.fsf@gnu.org>
References: <idjoafh6862.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39788)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZrtwJ-0002hg-NV
	for guix-devel@gnu.org; Thu, 29 Oct 2015 16:36:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZrtwF-0007fj-MV
	for guix-devel@gnu.org; Thu, 29 Oct 2015 16:36:51 -0400
In-Reply-To: <idjoafh6862.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 29 Oct 2015 15:50:13 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> I tried building OpenBLAS on one of the MIPS build slaves and it went
> through the build phase without errors when I set the TARGET to
> SICORTEX.  Unfortunately, this doesn=E2=80=99t mean that OpenBLAS actuall=
y works
> on MIPS: one of the tests fails.
>
> Meanwhile OpenBLAS version 0.2.15 was released and I just updated our
> package.  It may well be that this bug has already been fixed by the new
> release.
>
> At any rate, I think the two attached patches (one to pass
> TARGET=3DSICORTEX on MIPS; another to enable substitutes for MIPS) are an
> improvement.  We can use substitutes for MIPS (and ARM for that matter)
> only when TARGET is specified.  The only MIPS target that seems to work
> for us appears to be SICORTEX as the other supported targets use
> Loongson extensions.

Nice!

> From 5132d4f9a36e65439b1295c672ad41364016e6a9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 29 Oct 2015 15:42:09 +0100
> Subject: [PATCH 1/2] gnu: openblas: Set TARGET to SICORTEX on MIPS.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=3DSICORTEX" to
>   make-flags when building for MIPS.

Sounds good but=E2=80=A6

> -                   '("DYNAMIC_ARCH=3D1")
> -                   ;; On MIPS we force the SICORTEX TARGET, as for the o=
ther
> -                   ;; two available MIPS targets special Loongson extend=
ed
> -                   ;; instructions are used.
> -                   (if (string-prefix? "mips" (%current-system))
> -                       '("TARGET=3DSICORTEX")

This doesn=E2=80=99t seem to be a patch against master, is it?

> From b281c60fe666082040097c0d585e942fa5fa1550 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 29 Oct 2015 15:43:21 +0100
> Subject: [PATCH 2/2] gnu: openblas: Make substitutable on MIPS.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Make package
>   substitutable when the system is MIPS.

OK.

Thanks for the tireless investigation work!

Ludo=E2=80=99.