From: Mark H Weaver <mhw@netris.org>
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: Add ppp.
Date: Mon, 16 Nov 2015 16:56:27 -0500 [thread overview]
Message-ID: <87a8qd1ud0.fsf@netris.org> (raw)
In-Reply-To: <1447653973-3839-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Mon, 16 Nov 2015 14:06:10 +0800")
宋文武 <iyzsong@gmail.com> writes:
> * gnu/packages/samba.scm (ppp): New variable.
> ---
> gnu/packages/samba.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/samba.scm b/gnu/packages/samba.scm
> index d7223bc..8d86249 100644
> --- a/gnu/packages/samba.scm
> +++ b/gnu/packages/samba.scm
> @@ -23,6 +23,7 @@
> #:use-module (guix build-system gnu)
> #:use-module (guix licenses)
> #:use-module (gnu packages acl)
> + #:use-module (gnu packages admin)
> #:use-module (gnu packages popt)
> #:use-module (gnu packages openldap)
> #:use-module (gnu packages readline)
> @@ -196,3 +197,44 @@ Desktops into Active Directory environments using the winbind daemon.")
> "Talloc is a hierarchical, reference counted memory pool system with
> destructors. It is the core memory allocator used in Samba.")
> (license gpl3+))) ;; The bundled "replace" library uses LGPL3.
> +
> +(define-public ppp
> + (package
> + (name "ppp")
> + (version "2.4.7")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://www.samba.org/ftp/ppp/ppp-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "0c7vrjxl52pdwi4ckrvfjr08b31lfpgwf3pp0cqy76a77vfs7q02"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:tests? #f ; no check target
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda _
> + (setenv "CC" "gcc")
How about #:make-flags '("CC=gcc") instead? That's what I did in:
http://git.savannah.gnu.org/cgit/guix.git/commit/?h=wip-network-manager&id=d83bc88067404d4005d6e84724901e34e3d218c9
> + (substitute* "pppd/Makefile.linux"
> + (("/usr/include/crypt\\.h")
> + (string-append (assoc-ref %build-inputs "libc")
> + "/include/crypt.h"))
> + (("/usr/include/pcap-bpf.h")
> + (string-append (assoc-ref %build-inputs "libpcap")
> + "/include/pcap-bpf.h")))
> + (zero? (system* "./configure"
> + (string-append "--prefix=" %output))))))))
Also, instead of replacing the 'configure' phase, how about patching
Makefile.linux in a new phase? Our default 'configure' phase now does
things like passing --build to ensure a deterministic build triplet,
whereas on systems like ARM the guessed triplet depends on the build
machine. So, it would be good to use the default 'configure' phase when
possible.
> + (inputs
> + `(("libpcap" ,libpcap)))
> + (synopsis "Implementation of the Point-to-Point Protocol")
> + (home-page "https://ppp.samba.org/")
> + (description
> + "The Point-to-Point Protocol (PPP) provides a standard way to establish
> +a network connection over a serial link. At present, this package supports IP
> +and IPV6 and the protocols layered above them, such as TCP and UDP.")
> + ;; pppd, pppstats and pppdump are under BSD-style notices.
> + ;; some of the pppd plugins are GPL'd.
> + ;; chat is public domain.
> + (license (list bsd-3 bsd-4 gpl2+ public-domain))))
Otherwise looks good to me!
Thanks,
Mark
next prev parent reply other threads:[~2015-11-16 21:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 6:06 [PATCH 1/4] gnu: Add ppp 宋文武
2015-11-16 6:06 ` [PATCH 2/4] gnu: Add network-manager 宋文武
2015-11-17 15:56 ` Ludovic Courtès
2015-11-17 16:14 ` Mark H Weaver
2015-11-16 6:06 ` [PATCH 3/4] gnu: Add network-manager-applet 宋文武
2015-11-17 15:57 ` Ludovic Courtès
2015-11-17 16:14 ` Mark H Weaver
2015-11-16 6:06 ` [PATCH 4/4] services: Add network-manager-service 宋文武
2015-11-17 16:01 ` Ludovic Courtès
2015-11-26 6:01 ` 宋文武
2015-11-26 8:49 ` Ludovic Courtès
2015-11-27 21:26 ` Ludovic Courtès
2015-11-16 21:56 ` Mark H Weaver [this message]
2015-11-17 2:01 ` [PATCH 1/4] gnu: Add ppp 宋文武
2015-11-16 21:59 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8qd1ud0.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).