From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Update Ruby to 2.3.0 (was Re: Freezing core-updates soon)
Date: Tue, 05 Jan 2016 23:24:54 +0100
Message-ID: <87a8ojk6kp.fsf@gnu.org>
References: <87wprqspc3.fsf@gnu.org>
	<CAJ=RwfarR6Pshy0HpPZp2W8377Ea=Fzb_3qygYErOhG7prsYgg@mail.gmail.com>
	<5689C833.3050608@uq.edu.au> <568A4D9E.3030504@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGa2G-0001Dq-Rz
	for Guix-devel@gnu.org; Tue, 05 Jan 2016 17:25:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGa2D-0006oH-Kg
	for Guix-devel@gnu.org; Tue, 05 Jan 2016 17:25:00 -0500
In-Reply-To: <568A4D9E.3030504@uq.edu.au> (Ben Woodcroft's message of "Mon, 4
	Jan 2016 20:46:54 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: Guix-devel <Guix-devel@gnu.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> I had some trouble downloading dependencies because of inability to
> download sources e.g. http://graphviz.org/ seems to be down. Ruby
> seems to build though, can we just review as normal and then push to
> core-updates?
>
> I did rebuild all the packages in ruby.scm, and out of these about 1/3
> of packages failed to build, because at least these three packages'
> tests fail
> * yard
> * power_assert
> * minitest_tu_shim
>
> The first two presumably will be fixed upstream soon, but the third
> hasn't seen a release since Aug 2013, and the homepage listed on
> rubygems is dead. I guess we just have to encourage the only package
> we have packaged that uses tu_shim (term-ansicolor) to stop relying on
> it.

OK, thanks for testing this thoroughly.  It would be good to fix these 3
packages sometime before core-updates is merged.

> From cd8c4e078cb930d1ce928b3c614b2081ec6719ac Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Mon, 4 Jan 2016 09:38:42 +1000
> Subject: [PATCH] gnu: ruby: Update to 2.3.0.
>
> * gnu/packages/ruby.scm (ruby): Update to 2.3.0.
> (ruby-2.2): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'configure 'replace-bin-sh
> +           (lambda _
> +             (substitute* '("Makefile.in"
> +                            "ext/pty/pty.c"
> +                            "io.c"
> +                            "lib/mkmf.rb"
> +                            "process.c"
> +                            "test/rubygems/test_gem_ext_configure_builde=
r.rb"
> +                            "test/rdoc/test_rdoc_parser.rb"
> +                            "test/ruby/test_rubyoptions.rb"
> +                            "test/ruby/test_process.rb"
> +                            "test/ruby/test_system.rb"
> +                            "tool/rbinstall.rb")
> +               (("/bin/sh") (which "sh")))
> +             (substitute* "ext/fiddle/libffi-3.2.1/configure"
> +               (("SHELL =3D /bin/sh")
> +                (string-append "SHELL =3D " (which "sh"))))
> +             #t)))))
> +    (inputs
> +     `(("readline" ,readline)
> +       ("openssl" ,openssl)
> +       ("libffi" ,libffi)
> +       ("gdbm" ,gdbm)
> +       ("zlib" ,zlib)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "GEM_PATH")
> +            (files (list (string-append "lib/ruby/gems/"
> +                                        (version-major+minor version)
> +                                        ".0"))))))

This seems to be shared with 2.2.  Is it possible to avoid duplication
using something like:

  (define ruby
    (package
      (inherit ruby-2.2)
      (version "2.3.4")
      ;; =E2=80=A6
      ))

?

Thanks,
Ludo=E2=80=99.