From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH] gnu: Add tracker. Date: Sun, 07 Feb 2016 10:19:36 +0800 Message-ID: <87a8ndxnwn.fsf@member.fsf.org> References: <841c96ec184a9d17c5f4f9d662c018b4@openmailbox.org> <20160206222848.GC8398@jasmine> <4dcfb677f5dcedb93000cf585246fb58@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSExA-0006Mo-3f for guix-devel@gnu.org; Sat, 06 Feb 2016 21:19:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSEx6-0006eD-RL for guix-devel@gnu.org; Sat, 06 Feb 2016 21:19:56 -0500 Received: from mail2.openmailbox.org ([62.4.1.33]:56126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSEx6-0006e0-Ku for guix-devel@gnu.org; Sat, 06 Feb 2016 21:19:52 -0500 In-Reply-To: <4dcfb677f5dcedb93000cf585246fb58@openmailbox.org> (rennes@openmailbox.org's message of "Sun, 07 Feb 2016 01:55:38 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: rennes@openmailbox.org Cc: guix-devel@gnu.org rennes@openmailbox.org writes: > On 2016-02-06 23:28, Leo Famulari wrote: >> On Sat, Feb 06, 2016 at 09:47:22PM +0100, rennes@openmailbox.org wrote: >>> Hi, >>> >>> i attached patch with new variable(tracker) for gnome.scm. >>> >>> Tracker, is a search engine and metadata storage system used for >>> nautilus(gnome file manager). >>> >>> The steps i follow are: >>> >>> a) I edit gnu/packages/gnome.scm and added tracker variable. >>> b) git add gnu/packages/gnome.scm >>> c) git commit -m 'gnu: Add tracker.' >>=20 >> Don't forget: >> c=E2=80=B2) ./pre-inst-env guix lint tracker >>=20 >>> d) git format-patch -1 >>=20=20=20 >> [...] >>=20 >>> * gnu/packages/gnome.scm (tracker): New variable. >>=20 >> Okay. >>=20 >>> + (arguments >>> + ;; Testsuite finishes with errors. >>> + `(#:configure-flags '("--enable-unit-tests=3Dno"))) >>=20 >> Are these failures important? Are they caused by the unusual Guix build >> environment? If so, can you disable only the specific tests that are >> failing? >>=20 >> Otherwise, I wait for the input of a GNOME / GTK expert :) >>=20 >>> + (native-inputs >>> + `(("glib" ,glib) ; for glib-compile-schemas, gio-2.0. Should be ("glib:bin" ,glib "bin"), `,glib "bin"` mean use the "bin" output of the glib package, and "glib:bin" is a name for this input, name is not important, but we usually use that. >>> + ("intltool" ,intltool) >>> + ("pkg-config" ,pkg-config))) >>> + (inputs >>> + `(("gobject-introspection" ,gobject-introspection) >>> + ("libpng" ,libpng) >>> + ("libunistring" ,libunistring) >>> + ("libxml2" ,libxml2) >>> + ("sqlite" ,sqlite) >>> + ("uuidgen" ,util-linux) >>> + ("xsltproc" ,libxslt) >>> + ("zlib" ,zlib))) I think gobject-introspection, uuidgen and xsltproc should move to native-inputs if they are only used during build phases\. You can check that after build with `guix size tracker' to see if those inputs are still in the closure. >>> + (home-page "https://wiki.gnome.org/Projects/Tracker") >>> + (synopsis "Search engine and metadata storage system") >>> + (description >>> + "Tracker is a search engine, search tool and metadata storage >>> +system. Tracker allows the user to find their data as fast as possibl= e. >>> +Tracker organises data in categories and enable tag in the data with >>> +keywords which can be used to find related information.") For GNOME projects, which have detailed doap file, I prefer synopsis and description from upstream: https://git.gnome.org/browse/tracker/tree/tracker.doap >>> + ;; See COPYING for details. >>> + (license (list license:lgpl2.1+ license:gpl2+ license:bsd-3)))) >>> -- >>> 2.6.3 >>> > > Thanks Leo, > > the errors during Testsuite are: > > ERROR: tracker-utils - missing test plan > ERROR: tracker-utils - exited with status 133 (terminated by signal > 5?) > PASS: tracker-dbus 1 /libtracker-common/tracker-dbus/slist_to_strv_ok > PASS: tracker-dbus 2 > /libtracker-common/tracker-dbus/slist_to_strv_failures > PASS: tracker-dbus 3 /libtracker-common/tracker-dbus/request > ERROR: tracker-file-utils - missing test plan > ERROR: tracker-file-utils - exited with status 133 (terminated by > signal 5?) > > Testsuite summary for tracker 1.7.2 > > # TOTAL: 68 > # PASS: 42 > # SKIP: 22 > # XFAIL: 0 > # FAIL: 0 > # XPASS: 0 > # ERROR: 4 > > I can`t see more details. The log files (test-suite.log or *.log) should have more details, you can build with 'guix build -K tracker' to keep the directory, and look the log files.